Skip to content

Add interop module for fs2 3.x#217

Merged
vigoo merged 6 commits intovigoo:masterfrom
kubukoz:fs2-3
May 22, 2021
Merged

Add interop module for fs2 3.x#217
vigoo merged 6 commits intovigoo:masterfrom
kubukoz:fs2-3

Conversation

@kubukoz
Copy link
Copy Markdown
Contributor

@kubukoz kubukoz commented Mar 14, 2021 •
edited
Loading

Will close #215 when ready.

Note that there are no tests for now because ZIO interop isn't published yet, and I didn't want to change the whole test infra to use IO directly ;)

First commit is copy-pasting the 2.x version, second commit makes the necessary changes (for ease of review).

@kubukoz
Copy link
Copy Markdown
Contributor Author

kubukoz commented Mar 14, 2021

Got a test failure, probably unrelated since it's a different module:

[info] - Piping processes together

[info]   - Termination

[info]     - can be killed

[[0minfo]       Map(ProcessImpl(perl,List(-e, $SIG{TERM} = 'IGNORE'; sleep 30; exit 2),None,Map(),Set(),StdOut(),io.github.vigoo.prox.ProcessModule$Process$$$Lambda$10535/1458457305@db4dcd3,StdOut(),io.github.vigoo.prox.ProcessModule$Process$$$Lambda$10536/2106855717@73f5a6d0,StdIn()) -> ExitCode(137), ProcessImpl(sort,List(),None,Map(),Set(),StdOut(),io.github.vigoo.prox.ProcessModule$Process$$$Lambda$10535/1458457305@3b07568,StdOut(),io.github.vigoo.prox.ProcessModule$Process$$$Lambda$10536/2106855717@72dc6746,StdIn()) -> ExitCode(0)) did not satisfy equalTo(Map(ProcessImpl(perl,List(-e, $SIG{TERM} = 'IGNORE'; sleep 30; exit 2),None,Map(),Set(),StdOut(),io.github.vigoo.prox.ProcessModule$Process$$$Lambda$10535/1458457305@db4dcd3,StdOut(),io.github.vigoo.prox.ProcessModule$Process$$$Lambda$10536/2106855717@73f5a6d0,StdIn()) -> ExitCode(137), ProcessImpl(sort,List(),None,Map(),Set(),StdOut(),io.github.vigoo.prox.ProcessModule$Process$$$Lambda$10535/1458457305@3b07568,StdOut(),io.github.vigoo.prox.ProcessModule$Process$$$Lambda$10536/2106855717@72dc6746,StdIn()) -> ExitCode(137)))

[info]         at /home/travis/build/vigoo/prox/prox-zstream/src/test/scala/io/github/vigoo/prox/tests/zstream/ProcessGroupSpecs.scala:116

[info] Done

[error] Failed tests:

[error] 	io.github.vigoo.prox.tests.zstream.ProcessGroupSpecs

[error] (prox-zstream / Test / test) sbt.TestsFailedException: Tests unsuccessful

might be a flaky test.

@kubukoz kubukoz mentioned this pull request Mar 14, 2021
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2021 •
edited
Loading

Codecov Report

Merging #217 (3a1126b) into master (1141d0a) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #217   +/-   ##
=====================================
- Coverage      83%    82%   -1%     
=====================================
  Files          12     11    -1     
  Lines         567    521   -46     
  Branches        5      4    -1     
=====================================
- Hits          473    430   -43     
+ Misses         94     91    -3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1141d0a...3a1126b. Read the comment docs.

@kubukoz kubukoz mentioned this pull request Mar 14, 2021
Closed
5 tasks
@vigoo
Copy link
Copy Markdown
Owner

vigoo commented Mar 19, 2021

Nice! Will take a look at the flaky test

This was referenced Apr 4, 2021
Closed
Closed
@vigoo
Copy link
Copy Markdown
Owner

vigoo commented Apr 4, 2021

Note: I fixed that flaky test

@kubukoz
Copy link
Copy Markdown
Contributor Author

kubukoz commented Apr 6, 2021 •
edited
Loading

I guess we're still stuck on the ZIO CE3 interop...

@vigoo
Copy link
Copy Markdown
Owner

vigoo commented Apr 7, 2021

Must be coming soon! :)

@kubukoz
Copy link
Copy Markdown
Contributor Author

kubukoz commented Apr 21, 2021

Gonna revisit this soon, zio-interop released v3.0.2.0 with CE3 support.

@vigoo
Copy link
Copy Markdown
Owner

vigoo commented May 20, 2021

Hey, can we merge this? Don't worry about the flaky code coverage check :) I'm disabling it for now

@kubukoz
Copy link
Copy Markdown
Contributor Author

kubukoz commented May 20, 2021

I wanted to update the docs to use the 3.x build, but if you want we can merge now :)

@vigoo vigoo marked this pull request as ready for review May 22, 2021 12:45
@vigoo vigoo merged commit 520bb0a into vigoo:master May 22, 2021
@kubukoz kubukoz deleted the fs2-3 branch May 22, 2021 13:06
@kubukoz kubukoz mentioned this pull request May 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to cats-effect 3

2 participants

@kubukoz @vigoo