fix: Only instantiate NavigatorMediaSession in browsers with support for the Media Session API.#1268
Merged
Merged
Conversation
soulprovidr
changed the title
NavigatorMediaSession in browsers with support for MediaMetadata.NavigatorMediaSession in browsers with support for the Media Session API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The Media Session API isn't supported universally, so this PR prevents uncaught exceptions by ensuring that the
NavigatorMediaSessionclass (which has a dependency on the Media Session API) is not instantiated in browsers without support.The check is copied from the example on the
MediaMetadataMDN page.Ready?
Yes
Anything Else?
caniuse.com: MediaSession API (94.08% global support)