Skip to content

Replace small percent sign with normal one for slider values#1215

Merged
mihar-22 merged 1 commit into
vidstack:mainfrom
DerStimmler:main
Mar 26, 2024
Merged

Replace small percent sign with normal one for slider values#1215
mihar-22 merged 1 commit into
vidstack:mainfrom
DerStimmler:main

Conversation

@DerStimmler

@DerStimmler DerStimmler commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

Description:

Almost the whole player uses the normal percent sign % (U+0025) to display percentages.

Except for the SliderValue component in which the small percent sign (U+FE6A) is used.

Since this character isn't available in many fonts it may look kind of weird:
image

For consistency and better font compatibility also just the default percent sign should be used:
image

Ready?

Yes

@mihar-22 mihar-22 merged commit 833f2e4 into vidstack:main Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants