fix(player): add workerd to node exports#1198
Merged
Merged
Conversation
Member
|
Thank you! |
|
Great to see this gets fixed now. It has been the biggest blocker for us to adopt vidstack. Thanks! @mihar-22 Any idea when we expect to see the next release? Thanks for developing such a helpful piece of software 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
Similair to #1196 but now it's for Cloudflare Workers/Pages instead of Deno.
Description:
Adds the
workerdkey to the packages conditional exports, so Cloudflare Workers will use the server bundle.Before it was using the browser bundle which broke my Nuxt 3 site when server-side rendering the Vidstack player.
I've tried to just 1-to-1 matches the changes made for Bun and Deno yesterday.
Ready?
Yes.
Anything Else?
Cloudflare's docs on the
workerdexports keyReview Process:
npm inpm run build && npx wrangler pages dev dist/Before the change it fails like so:
After the change it instead starts the server and you can go to http://localhost:8788/other-page and it loads without throwing any errors.