feat: text track display overlays a video - #8009
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8009 +/- ##
==========================================
+ Coverage 80.98% 81.19% +0.21%
==========================================
Files 116 116
Lines 7472 7494 +22
Branches 1817 1821 +4
==========================================
+ Hits 6051 6085 +34
+ Misses 1421 1409 -12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gkatsev
reviewed
Nov 22, 2022
gkatsev
left a comment
gkatsev
left a comment
Member
There was a problem hiding this comment.
Awesome, this works well!
Had a couple of minor comments.
gkatsev
approved these changes
Nov 22, 2022
misteroneill
force-pushed
the
main
branch
2 times, most recently
from
November 23, 2022 01:30
c1898b4 to
4f8227d
Compare
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Text track display does not always overlay a video which may generate a different text track size and position across different browsers and devices.
Specific Changes proposed
The text track display always overlays a video.
Requirements Checklist