Repository navigation
bail if new tag does not directly follow previous version - #4855
Merged
Merged
Conversation
This is to try and prevent typos that could trigger an incorrect version publish into the future that cannot be undone. refs #4841
tjenkinson
commented
Aug 18, 2022
| function exec(cmd) { | ||
| return require('child_process').execSync(cmd).toString().trim(); | ||
| return require('child_process') | ||
| .execSync(cmd, { stdio: 'pipe' }) |
Member
Author
There was a problem hiding this comment.
without setting stdio the default for stdout is pipe but stderr goes through to console
tjenkinson
marked this pull request as ready for review
August 18, 2022 09:35
tjenkinson
commented
Aug 18, 2022
robwalch
approved these changes
Aug 25, 2022
akashchamp
pushed a commit
to akashchamp/hls.js
that referenced
this pull request
Sep 25, 2026
…4855) * bail if new tag does not directly follow previous version This is to try and prevent typos that could trigger an incorrect version publish into the future that cannot be undone. refs video-dev#4841 * do not bail if tag exists, because it would for real tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will...
Bail if new tag (stable or prerelease) does not directly follow previous version.
For prereleases there's no restriction on the prerelease part (following the
-), other than the stable part must follow a previous stable version.refs #4841
Why is this Pull Request needed?
This is to try and prevent typos that could trigger an incorrect version publish into the future that cannot be undone.
Something similar happened in #4841