Skip to content

[quick_actions] Adopt code-excerpts for README - #34

Closed
danielleon-cmd wants to merge 88 commits into
mainfrom
fpoctsmp-10-quick-actions-readme-excerpts
Closed

danielleon-cmd wants to merge 88 commits into
mainfrom
fpoctsmp-10-quick-actions-readme-excerpts

Conversation

@danielleon-cmd

@danielleon-cmd danielleon-cmd commented Aug 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Replaces the hand-written Dart snippets in quick_actions's README with <?code-excerpt?> pragmas backed by example/lib/readme_excerpts.dart, so they're validated against compilable, analyzed source instead of free-hand text (the original used an untyped callback parameter and print(), which the repo's lint rules disallow).
  • Drops the package's ci_config.yaml, whose only purpose was opting it out of that validation.
  • Adds a CHANGELOG entry under NEXT.

Follows the same pattern as #32 ([pointer_interceptor] Adopt code-excerpts for README).

Part of flutter/flutter#102679.

FPOCTSMP-10

Test plan

  • dart run script/tool/bin/flutter_plugin_tools.dart update-excerpts --packages=quick_actions — no diff after regeneration
  • dart run script/tool/bin/flutter_plugin_tools.dart validate --packages=quick_actions — no issues
  • flutter analyze in example/ — no issues
  • dart format --output=none --set-exit-if-changed on the new excerpts file — no changes needed
  • flutter test in the package — all tests pass

stuartmorgan-g and others added 2 commits August 25, 2026 16:42
…ackages (flutter#12307)

This converts GoogleMapsPlugin, GoogleMapFactory, and GoogleMapController to Swift, and restructures the source code to typical migration state of having the Swift code be the primary target, depending on a new `*_objc` target that contains the unmigrated code. Because `google_maps_flutter_ios` cannot adopt Swift (see discussion in linked issue), this removes that package from the code sharing. Going forward, development will be limited to the `_sdk*` packages.

For reasons explained [here](flutter/flutter#119108 (comment)), the Pigeon API layer is still Objective-C for now, which does lead to some temporary non-ideal code in GoogleMapController. That will be cleaned up in the last step when we are able to switch to Swift Pigeon generation.

The remaining Obj-C code will be migrated in a series of follow-up PRs to keep the scope of each PR reasonable for review.

The conversion process was:
- Initial conversion via Gemini, with explicit instruction to keep the structure the same.
- Side-by-side manual review of the old and new versions of the files.
- Manual fixes and improvements.

The last step was more extensive than usual because the init method had longstanding design issues (flutter/flutter#104121) that became hard errors under Swift. There was some refactoring of helper methods and reordering of initialization steps to make the code work with the strict two-phase init process.

Part of flutter/flutter#119108
Fixes flutter/flutter#104121

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Work towards flutter/flutter#186906, flutter/flutter#191088

**Ports over flutter#11762 which landed on the `m3e_migration` feature branch.**

Since CI was not set up to run on that branch, I've pushed up a few more changes after the ported commits to get all the repo checks/tests to pass.

### Original PR description
Adds the initial gen_defaults sub-directory with the initial TokenTemplate and generator. This is simply the initial scaffold, we will need to add additional helper functions as necessary as we begin adding the actual templates.

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

@victogomez-cs victogomez-cs left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as #32: README changes need to be published, so this shouldn’t stay under ## NEXT. Please convert ## NEXT to a real version (new excerpt bullet first, existing NEXT items below it) and bump pubspec.yaml

danielleon-cmd added a commit that referenced this pull request Aug 25, 2026
Since these README changes will be published, they can't stay under
`## NEXT` (same issue as #32/#34's review). Converts NEXT to a real
version, with the new excerpt bullet first and the pre-existing NEXT
items below it.

FPOCTSMP-10

Co-Authored-By: Claude Sonnet 5 <[email protected]>
@danielleon-cmd

Copy link
Copy Markdown
Collaborator Author

Addressed: converted ## NEXT to ## 1.1.1 in the CHANGELOG (excerpt bullet first, existing items below it) and bumped pubspec.yaml to 1.1.1 in 8ec30ab.

🤖 Addressed by Claude Code

jason-simmons and others added 5 commits August 25, 2026 19:56
…r tool/gen_defaults (flutter#12623)

This is required for running the Dart analyzer within the tool/gen_defaults package.
…pub get` on pacakage (flutter#12626)

Fix tool package in `material_ui`.

Post submit fix for flutter#12623

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…lutter#12627)

Work towards flutter/flutter#191088

**Ports over flutter#11918 which landed on the `m3e_migration` feature branch.**

### Original PR description

Work towards flutter/flutter#186906
Work towards flutter/flutter#187899

Previously, the `gen_defaults` script generated the files in different directories based on whether or not the template was an M3 or M3E template. Since we are planning on using an variant enum instead of different libraries to separate M3 and M3E implementations, the `gen_defaults` script needs to be accordingly updated.

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…tter#12618)

This converts CircleController, PolygonController, and PolylineController to Swift in the `_sdk*` packages.

The remaining Obj-C code will be migrated in a series of follow-up PRs to keep the scope of each PR reasonable for review.

The conversion process was:
- Initial conversion via Gemini, with explicit instruction to keep the structure the same.
- Side-by-side manual review of the old and new versions of the files.
- Manual fixes and improvements.

This includes test changes beyond what we would normally expect for a language conversion PR (e.g., name changes from dropping the prefix) because the conversion to Swift exposed a latent issue in the tests. Several tests had a pattern where a helper method was creating a local `mapView` instance, using it to construct the subcontroller under test, and then returning that subcontroller—at which point the map view goes out of scope. The subcontrollers have weak references to the map view, so it can be deallocated before the test actually runs, and doing so causes the tests to fail (as many operations in the subcontroller no-op when the map view is nil). In cases where the helper is only used once, it can be inlined; in cases where it's used repeatedly we can instead return multiple values and keep the map view alive.

Part of flutter/flutter#119108

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…r#12619)

Roll Flutter from 9a8278982588 to 15d8908addf6 (37 revisions)

flutter/flutter@9a82789...15d8908

2026-08-25 [email protected] Roll Packages from df2ba94 to 740f093 (17 revisions) (flutter/flutter#191734)
2026-08-25 [email protected] [record_use] Remove const_finder (flutter/flutter#191702)
2026-08-25 [email protected] Warn when SwiftPM is disabled (flutter/flutter#188695)
2026-08-25 [email protected] Roll Skia from b1a31575c373 to 480540178356 (1 revision) (flutter/flutter#191723)
2026-08-25 [email protected] Roll pub packages (flutter/flutter#191726)
2026-08-25 [email protected] Roll Skia from bfa276ed9ac5 to b1a31575c373 (1 revision) (flutter/flutter#191717)
2026-08-25 [email protected] Roll Dart SDK from 0818e6dc28cc to 8996935d3d0a (2 revisions) (flutter/flutter#191706)
2026-08-25 [email protected] Roll Skia from 31799e707cd4 to bfa276ed9ac5 (1 revision) (flutter/flutter#191701)
2026-08-25 [email protected] iOS: Add null check for touch rate correction task runner (flutter/flutter#191641)
2026-08-25 [email protected] iOS: Add test for engineAllowHeadlessExecution (flutter/flutter#191635)
2026-08-25 [email protected] Roll Skia from cfae2af1bfeb to 31799e707cd4 (4 revisions) (flutter/flutter#191649)
2026-08-25 [email protected] Roll Dart SDK from 2b75c83ddd77 to 0818e6dc28cc (1 revision) (flutter/flutter#191643)
2026-08-25 [email protected] Roll Skia from 4a2fddefd3d8 to cfae2af1bfeb (1 revision) (flutter/flutter#191642)
2026-08-25 [email protected] Roll Skia from 256c15026b91 to 4a2fddefd3d8 (6 revisions) (flutter/flutter#191633)
2026-08-25 [email protected] Remove octant_offset_c uniform from ubersdf, reorder/document ubersdf uniforms (flutter/flutter#191597)
2026-08-25 [email protected] Roll Fuchsia Linux SDK from 8Xu4ujBJniC0nQGx3... to MstTWE1RDOT-RnrtH... (flutter/flutter#191621)
2026-08-25 [email protected] Roll Dart SDK from 78bbc37b6ff6 to 2b75c83ddd77 (3 revisions) (flutter/flutter#191614)
2026-08-24 [email protected] [flutter_tools] Fix $git typo in shared.bat to restore cache invalidation on Windows (flutter/flutter#191217)
2026-08-24 [email protected] Skip removed observers during app exit requests (flutter/flutter#190343)
2026-08-24 [email protected] [engine] Support UTF-8 paths in Windows filesystem and path APIs (flutter/flutter#191360)
2026-08-24 [email protected] Migrate ios driver tests batch 3 to simulators (flutter/flutter#191333)
2026-08-24 [email protected] Migrate texture example to material_ui (flutter/flutter#190673)
2026-08-24 [email protected] Remove outdated test todo about `dither` property of `Paint` (flutter/flutter#190936)
2026-08-24 [email protected] Add agent rule to prevent using material and cupertino in widget tests (flutter/flutter#191588)
2026-08-24 [email protected] [flutter_tools] Prevent crash when stdout is broken and print fails (flutter/flutter#191356)
2026-08-24 [email protected] Add FlViewRendererSubsurface (flutter/flutter#191389)
2026-08-24 [email protected] [Android] Inject `route` into manifest when specified on the command line in release mode (flutter/flutter#191328)
2026-08-24 [email protected] [AGP 9.1.0 Migration #3] Add buildModeFor overloads and wire Flutter dependencies through the new DSL (flutter/flutter#191218)
2026-08-24 [email protected] Roll Skia from 698c60bf58f1 to 256c15026b91 (1 revision) (flutter/flutter#191586)
2026-08-24 [email protected] On iOS 27+ devices, manually process lldb stops (flutter/flutter#191434)
2026-08-24 [email protected] [flutter_tools] Handle missing Xcode gracefully in getInfo and buildMacOS (flutter/flutter#191180)
2026-08-24 [email protected] [flutter_tools] Handle null version gracefully in CachedArtifact and MaterialFonts (flutter/flutter#191494)
2026-08-24 [email protected] [flutter_tools] Do not treat 'daemon' argument as daemon command in logger initialization (flutter/flutter#191442)
2026-08-24 [email protected] [flutter_tools] Resolve workspace root when running widget preview from member package (flutter/flutter#190952)
2026-08-24 [email protected] [native_assets] Roll native packages (flutter/flutter#191253)
2026-08-24 [email protected] [flutter_tools] Add --force flag to flutter channel (flutter/flutter#191579)
2026-08-24 [email protected] Roll Skia from 57968d087d18 to 698c60bf58f1 (1 revision) (flutter/flutter#191577)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

...
danielleon-cmd added a commit that referenced this pull request Aug 27, 2026
Same issue flagged on #32/#34: these README changes need to be
published, so they can't stay under `## NEXT`.

FPOCTSMP-5

Co-Authored-By: Claude Sonnet 5 <[email protected]>
danielleon-cmd added a commit that referenced this pull request Aug 27, 2026
Since these README changes will be published, they can't stay under
`## NEXT` (same issue as #32/#34's review). Converts NEXT to a real
version, with the new excerpt bullet first and the pre-existing NEXT
items below it.

FPOCTSMP-10
@danielleon-cmd
danielleon-cmd force-pushed the fpoctsmp-10-quick-actions-readme-excerpts branch from 8ec30ab to bf1351c Compare August 27, 2026 15:55
danielleon-cmd added a commit that referenced this pull request Aug 27, 2026
Same issue flagged on #32/#34: these README changes need to be
published, so they can't stay under `## NEXT`.

FPOCTSMP-5
Replaces the hand-written Dart snippets in the README with
<?code-excerpt?> pragmas backed by example/lib/readme_excerpts.dart, so
they're validated against compilable, analyzed source instead of being
free-hand text (one used an untyped callback parameter and print(),
which isn't allowed by the repo's lint rules). Also drops the
package's ci_config.yaml, whose only purpose was opting it out of that
validation.

Part of flutter/flutter#102679.

FPOCTSMP-10
Since these README changes will be published, they can't stay under
`## NEXT` (same issue as #32/#34's review). Converts NEXT to a real
version, with the new excerpt bullet first and the pre-existing NEXT
items below it.

FPOCTSMP-10
@danielleon-cmd
danielleon-cmd force-pushed the fpoctsmp-10-quick-actions-readme-excerpts branch from bf1351c to 729590c Compare August 27, 2026 16:08
danielleon-cmd added a commit that referenced this pull request Aug 27, 2026
Same issue flagged on #32/#34: these README changes need to be
published, so they can't stay under `## NEXT`.

FPOCTSMP-5
danielleon-cmd and others added 10 commits August 27, 2026 10:09
…c newline (flutter#12652)

fixes flutter/flutter#191892

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…2638)

This converts GroundOverlayController and TileOverlayController to Swift in the `_sdk*` packages.

The remaining Obj-C code will be migrated in a series of follow-up PRs to keep the scope of each PR reasonable for review.

The conversion process was:
- Initial conversion via Gemini, with explicit instruction to keep the structure the same.
- Side-by-side manual review of the old and new versions of the files.
- Manual fixes and improvements.

This includes test changes beyond what we would normally expect for a language conversion PR (e.g., name changes from dropping the prefix) because the conversion to Swift exposed a latent issue in the tests. Several tests had a pattern where a helper method was creating a local `mapView` instance, using it to construct the subcontroller under test, and then returning that subcontroller—at which point the map view goes out of scope. The subcontrollers have weak references to the map view, so it can be deallocated before the test actually runs, and doing so causes the tests to fail (as many operations in the subcontroller no-op when the map view is nil). In cases where the helper is only used once, it can be inlined; in cases where it's used repeatedly we can instead return multiple values and keep the map view alive.

Part of flutter/flutter#119108

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…lutter#12581)

Currently sync back pr for batch release is created as soon as the batch release PR merges.

This can be a problem if the release workflow runs on the release branch fails and someone accidentally merge the sync back pr without knowing. It will be extremely hard to clean up in this case.

The PR changes it that the sync back pr is only created when release finishes successfully.

After this change, if release fails, we can simply delete the release branch and re trigger the batch release workflow to try again.

Merging this PR carry a risk if there is bug in the new code in release_from_branch workflow. If you don't see a sync back pr the next time batch release, let me know and i can help clean up and fix.

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…ness skill (flutter#12628)

This came up as part of flutter#12624 I
noticed that the pre-push skill passed my code but linux analyze failed.
It was because I didnt realize that this checkout (I have 2) didnt have
git hooks installed.

- @reidbaker 
---
Agent authored description 
Updates the `check-readiness` skill to verify that Git pre-commit hooks
(`script/githooks`) are configured in the repository (`core.hooksPath`).
If unconfigured or pointing to an unexpected path, it provides
actionable instructions to run `script/githooks/bin/install_hooks.dart`.

Includes unit test coverage in `check_test.dart`.

Part of flutter/flutter#188870

## Pre-Review Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran [the
auto-formatter].
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I [linked to at least one issue that this PR fixes] in the
description above.
- [x] I followed [the version and CHANGELOG instructions], using
[semantic versioning] and the [repository CHANGELOG style], or I have
commented below to indicate which documented exception this PR falls
under[^1].
- [x] I updated/added any relevant documentation (doc comments with
`///`).
- [x] I added new tests to check the change I am making, or I have
commented below to indicate which [test exemption] this PR falls
under[^1].
- [x] All existing and new tests are passing.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[the auto-formatter]:
https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code
[CLA]: https://cla.developers.google.com/
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
[linked to at least one issue that this PR fixes]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[the version and CHANGELOG instructions]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version-and-changelog-updates
[semantic versioning]:
https://dart.dev/tools/pub/versioning#semantic-versions
[repository CHANGELOG style]:
https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
[test exemption]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests

---------

Co-authored-by: Reid Baker <[email protected]>
… and fix TextEditingController leaks (flutter#12228)

This PR fixes the CupertinoIcons not being included in the actual examples and some leaks of TextEditingControllers,
which were things i noticed while fixing up cross imports (which by themselves have been fixed since then)

Part of flutter/flutter#187645

Since the Code Freeze period is still ongoing, I did not chance the version for cupertino_ui in the changelog yet.

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
)

Work towards flutter/flutter#191088

**Ports over flutter#12121 which landed on the `m3e_migration` feature branch.**

### Original PR description

Related to flutter/flutter#184950

This PR is to add some helper methods to handle color, and shape tokens. Also I updated the generated default class name from _M3xxx to _xxxM3 to keep the name consistent with the original M2 and M3 defaults.

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…aks (flutter#11653)

The package manipulates disposable objects. This PR activates leak testing to make sure disposable objects are correctly disposed.

It also fixes the memory leak warnings from the tests

See the documentation: https://github.com/dart-lang/leak_tracker/blob/main/doc%2Fleak_tracking%2FDETECT.md

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
…#12505)

Part of flutter/flutter#85160

Port of flutter/flutter#186655

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This is work towards dart-lang/sdk#59226

The lint rule use_super_parameters has a bug such that it didn't previously report these cases. But they will be reported soon.

## Pre-Review Checklist

Test exempt, as this code is covered by existing static and runtime checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment