Use generic approach for test data generation#1
Closed
snuyanzin wants to merge 1 commit intovicky-iv:color-testsfrom
Closed
Use generic approach for test data generation#1snuyanzin wants to merge 1 commit intovicky-iv:color-testsfrom
snuyanzin wants to merge 1 commit intovicky-iv:color-testsfrom
Conversation
kingthorin
reviewed
Nov 5, 2025
| arguments(TestSpec.of(colorBY::name, "color.name"), fakerBY), | ||
| arguments(TestSpec.of(colorDK::name, "color.name"), fakerDK)); | ||
| return FAKERS_MAP.values().stream() | ||
| .map(baseFaker -> TestSpec.of(() -> baseFaker.color().name(), "colr.name")) |
There was a problem hiding this comment.
Suggested change
| .map(baseFaker -> TestSpec.of(() -> baseFaker.color().name(), "colr.name")) | |
| .map(baseFaker -> TestSpec.of(() -> baseFaker.color().name(), "color.name")) |
Author
There was a problem hiding this comment.
yep, thanks
FYI: I put this as an idea, I didn't have green tests after that since no time ...
however I think it is the way to go
if it is still actual I can take a closer look on weekend probably
Owner
|
@snuyanzin Thank you for the PR, it's a great idea! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.