Merged
Conversation
The PR resolves some style issues in engine code. (Moved from PR #7242. )
Remove code from build.psm1 that save the modules to a versioned folder. For servicing reasons after release it is preferred and easier to not have the versioned folder so that we can directly replace modules that need to be serviced (MSI specifically makes it difficult to service a module if the folder path changes).
When trying to build on RHEL, the environment is not recognized as RedHatFamily. Added detection logic so that appropriate symbolic links are generated.
Update Start-PSPester and Start-PSxUnit to upload test results when running in VSTS Disable tests which require non-root using when running as root remove verifications in Test-Connection tests which verify buggy behavior Skip tests which don't behave correctly in VSTS (due to running in a container?) - Test-Connection - #7528 - Set-Date - #7529
Added fix to remove unneeded validation attribute for Arguments parameter, and made tests work with strict mode.
I missed this in reviewing #7518
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests