Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement error struct #119

Closed
prochac opened this issue Oct 20, 2021 · 3 comments · Fixed by #124
Closed

Implement error struct #119

prochac opened this issue Oct 20, 2021 · 3 comments · Fixed by #124
Labels
enhancement New feature or request

Comments

@prochac
Copy link

prochac commented Oct 20, 2021

Other sql drivers returns struct implementing error interface.
Ex.
https://pkg.go.dev/github.com/lib/pq#Error
https://pkg.go.dev/github.com/go-sql-driver/mysql#MySQLError
https://pkg.go.dev/github.com/jackc/pgconn#PgError
https://pkg.go.dev/github.com/denisenkom/go-mssqldb#Error
https://pkg.go.dev/github.com/snowflakedb/gosnowflake#SnowflakeError

Vertica returns pure string Error: [42V01] Relation "my_table" does not exist
The only possible way how to get the error code is parse the string, which is suboptimal.
And Unfortunately it is not possible if errors wrapping is used.
@sitingren sitingren added the enhancement New feature or request label Oct 20, 2021
@sitingren sitingren mentioned this issue Dec 10, 2021
Merged
sitingren added a commit that referenced this issue Dec 10, 2021
@sitingren
Fix #119 Implement VError (#124)
b1e74d3
@sitingren
Copy link
Member

The fix goes into v1.2.1: https://pkg.go.dev/github.com/vertica/vertica-sql-go#VError

@prochac
Copy link
Author

prochac commented Jan 3, 2022

So I should use https://pkg.go.dev/github.com/vertica/vertica-sql-go#VError.SQLState, right?
The values are well known and documented.
https://www.vertica.com/docs/9.2.x/HTML/Content/Authoring/ErrorCodes/SQLStates.htm

What value contains https://pkg.go.dev/github.com/vertica/vertica-sql-go#VError.ErrorCode then?

Thanks for the pull request 👍

@sitingren
Copy link
Member

@prochac The error code is described in https://www.vertica.com/docs/9.2.x/HTML/Content/Authoring/ErrorCodes/ErrorCodes.htm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #119
2 participants
@sitingren @prochac