Fix pkg onload test race (#3533)

vEpiphyte · web-flow · commit fa2a0b6befe0 · 2024-01-30T23:03:03.000-05:00
diff --git a/synapse/tests/test_lib_storm.py b/synapse/tests/test_lib_storm.py
@@ -2092,7 +2092,9 @@ async def get(self, name):
             msgs = await core.stormlist(f'pkg.load --ssl-noverify https://127.0.0.1:{port}/api/v1/pkgtest/notok')
             self.stormIsInWarn('pkg.load got JSON error: FooBar', msgs)
 
-            waiter = core.waiter(2, 'core:pkg:onload:complete')
+            replay = s_common.envbool('SYNDEV_NEXUS_REPLAY')
+            nevents = 4 if replay else 2
+            waiter = core.waiter(nevents, 'core:pkg:onload:complete')
 
             with self.getAsyncLoggerStream('synapse.cortex') as stream:
                 msgs = await core.stormlist(f'pkg.load --ssl-noverify https://127.0.0.1:{port}/api/v1/pkgtest/yep')
@@ -2109,10 +2111,10 @@ async def get(self, name):
             self.len(1, await core.nodes(f'ps:contact={cont}'))
 
             evnts = await waiter.wait(timeout=2)
-            self.eq([
-                ('core:pkg:onload:complete', {'pkg': 'testload'}),
-                ('core:pkg:onload:complete', {'pkg': 'testload'}),
-            ], evnts)
+            exp = []
+            for _ in range(nevents):
+                exp.append(('core:pkg:onload:complete', {'pkg': 'testload'}))
+            self.eq(exp, evnts)
 
     async def test_storm_tree(self):
 
