Fire an event when a pkg onload completes (SYN-6752) (#3497)

mikemoritz · web-flow · commit 4b7865263020 · 2024-01-17T08:14:11.000-08:00
diff --git a/synapse/cortex.py b/synapse/cortex.py
@@ -2728,6 +2728,7 @@ async def _onload():
                     raise
                 except Exception:  # pragma: no cover
                     logger.warning(f'onload failed for package: {name}')
+                await self.fire('core:pkg:onload:complete', pkg=name)
             self.schedCoro(_onload())
 
     async def _dropStormPkg(self, pkgdef):
diff --git a/synapse/tests/test_lib_storm.py b/synapse/tests/test_lib_storm.py
@@ -2071,6 +2071,8 @@ async def get(self, name):
             msgs = await core.stormlist(f'pkg.load --ssl-noverify https://127.0.0.1:{port}/api/v1/pkgtest/notok')
             self.stormIsInWarn('pkg.load got JSON error: FooBar', msgs)
 
+            waiter = core.waiter(2, 'core:pkg:onload:complete')
+
             with self.getAsyncLoggerStream('synapse.cortex') as stream:
                 msgs = await core.stormlist(f'pkg.load --ssl-noverify https://127.0.0.1:{port}/api/v1/pkgtest/yep')
                 self.stormIsInPrint('testload @0.3.0', msgs)
@@ -2085,6 +2087,12 @@ async def get(self, name):
             self.isin("No var with name: newp", buf)
             self.len(1, await core.nodes(f'ps:contact={cont}'))
 
+            evnts = await waiter.wait(timeout=2)
+            self.eq([
+                ('core:pkg:onload:complete', {'pkg': 'testload'}),
+                ('core:pkg:onload:complete', {'pkg': 'testload'}),
+            ], evnts)
+
     async def test_storm_tree(self):
 
         async with self.getTestCore() as core:
