Revert "OpenAPIHolderImpl.resolveExternalRef throws java.lang.IllegalStateException"

tsegismont · tsegismont · commit 992c4e3e84e9 · 2026-01-28T14:29:15.000+01:00
This reverts commit 34d4481.
diff --git a/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/OpenAPIHolderImpl.java b/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/OpenAPIHolderImpl.java
@@ -263,17 +263,15 @@ private void deepSubstituteForValidation(Object obj, JsonPointer scope,
   }
 
   private Future<JsonObject> resolveExternalRef(final URI ref) {
-    Promise<JsonObject> promise = Promise.promise();
-    Future<JsonObject> previous = externalSolvingRefs.putIfAbsent(ref, promise.future());
-    if (previous != null) {
-      return previous;
-    }
-    Future<JsonObject> solvedRef = URIUtils.isRemoteURI(ref) ? solveRemoteRef(ref) : solveLocalRef(ref);
-    solvedRef.compose(jsonObject -> {
-      absolutePaths.put(ref, jsonObject);
-      return walkAndSolve(jsonObject, ref).map(jsonObject);
-    }).onComplete(promise);
-    return promise.future();
+    return externalSolvingRefs.computeIfAbsent(ref,
+      uri ->
+        ((URIUtils.isRemoteURI(uri)) ? solveRemoteRef(uri) : solveLocalRef(uri))
+          .compose(j -> {
+            absolutePaths.put(uri, j); // Circular refs hell!
+            return walkAndSolve(j, uri).map(j);
+          })
+
+    );
   }
 
   private Future<JsonObject> solveRemoteRef(final URI ref) {
