OpenAPIHolderImpl.resolveExternalRef throws java.lang.IllegalStateException

tsegismont · tsegismont · commit 34d4481cf1a2 · 2026-01-28T14:28:33.000+01:00
See #2844 To prevent from a recursive update of the same key in the externalSolvingRefs, avoid computeIfAbsent and continue walking the references path only when an uncompleted future has effectively been put in the map. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
diff --git a/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/OpenAPIHolderImpl.java b/vertx-web-openapi/src/main/java/io/vertx/ext/web/openapi/impl/OpenAPIHolderImpl.java
@@ -263,15 +263,17 @@ private void deepSubstituteForValidation(Object obj, JsonPointer scope,
   }
 
   private Future<JsonObject> resolveExternalRef(final URI ref) {
-    return externalSolvingRefs.computeIfAbsent(ref,
-      uri ->
-        ((URIUtils.isRemoteURI(uri)) ? solveRemoteRef(uri) : solveLocalRef(uri))
-          .compose(j -> {
-            absolutePaths.put(uri, j); // Circular refs hell!
-            return walkAndSolve(j, uri).map(j);
-          })
-
-    );
+    Promise<JsonObject> promise = Promise.promise();
+    Future<JsonObject> previous = externalSolvingRefs.putIfAbsent(ref, promise.future());
+    if (previous != null) {
+      return previous;
+    }
+    Future<JsonObject> solvedRef = URIUtils.isRemoteURI(ref) ? solveRemoteRef(ref) : solveLocalRef(ref);
+    solvedRef.compose(jsonObject -> {
+      absolutePaths.put(ref, jsonObject);
+      return walkAndSolve(jsonObject, ref).map(jsonObject);
+    }).onComplete(promise);
+    return promise.future();
   }
 
   private Future<JsonObject> solveRemoteRef(final URI ref) {
