fix: changes empty mp parts error on CompleteMultipartUpload

niksis02 · niksis02 · commit ca6a92bb845c · 2025-09-18T16:09:02.000+04:00
Fixes #1328 If `CompleteMultipartUpload` is attempted with empty `Parts` list, the gateway used to return `InvalidRequest`. Now it's changed to `MalformedXML`.
diff --git a/s3api/controllers/object-post.go b/s3api/controllers/object-post.go
@@ -278,7 +278,7 @@ func (c S3ApiController) CompleteMultipartUpload(ctx *fiber.Ctx) (*Response, err
 			MetaOpts: &MetaOptions{
 				BucketOwner: parsedAcl.Owner,
 			},
-		}, s3err.GetAPIError(s3err.ErrEmptyParts)
+		}, s3err.GetAPIError(s3err.ErrMalformedXML)
 	}
 
 	var mpuObjectSize *int64
diff --git a/s3api/controllers/object-post_test.go b/s3api/controllers/object-post_test.go
@@ -404,7 +404,7 @@ func TestS3ApiController_CompleteMultipartUpload(t *testing.T) {
 						BucketOwner: "root",
 					},
 				},
-				err: s3err.GetAPIError(s3err.ErrEmptyParts),
+				err: s3err.GetAPIError(s3err.ErrMalformedXML),
 			},
 		},
 		{
diff --git a/s3err/s3err.go b/s3err/s3err.go
@@ -82,7 +82,6 @@ const (
 	ErrInvalidPartNumberMarker
 	ErrInvalidObjectAttributes
 	ErrInvalidPart
-	ErrEmptyParts
 	ErrInvalidPartNumber
 	ErrInvalidPartOrder
 	ErrInvalidCompleteMpPartNumber
@@ -311,11 +310,6 @@ var errorCodeResponse = map[ErrorCode]APIError{
 		Description:    "One or more of the specified parts could not be found.  The part may not have been uploaded, or the specified entity tag may not match the part's entity tag.",
 		HTTPStatusCode: http.StatusBadRequest,
 	},
-	ErrEmptyParts: {
-		Code:           "InvalidRequest",
-		Description:    "You must specify at least one part",
-		HTTPStatusCode: http.StatusBadRequest,
-	},
 	ErrInvalidPartNumber: {
 		Code:           "InvalidArgument",
 		Description:    "Part number must be an integer between 1 and 10000, inclusive.",
diff --git a/tests/integration/tests.go b/tests/integration/tests.go
@@ -13012,7 +13012,7 @@ func CompleteMultipartUpload_empty_parts(s *S3Conf) error {
 			},
 		})
 		cancel()
-		if err := checkApiErr(err, s3err.GetAPIError(s3err.ErrEmptyParts)); err != nil {
+		if err := checkApiErr(err, s3err.GetAPIError(s3err.ErrMalformedXML)); err != nil {
 			return err
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -278,7 +278,7 @@ func (c S3ApiController) CompleteMultipartUpload(ctx fiber.Ctx) (Response, err`
`278`	`278`	`MetaOpts: &MetaOptions{`
`279`	`279`	`BucketOwner: parsedAcl.Owner,`
`280`	`280`	`},`
`281`		`- }, s3err.GetAPIError(s3err.ErrEmptyParts)`
	`281`	`+ }, s3err.GetAPIError(s3err.ErrMalformedXML)`
`282`	`282`	`}`
`283`	`283`
`284`	`284`	`var mpuObjectSize *int64`
Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ func TestS3ApiController_CompleteMultipartUpload(t *testing.T) {`
`404`	`404`	`BucketOwner: "root",`
`405`	`405`	`},`
`406`	`406`	`},`
`407`		`- err: s3err.GetAPIError(s3err.ErrEmptyParts),`
	`407`	`+ err: s3err.GetAPIError(s3err.ErrMalformedXML),`
`408`	`408`	`},`
`409`	`409`	`},`
`410`	`410`	`{`
Original file line number	Diff line number	Diff line change
`@@ -13012,7 +13012,7 @@ func CompleteMultipartUpload_empty_parts(s *S3Conf) error {`
`13012`	`13012`	`},`
`13013`	`13013`	`})`
`13014`	`13014`	`cancel()`
`13015`		`- if err := checkApiErr(err, s3err.GetAPIError(s3err.ErrEmptyParts)); err != nil {`
	`13015`	`+ if err := checkApiErr(err, s3err.GetAPIError(s3err.ErrMalformedXML)); err != nil {`
`13016`	`13016`	`return err`
`13017`	`13017`	`}`
`13018`	`13018`