This repository was archived by the owner on Jul 28, 2024. It is now read-only.
Fix run-tests.ts: return non-zero exit code when tests fail
#1422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borekb
added
the
scope: dev-infrastructure
pavelevap
approved these changes
Apr 11, 2019
borekb
added
the
scope: tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue discovered in #1421. The
run-tests.tsscript now correctly forwards the exit code from the tests. Previously, the TypeScript script always returned0even if the tests failed – visually, the output was correct but Travis didn't see the build as failing.A quick way to test this is to run
npm run tests:unitwith some unit test artificially failing. Before 7bd2f40, the exit code (echo $?) is zero, after it, it's1.