This repository was archived by the owner on Jul 28, 2024. It is now read-only.
'Scripts' project with its own package.json, deps update
#1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also required a couple of small code fixes.
This moves most dependencies from root `package.json` to `scripts/package.json`. Also, on `npm install`, scripts's `npm install` is called automatically. Scripts are called a bit differently from the root `package.json` file, with `node -r ./scripts/node_modules/ts-node/register ...` instead of `ts-node` as `ts-node` is no longer a root-level dependency.
The `exitIfNotRunFromRootDir()` function has been removed and instead, all scripts have been updated to use paths relative to `repoRoot`.
Also, the root-level `debug-script` task has been removed as it's no longer necessary.
borekb
added
the
scope: dev-infrastructure
borekb
changed the title
package.json, deps update
borekb
added a commit
that referenced
this pull request
Mar 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1389
Part of #1401 will be a
run-tests.tsscript for which I needed a bit updatedscriptsdirectory, which is done in this PR as it's a relatively separate work.Main changes:
scriptsfolder is now a project with its ownpackage.json. This allows to clearly state which dependencies are for scripts and which are global in the rootpackage.json– not many are left there, see 4083e35.tsconfig.jsonmoved toscripts.cwd– they have been updated to contain paths relative to repo root explicitly. 273cd33