This repository was archived by the owner on Jul 28, 2024. It is now read-only.
Separate docker-compose files for dev and tests #1395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: - package.json test scripts now run `docker-compose -f docker-compose-tests.yml ...`. - Stopping dev env and testing env is now done via separate scripts, see `stop` vs. `tests:stop` and `stop-and-cleanup` vs. `tests:stop-and-cleanup`.
- Docker-compose examples now use the `-f` flag. - `stop` → `tests:stop`, `stop-and-cleanup` → `tests:stop-and-cleanup`.
borekb
added
the
scope: tests
borekb
added
the
scope: dev-infrastructure
13 tasks
borekb
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1389
To makes things cleaner, Docker Compose services have been split into two YAML files:
docker-compose.ymlfor development environmentdocker-compose-tests.ymlfor testsAll testing npm scripts now start with
docker-compose -f docker-compose-tests.yml ..., docs have been updated accordingly (preview).