Skip to content
This repository was archived by the owner on Jul 28, 2024. It is now read-only.

Conversation

@borekb
Copy link
Member

@borekb borekb commented Jun 29, 2018

Introduced in #1187, we forgot to document it.

I've also fixed the Markdown formatting in configuration.md.

@borekb borekb added the scope: docs Markdown documentation, public docs, READMEs label Jun 29, 2018
@borekb borekb added this to the 4.0 milestone Jun 29, 2018
@borekb borekb self-assigned this Jun 29, 2018
@borekb borekb requested a review from pavelevap June 29, 2018 07:02
Copy link
Collaborator

@pavelevap pavelevap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is existence of wp-config.common.php file (some constants are in this file, some are directly in wp-config.php). But this is out of scope this PR.
Sorry, my mistake, I did not realize, that for example VP_VPDB_DIR has to be unique for all environments because of Git versioning.

@borekb
Copy link
Member Author

borekb commented Jun 29, 2018

It's a good point that the info about wp-config.common.php should probably be extracted to its own docs page; it's a standalone concept that exists even if there were no VersionPress config constants.

I'll keep this PR about VP_WP_CLI_BINARY only though; let's revisit that in the future.

@borekb borekb merged commit 617e288 into master Jun 29, 2018
@borekb borekb deleted the docs-for-VP_WP_CLI_BINARY branch June 29, 2018 13:06
borekb added a commit to versionpress/docs.versionpress.net that referenced this pull request Jun 29, 2018
@borekb borekb changed the title Docs for VP_WP_CLI_BINARY config option Document VP_WP_CLI_BINARY setting Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

scope: docs Markdown documentation, public docs, READMEs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants