Repository navigation
Match ACP session modes to the CLI's permission modes - #1189
Merged
Merged
Conversation
- ACP sessions offer the CLI's permission modes, auto, ask, and full-access, named Auto, Ask, and Full access, in both the mode config option and the modes field. The code mode is removed. - A session starts in the saved permission_mode, or auto when none is saved, and reports the mode it enforces. Sessions previously reported ask while enforcing the saved mode. - Choosing a mode with session/set_config_option or session/set_mode saves it as the default permission mode, like /permissions, so new sessions and the CLI start in it. - A session reads the saved mode when it starts, so a long-running ACP process follows a mode another fx process saved. Open sessions keep their own mode. - In full-access, tool calls run without a permission request or an automatic review. - An unknown mode, including code, returns an "Unknown mode" error and changes nothing. session/set_mode without a modeId, and a mode change without an active session, also return errors. - Mode option values report their permission mode in _meta.fx.permissionMode instead of a top-level field outside ACP's schema. - libfx host config saves modes as auto, ask, and full-access, and ignores a saved code when restoring.
fazxes
marked this pull request as ready for review
October 7, 2026 19:33
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto,ask, andfull-access, named Auto, Ask, and Full access, in both themodeconfig option and themodesfield. Thecodemode is removed.permission_mode, orautowhen none is saved, and reports the mode it enforces. Sessions previously reportedaskwhile enforcing the saved mode.session/set_config_optionorsession/set_modesaves it as the default permission mode, like/permissions, so new sessions and the CLI start in it.full-access, tool calls run without a permission request or an automatic review.code, returns anUnknown modeerror and changes nothing.session/set_modewithout amodeId, and a mode change without an active session, also return errors._meta.fx.permissionModeinstead of a top-level field outside ACP's schema.auto,ask, andfull-access, and ignores a savedcodewhen restoring.