fix: fall back to x64 binary on Windows ARM64#1269
Conversation
|
@EternalRights is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey folks, just wanted to make sure this didn’t slip through. The Windows ARM64 fallback is a pretty small change — happy to add tests or adjust if needed. |
|
Thanks for the fix, @EternalRights! Can you please sign your commits before merging? |
Windows ARM64 does not have a native build in CI. Previously, the postinstall script tried to download �gent-browser-win32-arm64.exe which does not exist in GitHub releases, resulting in a 0kb install. Fall back to the x64 binary on Windows ARM64, which runs via the OS built-in x64 emulation. This matches the behavior of the existing ixWindowsShims() function and unifies the arch detection logic. Fixes vercel-labs#1256
795d55f to
e2f11d8
Compare
|
@ctate done, signed and force-pushed. let me know if anything else is needed. |
|
This is taking so long to apply... other fix is to just replace the arm exe with the x64 one locally... do it on a batch or something after each update |
@ctate looks like folks are writing workaround scripts for this. anything else needed to get this in? |
I only use agent-browser on windows through parallels on my mac for a legacy .net webapp... but it's endlessly irritating, the AB ships with a 0k arm exe so it's just a whack of token burn for the LLM to figure it out and load it properly, this script hacks it FOR SURE, but it works. Tate's a busy dude so I didn't want to press more than I already had |
@sitefinitysteve ha the batch script is pretty much what this PR does, copy x64 over the arm stub. two months and we’re still here lol |
250 issues and PRS though... like imagine if this was your repo and you ALSO HAD like 6 other popular ones, and we're all in the same boat of wanting OUR merge in. I have sympathy for the scenario lol. Thanks for getting this cranked in so fast initally btw |
|
@sitefinitysteve @EternalRights So sorry for the delay! Cutting a release now. Thank y'all so much! |
@ctate no worries, thanks for getting it in |
Summary
Fixes #1256
On Windows ARM64, the postinstall script previously tried to download
agent-browser-win32-arm64.exefrom GitHub releases. Since there's no native ARM64 build in CI, this resulted in a 0-byte file and a broken install.Changes
agent-browser-win32-x64.exe). x64 binaries run fine on ARM64 via Windows' built-in emulation.fixWindowsShims()to use the sameeffectiveArchvariable, eliminating the redundant local arch check.Testing
win-arm64platform (onlywin32andwin64).agent-browser-win32-x64.exeexists in all recent releases (v0.26.0, etc.).effectiveArchtox64agent-browser-win32-x64.exe.cmd/.ps1shims to point to the x64 binary