fix: handle Windows style path in generateWildcardRequire#153
fix: handle Windows style path in generateWildcardRequire#153styfle merged 2 commits intovercel:mainfrom yichi-yang:fix-windows-path
Conversation
styfle
left a comment
There was a problem hiding this comment.
Thanks! It would be great to add a test for this so we can ensure we don't regress (I'll have to enable windows CI in the future)
I added a unit test for #154. I tried on my Windows machine and it passes after the fix 48d3692 (but fails before the fix, reproducing the bug). Actually running the tests on my machine caught another bug related to path separators. Edit: I've figured this one out. JSON.stringify(curPattern) escapes the Let me know if you want the fix in this PR or a separate one. |
styfle
left a comment
There was a problem hiding this comment.
Thanks! Lets do a separate PR for the other fix since this one looks good 👍
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I added windows to CI in #155 but looks like there is more work to make it compatible |
Fixes #154