[remix] extract common handler logic into function#12973
Merged
erikareads merged 7 commits intomainfrom Jan 31, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: b6693b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
erikareads
requested review from
EndangeredMassa,
TooTallNate,
jeffsee55,
onsclom and
trek
as code owners
onsclom
approved these changes
Jan 30, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
trek
pushed a commit
that referenced
this pull request
Feb 4, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Major Changes - [cli] Remove support for node@16 ([#12857](#12857)) ### Patch Changes - Updated dependencies \[[`e6284c54132c4e0ec06e93331e79328a86a8b735`](e6284c5), [`322044b064a346cd4c25c12e725906ffbf445c0c`](322044b)]: - @vercel/[email protected] ## @vercel/[email protected] ### Major Changes - [cli] Remove support for node@16 ([#12857](#12857)) ## @vercel/functions@2.0.0 ### Major Changes - [cli] Remove support for node@16 ([#12857](#12857)) ## @vercel/[email protected] ### Patch Changes - [remix] extract common logic for getting files from trace ([#12983](#12983)) - [remix] extract common handler logic into `determineHandler` function ([#12973](#12973)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Major Changes - [cli] Remove support for node@16 ([#12857](vercel/vercel#12857)) ### Patch Changes - Updated dependencies \[[`f8349c68edfa01b34d4810a9de95135466027ed9`](vercel/vercel@f8349c6), [`e7891376c1155cb4214ce7bc03897fb54631ff9a`](vercel/vercel@e789137)]: - @vercel/[email protected] ## @vercel/[email protected] ### Major Changes - [cli] Remove support for node@16 ([#12857](vercel/vercel#12857)) ## @vercel/[email protected] ### Major Changes - [cli] Remove support for node@16 ([#12857](vercel/vercel#12857)) ## @vercel/[email protected] ### Patch Changes - [remix] extract common logic for getting files from trace ([#12983](vercel/vercel#12983)) - [remix] extract common handler logic into `determineHandler` function ([#12973](vercel/vercel#12973)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic around
handlerandhandlerPathwas consistent across all three ServerFunction creation functions, so this PR extracts that logic into a common function so that they stay in sync with each other.