[remix] remove check based on never set remixRunVercelPkgJson#12971
Merged
erikareads merged 4 commits intomainfrom Jan 31, 2025
Merged
[remix] remove check based on never set remixRunVercelPkgJson#12971erikareads merged 4 commits intomainfrom
erikareads merged 4 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 81e0b11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
erikareads
changed the title
erikareads
changed the title
erikareads
requested review from
EndangeredMassa,
TooTallNate,
jeffsee55,
onsclom and
trek
as code owners
TooTallNate
approved these changes
Jan 30, 2025
trek
approved these changes
Jan 30, 2025
onsclom
approved these changes
Jan 30, 2025
auto-merge was automatically disabled
January 31, 2025 00:34
Pull Request is not mergeable
Merged
trek
pushed a commit
that referenced
this pull request
Jan 31, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Major Changes - Make split-tgz the default for archive deployments ([#12943](#12943)) ### Patch Changes - Updated dependencies \[[`a9f2138035befec646d01c23203dba66790ea323`](a9f2138), [`e9acda308cefc4e12784d742968a6816e1f1072b`](e9acda3), [`bfbe07e2b5a87b07da464a6504566f29a76a9e8b`](bfbe07e), [`d07466a32f9026109f333fe653d1ff02a012756f`](d07466a), [`96c7a3ab6041efeb1eda9aab97d0a75c61e17bbe`](96c7a3a), [`b52b7e3a8cd775d56149683cb809b7ad9c77a514`](b52b7e3), [`9cfe0ec1439c6d3b038ab21f125cfe0223ad62c8`](9cfe0ec)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Major Changes - Ignore .yarn/cache by default on vercel CLI deploys ([#12977](#12977)) - Make split-tgz the default for archive deployments ([#12943](#12943)) ### Patch Changes - Updated dependencies \[[`b52b7e3a8cd775d56149683cb809b7ad9c77a514`](b52b7e3), [`3d310f508b9ff8f891838d8ba8ea24e428a06a9d`](3d310f5)]: - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - [cli] shift node 16 deprecation date to 2025-02-03 ([#12981](#12981)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`3d310f508b9ff8f891838d8ba8ea24e428a06a9d`](3d310f5)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`b52b7e3a8cd775d56149683cb809b7ad9c77a514`](b52b7e3), [`3d310f508b9ff8f891838d8ba8ea24e428a06a9d`](3d310f5)]: - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Add test case for locale false rewrite ([#12959](#12959)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`b52b7e3a8cd775d56149683cb809b7ad9c77a514`](b52b7e3)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`3d310f508b9ff8f891838d8ba8ea24e428a06a9d`](3d310f5)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - [remix] extract common function options ([#12960](#12960)) - [remix] extract sourceSearchValue into FrameworkSettings ([#12969](#12969)) - [remix] extract common edge file tracing logic ([#12953](#12953)) - [remix] remove check based on never set remixRunVercelPkgJson ([#12971](#12971)) - [remix] refactor framework slug into FrameworkSettings ([#12958](#12958)) ## @vercel/[email protected] ### Patch Changes - Update routes schema for new limit of 2048 ([#12968](#12968)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
After #12971 the logic for getting files from node file trace is common across the ServerFunction creation functions. This PR extracts that logic into a function.
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Major Changes - Make split-tgz the default for archive deployments ([#12943](vercel/vercel#12943)) ### Patch Changes - Updated dependencies \[[`b56cf550701363cf912af70f4d29144df4facfff`](vercel/vercel@b56cf55), [`3de9ea59496ec2efbbe6f6260462e56d138358eb`](vercel/vercel@3de9ea5), [`fecccfaa1353073a22f483534298ce5a92c954ef`](vercel/vercel@fecccfa), [`49aa15f615fdb0355dbc8dbe8385384cddb7b491`](vercel/vercel@49aa15f), [`37c778eba467e24883b9bb0251570b7f015d75c7`](vercel/vercel@37c778e), [`4da5ef09370f0fcf41967bfa2f74aaa43d9101c5`](vercel/vercel@4da5ef0), [`67bd78da1aca915e6f97ed7799f143f2f238d93e`](vercel/vercel@67bd78d)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Major Changes - Ignore .yarn/cache by default on vercel CLI deploys ([#12977](vercel/vercel#12977)) - Make split-tgz the default for archive deployments ([#12943](vercel/vercel#12943)) ### Patch Changes - Updated dependencies \[[`4da5ef09370f0fcf41967bfa2f74aaa43d9101c5`](vercel/vercel@4da5ef0), [`ab47f59a429ea11655efe1af72ed7dc75bc9633b`](vercel/vercel@ab47f59)]: - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - [cli] shift node 16 deprecation date to 2025-02-03 ([#12981](vercel/vercel#12981)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`ab47f59a429ea11655efe1af72ed7dc75bc9633b`](vercel/vercel@ab47f59)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`4da5ef09370f0fcf41967bfa2f74aaa43d9101c5`](vercel/vercel@4da5ef0), [`ab47f59a429ea11655efe1af72ed7dc75bc9633b`](vercel/vercel@ab47f59)]: - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Add test case for locale false rewrite ([#12959](vercel/vercel#12959)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`4da5ef09370f0fcf41967bfa2f74aaa43d9101c5`](vercel/vercel@4da5ef0)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`ab47f59a429ea11655efe1af72ed7dc75bc9633b`](vercel/vercel@ab47f59)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - [remix] extract common function options ([#12960](vercel/vercel#12960)) - [remix] extract sourceSearchValue into FrameworkSettings ([#12969](vercel/vercel#12969)) - [remix] extract common edge file tracing logic ([#12953](vercel/vercel#12953)) - [remix] remove check based on never set remixRunVercelPkgJson ([#12971](vercel/vercel#12971)) - [remix] refactor framework slug into FrameworkSettings ([#12958](vercel/vercel#12958)) ## @vercel/[email protected] ### Patch Changes - Update routes schema for new limit of 2048 ([#12968](vercel/vercel#12968)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remixRunVercelPkgJsonwas never set, meaning that the condition in https://github.com/vercel/vercel/pull/12971/files#diff-b96e3bcdb3ec62681992763d9af0f86e19b0c42ba892a0930cc42527a644e99bL650 would always fail. This PR removes the dead code path.