Revert "[frameworks] Add "react-router" framework entry (#12905)"#12927
Merged
TooTallNate merged 2 commits intomainfrom Jan 27, 2025
Merged
Revert "[frameworks] Add "react-router" framework entry (#12905)"#12927TooTallNate merged 2 commits intomainfrom
TooTallNate merged 2 commits intomainfrom
Conversation
This reverts commit fb0a542. The `useWebApi` support at the bridge layer is still in the process of being rolled out, so we need to wait until that is finished before we can add the framework preset.
TooTallNate
requested review from
EndangeredMassa,
agadzik,
chloetedder,
erikareads,
jeffsee55,
onsclom and
trek
as code owners
🦋 Changeset detectedLatest commit: 8995631 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
erikareads
approved these changes
Jan 27, 2025
onsclom
approved these changes
Jan 27, 2025
TooTallNate
added a commit
that referenced
this pull request
Jan 31, 2025
Adds a new framework entry for React Router (when being used as a framework). The same Remix builder will be used internally, but having a dedicated preset allows for auto-detection to work and will show the correct logo when being used in the Project Settings. (**Note:** this is a re-application of #12905, which was reverted in #12927)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fb0a542.
The
useWebApisupport at the bridge layer is still in the process of being rolled out, so we need to wait until that is finished before we can add the framework preset.