[node][remix][routing-utils] log diff between current and updated versions of `path-to-regexp` by EndangeredMassa · Pull Request #12926 · vercel/vercel

EndangeredMassa · 2025-01-27T21:14:27Z

Using pnpm aliases, this PR installs two different versions of path-to-regexp. Both are run and the resulting regex is compared. If they are different, an innocuous log message is sent to the build logs.

This allows us to test out the new version and be notified of any breaking changes it would have for our users.

Testing: This will be manually tested in the build container before release.

changeset-bot · 2025-01-27T21:14:32Z

🦋 Changeset detected

Latest commit: d22392b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@vercel/node	Patch
@vercel/remix-builder	Patch
@vercel/routing-utils	Patch
vercel	Patch
@vercel/client	Patch
@vercel/fs-detectors	Patch
@vercel/gatsby-plugin-vercel-builder	Patch
@vercel/redwood	Patch
@vercel/static-build	Patch
@vercel-internals/types	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

TooTallNate · 2025-01-27T21:19:24Z

packages/node/src/utils.ts

+      // each of these path-to-regexp comparisons logs an innocuous message
+      // so we (1) can easily grab it by querying the build logs
+      // and (2) it doesn't spook the user
+      console.log(`SYSTEM TEST #${callerId} A: ${path}`);


Prefix the log with [vc] and it'll be omitted from the user-facing logs entirely (but still be queryable on the backend).

Also, should we log the before and after regexps?

trek

No comments beyond Nate's damn good point.

packages/node/src/utils.ts

EndangeredMassa · 2025-01-29T16:16:32Z

That test failure is unrelated and being addressed outside of this PR. I'm going to merge.

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - Updated dependencies \[[`16b38a92574695f9961c7cc00cf631fe434c26c8`](16b38a9)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`16b38a92574695f9961c7cc00cf631fe434c26c8`](16b38a9)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`16b38a92574695f9961c7cc00cf631fe434c26c8`](16b38a9)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`16b38a92574695f9961c7cc00cf631fe434c26c8`](16b38a9)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - log diff between current and updated versions of path-to-regexp ([#12926](#12926)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`16b38a92574695f9961c7cc00cf631fe434c26c8`](16b38a9)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - log diff between current and updated versions of path-to-regexp ([#12926](#12926)) ## @vercel/[email protected] ### Patch Changes - log diff between current and updated versions of path-to-regexp ([#12926](#12926)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`16b38a92574695f9961c7cc00cf631fe434c26c8`](16b38a9)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Updated the `path-to-regexp` comparison: - centralized logic because it was getting coplicated - compared `keys` more carefully - use `keys` in updated `path-to-regexp` function as a clone of the original to avoid duplicate values --- Follow-up to: #12926 --------- Co-authored-by: Nathan Rajlich <[email protected]>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - Updated dependencies \[[`b13c164e8a62b37d8542a0af3e6c288a1b0c60c6`](vercel/vercel@b13c164)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`b13c164e8a62b37d8542a0af3e6c288a1b0c60c6`](vercel/vercel@b13c164)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`b13c164e8a62b37d8542a0af3e6c288a1b0c60c6`](vercel/vercel@b13c164)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`b13c164e8a62b37d8542a0af3e6c288a1b0c60c6`](vercel/vercel@b13c164)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - log diff between current and updated versions of path-to-regexp ([#12926](vercel/vercel#12926)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`b13c164e8a62b37d8542a0af3e6c288a1b0c60c6`](vercel/vercel@b13c164)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - log diff between current and updated versions of path-to-regexp ([#12926](vercel/vercel#12926)) ## @vercel/[email protected] ### Patch Changes - log diff between current and updated versions of path-to-regexp ([#12926](vercel/vercel#12926)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`b13c164e8a62b37d8542a0af3e6c288a1b0c60c6`](vercel/vercel@b13c164)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Updated the `path-to-regexp` comparison: - centralized logic because it was getting coplicated - compared `keys` more carefully - use `keys` in updated `path-to-regexp` function as a clone of the original to avoid duplicate values --- Follow-up to: vercel/vercel#12926 --------- Co-authored-by: Nathan Rajlich <[email protected]>

EndangeredMassa added 2 commits January 27, 2025 14:32

install second version of path-to-regexp

cb7d4ad

run both versions, log if different

7ef757c

EndangeredMassa changed the title ~~Smassa/log diff path to regexp~~ [node][remix][routing-utils] log diff between current and updated versions of path-to-regexp Jan 27, 2025

Create perfect-bulldogs-fry.md

a056ce0

EndangeredMassa marked this pull request as ready for review January 27, 2025 21:17

EndangeredMassa requested review from Kikobeats, TooTallNate, erikareads, ijjk, jeffsee55, onsclom and trek as code owners January 27, 2025 21:17

Merge branch 'main' into smassa/log-diff-path-to-regexp

e5c38c9

TooTallNate reviewed Jan 27, 2025

View reviewed changes

vercel bot deployed to Preview January 27, 2025 21:19 View deployment

erikareads previously approved these changes Jan 27, 2025

View reviewed changes

trek previously approved these changes Jan 27, 2025

View reviewed changes

erikareads reviewed Jan 27, 2025

View reviewed changes

packages/node/src/utils.ts Show resolved Hide resolved

EndangeredMassa requested review from TooTallNate, erikareads and trek January 27, 2025 21:29

updated message

07983b7

EndangeredMassa dismissed stale reviews from trek and erikareads via 07983b7 January 27, 2025 21:31

TooTallNate previously approved these changes Jan 27, 2025

View reviewed changes

vercel bot deployed to Preview January 27, 2025 21:32 View deployment

erikareads previously approved these changes Jan 27, 2025

View reviewed changes

compare keys as well

b6f8c75

EndangeredMassa dismissed erikareads’s stale review via b6f8c75 January 27, 2025 23:20

EndangeredMassa dismissed TooTallNate’s stale review via b6f8c75 January 27, 2025 23:20

vercel bot deployed to Preview January 27, 2025 23:21 View deployment

fix comparison

31530e5

vercel bot deployed to Preview January 28, 2025 00:20 View deployment

trek approved these changes Jan 28, 2025

View reviewed changes

Merge branch 'main' into smassa/log-diff-path-to-regexp

8dd8079

vercel bot deployed to Preview January 28, 2025 20:12 View deployment

EndangeredMassa enabled auto-merge January 28, 2025 20:16

Merge branch 'main' into smassa/log-diff-path-to-regexp

2936ec0

TooTallNate approved these changes Jan 28, 2025

View reviewed changes

vercel bot deployed to Preview January 28, 2025 20:52 View deployment

Merge branch 'main' into smassa/log-diff-path-to-regexp

d20d66a

vercel bot deployed to Preview January 28, 2025 22:18 View deployment

Merge branch 'main' into smassa/log-diff-path-to-regexp

91b3fc6

vercel bot deployed to Preview January 28, 2025 23:19 View deployment

Merge branch 'main' into smassa/log-diff-path-to-regexp

2063111

vercel bot deployed to Preview January 29, 2025 00:58 View deployment

Merge branch 'main' into smassa/log-diff-path-to-regexp

d22392b

vercel bot deployed to Preview January 29, 2025 15:43 View deployment

EndangeredMassa disabled auto-merge January 29, 2025 15:53

EndangeredMassa merged commit 16b38a9 into main Jan 29, 2025

EndangeredMassa deleted the smassa/log-diff-path-to-regexp branch January 29, 2025 16:16

vercel-release-bot mentioned this pull request Jan 29, 2025

Version Packages #12952

Merged

EndangeredMassa mentioned this pull request Jan 29, 2025

[node][remix][routing-utils] better path-to-regexp diff logging #12962

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[node][remix][routing-utils] log diff between current and updated versions of `path-to-regexp`#12926

[node][remix][routing-utils] log diff between current and updated versions of `path-to-regexp`#12926
EndangeredMassa merged 13 commits intomainfrom
smassa/log-diff-path-to-regexp

EndangeredMassa commented Jan 27, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Jan 27, 2025 •

edited

Loading

Uh oh!

TooTallNate Jan 27, 2025

Uh oh!

TooTallNate Jan 27, 2025

Uh oh!

trek left a comment

Uh oh!

Uh oh!

EndangeredMassa commented Jan 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

EndangeredMassa commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

TooTallNate Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

TooTallNate Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

trek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

EndangeredMassa commented Jan 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

EndangeredMassa commented Jan 27, 2025 •

edited

Loading

changeset-bot bot commented Jan 27, 2025 •

edited

Loading