[fs-detectors] Fix local file system detector to not throw for special file system stats by onsclom · Pull Request #12915 · vercel/vercel

onsclom · 2025-01-24T21:37:53Z

The problem:

▲  og-test/ vercel
Vercel CLI 39.2.5
? Set up and deploy "~/Developer/scratch/og-test"? yes
? Which scope should contain your project? leerob-site
? Link to existing project? no
? What's your project's name? og-test
? In which directory is your code located? ./
Error: Dirent was neither file nor directory: fsmonitor--daemon.ipc

This change stops readdir from throwing for a dirent like fsmonitor--daemon.ipc.

changeset-bot · 2025-01-24T21:37:58Z

🦋 Changeset detected

Latest commit: 975b5c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@vercel/fs-detectors	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/fs-detectors/src/detectors/local-file-system-detector.ts

TooTallNate · 2025-01-27T22:03:38Z

packages/fs-detectors/test/unit.local-file-system-detector.test.ts

        fs.writeFile(path.join(tmpdir, filePath), path.basename(filePath))
      )
    );
+    if (platform !== 'win32') {


Why is this skipped on Windows? Can you add a comment in the code explaining?

TooTallNate · 2025-01-27T22:05:11Z

packages/fs-detectors/test/unit.local-file-system-detector.test.ts

    expect(actualPaths).toEqual(expectedPaths);
  });

+  it('should skip entry if not file or directory', async () => {


Personally, I would make this test self-contained (do the before/after logic inline in this test), and perhaps use it.skipIf() if it doesn't apply for Windows.

Good ideas, thanks!

Jest doesn't support it.skipIf, so did that bit manually.

Oh I see, it's a vitest-ism.

…://github.com/vercel/vercel into austinmerrick/fix-framework-detection-readdir

TooTallNate

LGTM. I left a couple syntactic suggestions though.

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/[email protected] ### Major Changes - Initial release ([#12903](#12903)) ## @vercel/[email protected] ### Minor Changes - Add `useWebApi` property to `NodejsLambda` class ([#12873](#12873)) - [build-utils] convert NodeVersion to class and add state getter ([#12883](#12883)) [ruby] convert RubyVersion to class and add state getter ## [email protected] ### Minor Changes - [cli] add Node Version to project list output table ([#12895](#12895)) ### Patch Changes - Enable executable bit for `src/vc.js` script ([#12863](#12863)) - Add video integration category to the integration install CLI ([#12870](#12870)) - [cli] update warning in ls --update-required for clarity ([#12864](#12864)) - Added headers for user-supplied rewrites ([#12847](#12847)) - [cli] refactor confirm component to use `client.input.confirm` interface ([#12846](#12846)) - [build-utils] convert NodeVersion to class and add state getter ([#12883](#12883)) [ruby] convert RubyVersion to class and add state getter - Updated dependencies \[[`56f72ffefb828c3001f7c82259ed0f71db4f629e`](56f72ff), [`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`b6bb709370d2565121808340d43d0a9d90b53de1`](b6bb709), [`85a64db8d9b6a6e9f7c6a019d51777930a806584`](85a64db), [`ac6a62eff7db3b3e2713adc1f5bd6a1331d838ce`](ac6a62e), [`f65ea2245382dd2449c96f695ed692d419a83868`](f65ea22), [`7af40c1e9d9916cbe8287359662fc940f1d24fce`](7af40c1), [`06307180c20ca07b65f7cb5e93b65c977b9ccd70`](0630718), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f), [`cefda60a603d60cc35e4697c36e751cca411e6bb`](cefda60), [`003866c4c93e893edb7a5e89b519fc8879b370c0`](003866c)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - Make vite detection supersede ionic-react ([#12880](#12880)) ## @vercel/functions@1.6.0 ### Minor Changes - Add middleware-related helper functions ([#12938](#12938)) ## @vercel/[email protected] ### Minor Changes - Add support for React Router v7 ([#12904](#12904)) - Enable `nativeFetch` when `v3_singleFetch` future flag is enabled ([#12918](#12918)) ### Patch Changes - [remix] Create an interface for differences remix vs react-router ([#12925](#12925)) ## @vercel/[email protected] ### Minor Changes - [build-utils] convert NodeVersion to class and add state getter ([#12883](#12883)) [ruby] convert RubyVersion to class and add state getter ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Bump next from 14.2.10 to 14.2.21 ([#12842](#12842)) ## @vercel/[email protected] ### Patch Changes - Fix local file system readdir to not throw on special file system stat types ([#12915](#12915)) - Updated dependencies \[[`d645bdd4312730b10bef89ad9e18e111500849fc`](d645bdd)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - ensure defaultLocale rewrite doesn't conflict with user-defined redirects ([#12916](#12916)) - Added headers for user-supplied rewrites ([#12847](#12847)) ## @vercel/[email protected] ### Patch Changes - Fix requests failing due to the presence of `Transfer-Encoding` header in edge-function dev server. ([#10701](#10701)) - Split `build()`, `prepareCache()` and `startDevServer()` into separate files ([#12872](#12872)) - Updated dependencies \[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Remove support for VERCEL_IPC_FD ([#12908](#12908)) - Add `supportsResponseStreaming` to build output ([#12884](#12884)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/[email protected] ### Major Changes - Initial release ([#12903](vercel/vercel#12903)) ## @vercel/[email protected] ### Minor Changes - Add `useWebApi` property to `NodejsLambda` class ([#12873](vercel/vercel#12873)) - [build-utils] convert NodeVersion to class and add state getter ([#12883](vercel/vercel#12883)) [ruby] convert RubyVersion to class and add state getter ## [email protected] ### Minor Changes - [cli] add Node Version to project list output table ([#12895](vercel/vercel#12895)) ### Patch Changes - Enable executable bit for `src/vc.js` script ([#12863](vercel/vercel#12863)) - Add video integration category to the integration install CLI ([#12870](vercel/vercel#12870)) - [cli] update warning in ls --update-required for clarity ([#12864](vercel/vercel#12864)) - Added headers for user-supplied rewrites ([#12847](vercel/vercel#12847)) - [cli] refactor confirm component to use `client.input.confirm` interface ([#12846](vercel/vercel#12846)) - [build-utils] convert NodeVersion to class and add state getter ([#12883](vercel/vercel#12883)) [ruby] convert RubyVersion to class and add state getter - Updated dependencies \[[`97e4eb3c468b4c35c4b930137215ecd018707121`](vercel/vercel@97e4eb3), [`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`c8b8fdca6333c3d4503be696d046f57b2f221431`](vercel/vercel@c8b8fdc), [`e7536c62bebab05ea989cf10de28c9dc311be2e8`](vercel/vercel@e7536c6), [`33c6e67f14854ef680db612944063fc405843827`](vercel/vercel@33c6e67), [`0ded32e2d5ae1d9812d70eb281b226e057b016a9`](vercel/vercel@0ded32e), [`e1e6b58819ad8606ed4e963af5e1e58984cf02d7`](vercel/vercel@e1e6b58), [`44dd8ccf5235c7019c14d2a8e34c4c0733ce110d`](vercel/vercel@44dd8cc), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052), [`ff43e4bf3f15a8875afe6f3cc9e22a37110f3751`](vercel/vercel@ff43e4b), [`a376e638ffe384b962b14685293bccfb4507ab90`](vercel/vercel@a376e63)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - Make vite detection supersede ionic-react ([#12880](vercel/vercel#12880)) ## @vercel/[email protected] ### Minor Changes - Add middleware-related helper functions ([#12938](vercel/vercel#12938)) ## @vercel/[email protected] ### Minor Changes - Add support for React Router v7 ([#12904](vercel/vercel#12904)) - Enable `nativeFetch` when `v3_singleFetch` future flag is enabled ([#12918](vercel/vercel#12918)) ### Patch Changes - [remix] Create an interface for differences remix vs react-router ([#12925](vercel/vercel#12925)) ## @vercel/[email protected] ### Minor Changes - [build-utils] convert NodeVersion to class and add state getter ([#12883](vercel/vercel#12883)) [ruby] convert RubyVersion to class and add state getter ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Bump next from 14.2.10 to 14.2.21 ([#12842](vercel/vercel#12842)) ## @vercel/[email protected] ### Patch Changes - Fix local file system readdir to not throw on special file system stat types ([#12915](vercel/vercel#12915)) - Updated dependencies \[[`ac4318615e248752ad20ca031f7c903e76e52899`](vercel/vercel@ac43186)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - ensure defaultLocale rewrite doesn't conflict with user-defined redirects ([#12916](vercel/vercel#12916)) - Added headers for user-supplied rewrites ([#12847](vercel/vercel#12847)) ## @vercel/[email protected] ### Patch Changes - Fix requests failing due to the presence of `Transfer-Encoding` header in edge-function dev server. ([#10701](vercel/vercel#10701)) - Split `build()`, `prepareCache()` and `startDevServer()` into separate files ([#12872](vercel/vercel#12872)) - Updated dependencies \[[`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Remove support for VERCEL_IPC_FD ([#12908](vercel/vercel#12908)) - Add `supportsResponseStreaming` to build output ([#12884](vercel/vercel#12884)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

onsclom added 2 commits January 24, 2025 13:27

Do not throw for other dirent types

81957c0

Add changeset

f00837b

Merge branch 'main' into austinmerrick/fix-framework-detection-readdir

aaa628f

onsclom marked this pull request as ready for review January 24, 2025 21:54

onsclom requested review from EndangeredMassa, TooTallNate, agadzik, chloetedder, erikareads, jeffsee55 and trek as code owners January 24, 2025 21:54

vercel bot deployed to Preview January 24, 2025 21:54 View deployment

TooTallNate requested changes Jan 24, 2025

View reviewed changes

packages/fs-detectors/src/detectors/local-file-system-detector.ts Outdated Show resolved Hide resolved

onsclom added 2 commits January 27, 2025 12:49

Fix _readdir to ignore non file and directory entries

5bb246f

Update readdir test to include a socket

021a926

vercel bot deployed to Preview January 27, 2025 20:52 View deployment

Update it name

7c2a2c7

vercel bot deployed to Preview January 27, 2025 21:08 View deployment

onsclom marked this pull request as draft January 27, 2025 21:11

Separate socket into new test

b8303af

vercel bot deployed to Preview January 27, 2025 21:23 View deployment

Skip creating socket on windows

26f2f5c

vercel bot deployed to Preview January 27, 2025 21:36 View deployment

Merge branch 'main' into austinmerrick/fix-framework-detection-readdir

0e96ebd

onsclom marked this pull request as ready for review January 27, 2025 21:45

vercel bot deployed to Preview January 27, 2025 21:46 View deployment

onsclom requested a review from TooTallNate January 27, 2025 21:46

TooTallNate requested changes Jan 27, 2025

View reviewed changes

TooTallNate reviewed Jan 27, 2025

View reviewed changes

onsclom added 2 commits January 27, 2025 14:27

Improve test

1d04da9

Merge branch 'austinmerrick/fix-framework-detection-readdir' of https…

712de30

…://github.com/vercel/vercel into austinmerrick/fix-framework-detection-readdir

vercel bot deployed to Preview January 27, 2025 22:29 View deployment

onsclom requested a review from TooTallNate January 27, 2025 22:31

TooTallNate previously approved these changes Jan 27, 2025

View reviewed changes

Remove process import

b600b63

onsclom dismissed TooTallNate’s stale review via b600b63 January 27, 2025 22:40

Merge branch 'main' into austinmerrick/fix-framework-detection-readdir

1c64f3a

vercel bot deployed to Preview January 27, 2025 22:42 View deployment

TooTallNate approved these changes Jan 27, 2025

View reviewed changes

Merge branch 'main' into austinmerrick/fix-framework-detection-readdir

975b5c8

vercel bot deployed to Preview January 27, 2025 23:04 View deployment

onsclom added this pull request to the merge queue Jan 28, 2025

Merged via the queue into main with commit ea836e1 Jan 28, 2025

onsclom deleted the austinmerrick/fix-framework-detection-readdir branch January 28, 2025 01:04

vercel-release-bot mentioned this pull request Jan 28, 2025

Version Packages #12851

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fs-detectors] Fix local file system detector to not throw for special file system stats #12915

[fs-detectors] Fix local file system detector to not throw for special file system stats #12915
onsclom merged 14 commits intomainfrom
austinmerrick/fix-framework-detection-readdir

onsclom commented Jan 24, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Jan 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

TooTallNate Jan 27, 2025

Uh oh!

TooTallNate Jan 27, 2025

Uh oh!

onsclom Jan 27, 2025

Uh oh!

TooTallNate Jan 27, 2025

Uh oh!

TooTallNate left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

onsclom commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

TooTallNate Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

TooTallNate Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

onsclom Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

TooTallNate Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

TooTallNate left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

onsclom commented Jan 24, 2025 •

edited

Loading

changeset-bot bot commented Jan 24, 2025 •

edited

Loading