Skip to content

[examples] remove dojo#12881

Merged
trek merged 1 commit intomainfrom
trek/zero-3164-remove-example-dojo
Jan 17, 2025
Merged

[examples] remove dojo#12881
trek merged 1 commit intomainfrom
trek/zero-3164-remove-example-dojo

Conversation

@trek
Copy link
Copy Markdown
Contributor

@trek trek commented Jan 17, 2025 •
edited
Loading

Dojo hasn't had an update in a while and we'd need to update the example to work with node 18+. Removed from vercel/examples#1047 as well

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: 1420b87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trek trek marked this pull request as ready for review January 17, 2025 20:17
@trek trek enabled auto-merge January 17, 2025 20:23
@trek trek added this pull request to the merge queue Jan 17, 2025
@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 17, 2025

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@dojo/[email protected], npm/@dojo/[email protected], npm/@dojo/[email protected], npm/@dojo/[email protected], npm/@dojo/[email protected], npm/@dojo/[email protected], npm/@dojo/[email protected], npm/@theintern/[email protected], npm/@theintern/[email protected], npm/@theintern/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@webcomponents/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Merged via the queue into main with commit 3f75337 Jan 17, 2025
@trek trek deleted the trek/zero-3164-remove-example-dojo branch January 17, 2025 20:29
@trek trek mentioned this pull request Jan 21, 2025
Merged
trek added a commit that referenced this pull request Jan 21, 2025
@trek
[tests] remove tests verifying dojo and scully are tested (#12890)
3cc900a 
These were removed in
* #12881
* #12882

But our turbo config means this tests didn't run. It would eventually
fail mysteriously.
QuietCraftsmanship pushed a commit to QuietCraftsmanship/Vercel that referenced this pull request Jul 6, 2025
@trek
[tests] remove tests verifying dojo and scully are tested (#12890)
ec60e27 
These were removed in
* vercel/vercel#12881
* vercel/vercel#12882

But our turbo config means this tests didn't run. It would eventually
fail mysteriously.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TooTallNate TooTallNate Awaiting requested review from TooTallNate

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa

@jeffsee55 jeffsee55 Awaiting requested review from jeffsee55

@erikareads erikareads Awaiting requested review from erikareads

@leerob leerob Awaiting requested review from leerob

1 more reviewer

@onsclom onsclom onsclom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trek @onsclom