[frameworks][examples] Fix vite ionic-react framework detection by onsclom · Pull Request #12880 · vercel/vercel

onsclom · 2025-01-17T18:59:29Z

New ionic-react switched from using webpack to vite, but the ionic-react frameworks.ts detection still assumes it will use webpack.

This changes vite to supersede ionic-react so that vite ionic-react projects are detected as vite instead.

changeset-bot · 2025-01-17T18:59:34Z

🦋 Changeset detected

Latest commit: 9adf5f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@vercel/frameworks	Minor
@vercel/fs-detectors	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

onsclom · 2025-01-21T19:55:19Z

Follow up from #12879

EndangeredMassa · 2025-01-21T22:30:36Z

Updated from main to pull in these changes: #12890

EndangeredMassa · 2025-01-21T22:33:03Z

packages/frameworks/src/frameworks.ts

      'Vite is a new breed of frontend build tool that significantly improves the frontend development experience.',
    description: 'A Vue.js app, created with Vite.',
    website: 'https://vitejs.dev',
+    supersedes: ['ionic-react'],


suggestion (blocking): ‏Does this fail because the output dir is dist instead of build? Can we add a test that this behavior is correct?

Newly initiated ionic-react do not currently deploy with zero config, and this fixes them. These newly inited projects use vite and therefore DO use dist instead of build.

The currently existing e2e tests run the fresh inited ionic react project with vite settings and it succeeds https://github.com/vercel/vercel/actions/runs/12892527405/job/35948586479?pr=12880#step:8:128 (deployment). Is that test sufficient or were you thinking about a different kind of test?

Ah, thanks for that clarification.

That test was passing before this change. I was hoping to see a test that would only pass because of this change.

What are these more recent build failures on that project?

Whoops, my bad. Part of making this PR included switching that example to vite manually (since we don't rerun framework detection automatically), but that makes it fail for other PRs if we don't immediately merge this.

Switched it back to ionic react so other PRs will succeed now. Will add a test that shows supersedes prioritizes vite over ionic-react later.

Added that test now https://github.com/vercel/vercel/pull/12880/files#diff-b9b88879323adf73e47827b03f1d5593292326b4647e78b71f85951f2a3172f8!

…//github.com/vercel/vercel into austinmerrick/fix-vite-ionic-react-detection

onsclom · 2025-01-22T17:51:55Z

packages/frameworks/test/frameworks.unit.test.ts

+  const skipExamples = [
+    'sanity-v3',
+    'solidstart',
+    'dojo',
+    'scully',
+    'ionic-react',
+  ];


Temporarily adding ionic-react to skipped examples to avoid ionic-react failures.

After this gets merged I will manually set the ionic-react project to vite, then I'll make another PR to unskip the example.

onsclom · 2025-01-22T17:59:40Z

examples/__tests__/integration/ionic-react.test.ts

+// TODO: unskip once example is manually changed to `vite`
+it.skip('[examples] should deploy ionic-react', async () => {


Same as https://github.com/vercel/vercel/pull/12880/files#r1925735759

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/[email protected] ### Major Changes - Initial release ([#12903](#12903)) ## @vercel/[email protected] ### Minor Changes - Add `useWebApi` property to `NodejsLambda` class ([#12873](#12873)) - [build-utils] convert NodeVersion to class and add state getter ([#12883](#12883)) [ruby] convert RubyVersion to class and add state getter ## [email protected] ### Minor Changes - [cli] add Node Version to project list output table ([#12895](#12895)) ### Patch Changes - Enable executable bit for `src/vc.js` script ([#12863](#12863)) - Add video integration category to the integration install CLI ([#12870](#12870)) - [cli] update warning in ls --update-required for clarity ([#12864](#12864)) - Added headers for user-supplied rewrites ([#12847](#12847)) - [cli] refactor confirm component to use `client.input.confirm` interface ([#12846](#12846)) - [build-utils] convert NodeVersion to class and add state getter ([#12883](#12883)) [ruby] convert RubyVersion to class and add state getter - Updated dependencies \[[`56f72ffefb828c3001f7c82259ed0f71db4f629e`](56f72ff), [`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`b6bb709370d2565121808340d43d0a9d90b53de1`](b6bb709), [`85a64db8d9b6a6e9f7c6a019d51777930a806584`](85a64db), [`ac6a62eff7db3b3e2713adc1f5bd6a1331d838ce`](ac6a62e), [`f65ea2245382dd2449c96f695ed692d419a83868`](f65ea22), [`7af40c1e9d9916cbe8287359662fc940f1d24fce`](7af40c1), [`06307180c20ca07b65f7cb5e93b65c977b9ccd70`](0630718), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f), [`cefda60a603d60cc35e4697c36e751cca411e6bb`](cefda60), [`003866c4c93e893edb7a5e89b519fc8879b370c0`](003866c)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - Make vite detection supersede ionic-react ([#12880](#12880)) ## @vercel/functions@1.6.0 ### Minor Changes - Add middleware-related helper functions ([#12938](#12938)) ## @vercel/[email protected] ### Minor Changes - Add support for React Router v7 ([#12904](#12904)) - Enable `nativeFetch` when `v3_singleFetch` future flag is enabled ([#12918](#12918)) ### Patch Changes - [remix] Create an interface for differences remix vs react-router ([#12925](#12925)) ## @vercel/[email protected] ### Minor Changes - [build-utils] convert NodeVersion to class and add state getter ([#12883](#12883)) [ruby] convert RubyVersion to class and add state getter ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Bump next from 14.2.10 to 14.2.21 ([#12842](#12842)) ## @vercel/[email protected] ### Patch Changes - Fix local file system readdir to not throw on special file system stat types ([#12915](#12915)) - Updated dependencies \[[`d645bdd4312730b10bef89ad9e18e111500849fc`](d645bdd)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - ensure defaultLocale rewrite doesn't conflict with user-defined redirects ([#12916](#12916)) - Added headers for user-supplied rewrites ([#12847](#12847)) ## @vercel/[email protected] ### Patch Changes - Fix requests failing due to the presence of `Transfer-Encoding` header in edge-function dev server. ([#10701](#10701)) - Split `build()`, `prepareCache()` and `startDevServer()` into separate files ([#12872](#12872)) - Updated dependencies \[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Remove support for VERCEL_IPC_FD ([#12908](#12908)) - Add `supportsResponseStreaming` to build output ([#12884](#12884)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/[email protected] ### Major Changes - Initial release ([#12903](vercel/vercel#12903)) ## @vercel/[email protected] ### Minor Changes - Add `useWebApi` property to `NodejsLambda` class ([#12873](vercel/vercel#12873)) - [build-utils] convert NodeVersion to class and add state getter ([#12883](vercel/vercel#12883)) [ruby] convert RubyVersion to class and add state getter ## [email protected] ### Minor Changes - [cli] add Node Version to project list output table ([#12895](vercel/vercel#12895)) ### Patch Changes - Enable executable bit for `src/vc.js` script ([#12863](vercel/vercel#12863)) - Add video integration category to the integration install CLI ([#12870](vercel/vercel#12870)) - [cli] update warning in ls --update-required for clarity ([#12864](vercel/vercel#12864)) - Added headers for user-supplied rewrites ([#12847](vercel/vercel#12847)) - [cli] refactor confirm component to use `client.input.confirm` interface ([#12846](vercel/vercel#12846)) - [build-utils] convert NodeVersion to class and add state getter ([#12883](vercel/vercel#12883)) [ruby] convert RubyVersion to class and add state getter - Updated dependencies \[[`97e4eb3c468b4c35c4b930137215ecd018707121`](vercel/vercel@97e4eb3), [`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`c8b8fdca6333c3d4503be696d046f57b2f221431`](vercel/vercel@c8b8fdc), [`e7536c62bebab05ea989cf10de28c9dc311be2e8`](vercel/vercel@e7536c6), [`33c6e67f14854ef680db612944063fc405843827`](vercel/vercel@33c6e67), [`0ded32e2d5ae1d9812d70eb281b226e057b016a9`](vercel/vercel@0ded32e), [`e1e6b58819ad8606ed4e963af5e1e58984cf02d7`](vercel/vercel@e1e6b58), [`44dd8ccf5235c7019c14d2a8e34c4c0733ce110d`](vercel/vercel@44dd8cc), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052), [`ff43e4bf3f15a8875afe6f3cc9e22a37110f3751`](vercel/vercel@ff43e4b), [`a376e638ffe384b962b14685293bccfb4507ab90`](vercel/vercel@a376e63)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - Make vite detection supersede ionic-react ([#12880](vercel/vercel#12880)) ## @vercel/[email protected] ### Minor Changes - Add middleware-related helper functions ([#12938](vercel/vercel#12938)) ## @vercel/[email protected] ### Minor Changes - Add support for React Router v7 ([#12904](vercel/vercel#12904)) - Enable `nativeFetch` when `v3_singleFetch` future flag is enabled ([#12918](vercel/vercel#12918)) ### Patch Changes - [remix] Create an interface for differences remix vs react-router ([#12925](vercel/vercel#12925)) ## @vercel/[email protected] ### Minor Changes - [build-utils] convert NodeVersion to class and add state getter ([#12883](vercel/vercel#12883)) [ruby] convert RubyVersion to class and add state getter ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Bump next from 14.2.10 to 14.2.21 ([#12842](vercel/vercel#12842)) ## @vercel/[email protected] ### Patch Changes - Fix local file system readdir to not throw on special file system stat types ([#12915](vercel/vercel#12915)) - Updated dependencies \[[`ac4318615e248752ad20ca031f7c903e76e52899`](vercel/vercel@ac43186)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - ensure defaultLocale rewrite doesn't conflict with user-defined redirects ([#12916](vercel/vercel#12916)) - Added headers for user-supplied rewrites ([#12847](vercel/vercel#12847)) ## @vercel/[email protected] ### Patch Changes - Fix requests failing due to the presence of `Transfer-Encoding` header in edge-function dev server. ([#10701](vercel/vercel#10701)) - Split `build()`, `prepareCache()` and `startDevServer()` into separate files ([#12872](vercel/vercel#12872)) - Updated dependencies \[[`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Remove support for VERCEL_IPC_FD ([#12908](vercel/vercel#12908)) - Add `supportsResponseStreaming` to build output ([#12884](vercel/vercel#12884)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

vercel bot deployed to Preview January 17, 2025 18:59 View deployment

vercel bot deployed to Preview January 17, 2025 19:02 View deployment

onsclom force-pushed the austinmerrick/fix-vite-ionic-react-detection branch from 4d61339 to 5dce960 Compare January 17, 2025 20:36

vercel bot deployed to Preview January 17, 2025 20:37 View deployment

Fix vite ionic-react detection

c080fd9

onsclom force-pushed the austinmerrick/fix-vite-ionic-react-detection branch from 5dce960 to c080fd9 Compare January 21, 2025 17:07

vercel bot deployed to Preview January 21, 2025 17:08 View deployment

Skip deleted examples

5f759b3

vercel bot deployed to Preview January 21, 2025 17:29 View deployment

Add changeset

b9f7dd6

vercel bot deployed to Preview January 21, 2025 17:32 View deployment

onsclom marked this pull request as ready for review January 21, 2025 18:39

onsclom requested review from EndangeredMassa, TooTallNate, erikareads, jeffsee55, leerob and trek as code owners January 21, 2025 18:39

Merge branch 'main' into austinmerrick/fix-vite-ionic-react-detection

57e4845

vercel bot deployed to Preview January 21, 2025 22:31 View deployment

EndangeredMassa suggested changes Jan 21, 2025

View reviewed changes

onsclom added 3 commits January 22, 2025 09:43

Add test for supersede vite

27282c3

Temporarily skip ionic-react example

39559d6

Merge branch 'austinmerrick/fix-vite-ionic-react-detection' of https:…

92e3a3f

…//github.com/vercel/vercel into austinmerrick/fix-vite-ionic-react-detection

onsclom requested review from agadzik and chloetedder as code owners January 22, 2025 17:47

vercel bot deployed to Preview January 22, 2025 17:48 View deployment

onsclom commented Jan 22, 2025

View reviewed changes

Temporarily skip other ionic-react deploy test

9adf5f1

onsclom commented Jan 22, 2025

View reviewed changes

vercel bot deployed to Preview January 22, 2025 18:00 View deployment

EndangeredMassa approved these changes Jan 22, 2025

View reviewed changes

trek approved these changes Jan 22, 2025

View reviewed changes

onsclom enabled auto-merge January 22, 2025 19:59

onsclom added this pull request to the merge queue Jan 22, 2025

Merged via the queue into main with commit d645bdd Jan 22, 2025

onsclom deleted the austinmerrick/fix-vite-ionic-react-detection branch January 22, 2025 20:53

vercel-release-bot mentioned this pull request Jan 22, 2025

Version Packages #12851

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[frameworks][examples] Fix vite ionic-react framework detection#12880

[frameworks][examples] Fix vite ionic-react framework detection#12880
onsclom merged 8 commits intomainfrom
austinmerrick/fix-vite-ionic-react-detection

onsclom commented Jan 17, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Jan 17, 2025 •

edited

Loading

Uh oh!

onsclom commented Jan 21, 2025

Uh oh!

EndangeredMassa commented Jan 21, 2025

Uh oh!

EndangeredMassa Jan 21, 2025

Uh oh!

onsclom Jan 21, 2025

Uh oh!

EndangeredMassa Jan 22, 2025

Uh oh!

onsclom Jan 22, 2025

Uh oh!

onsclom Jan 22, 2025

Uh oh!

onsclom Jan 22, 2025

Uh oh!

onsclom Jan 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		// TODO: unskip once example is manually changed to `vite`
		it.skip('[examples] should deploy ionic-react', async () => {

Conversation

onsclom commented Jan 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jan 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

onsclom commented Jan 21, 2025

Uh oh!

EndangeredMassa commented Jan 21, 2025

Uh oh!

EndangeredMassa Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

onsclom Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

EndangeredMassa Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

onsclom Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

onsclom Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

onsclom Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

onsclom Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

onsclom commented Jan 17, 2025 •

edited

Loading

changeset-bot bot commented Jan 17, 2025 •

edited

Loading