Conversation
🦋 Changeset detectedLatest commit: 7ca7989 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| build: { | ||
| outDir: 'build' | ||
| } |
There was a problem hiding this comment.
Added this to match the existing outDir in frameworks.ts. Instead, the ionic-react frameworks.ts entry can be update to match vite defaults (like dist as output dir), but then we might break old webpack ionic-react projects.
There was a problem hiding this comment.
Does that mean that newly generated ionic-react projects will not be detected by frameworks.ts?
There was a problem hiding this comment.
We should update the framework.ts entries so that older ionic-react versions (that use the old outDir) can still work but new ones are detected properly. Maybe we add a second entry for newer ionic-react package versions. I could pair on it next week, if you like.
There was a problem hiding this comment.
Good idea! Will add detection for vite ionic-react projects in a new PR.
onsclom
requested review from
EndangeredMassa,
TooTallNate,
erikareads,
jeffsee55,
leerob and
trek
as code owners
`ionic-react` tests were temporarily skipped because of #12879. Now this test project has been manually set to `Vite`, so it can be unskipped.
`ionic-react` tests were temporarily skipped because of vercel/vercel#12879. Now this test project has been manually set to `Vite`, so it can be unskipped.
4 participants
Updating ionic-react to unpin from node 16.
Since this update changed the build tool from webpack -> vite, the default outdir changed. Changed it back to
buildin the vite config (see comments below).Deployment: https://ionic-react-q1fqkl6qt-austin-merricks-projects.vercel.app/