[cli] sort imports in build/index.ts#12833
Merged
erikareads merged 2 commits intomainfrom Jan 10, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: a80afdb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
erikareads
requested review from
EndangeredMassa,
TooTallNate,
jeffsee55,
onsclom and
trek
as code owners
TooTallNate
approved these changes
Jan 7, 2025
Member
TooTallNate
left a comment
TooTallNate
left a comment
There was a problem hiding this comment.
I'm down for this, but yes please let's automate it.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
onsclom
approved these changes
Jan 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
I'm mildly against sorting imports. I think that a thoughtful human sort is better than a deterministic/automatic sort. The problem is the non-automatic sort is often not thoughtful. So, I'm fine either way. |
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
Jan 13, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - [cli] add compile cache to improve startup performance ([#12783](#12783)) ### Patch Changes - [cli] standardizes uses of confirm on confirm.ts ([#12834](#12834)) - [cli] sort imports in build/index.ts ([#12833](#12833)) - Updated dependencies \[[`5fea2c49103adf6f7153f04378bff6f571375b0e`](5fea2c4)]: - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - Add support for in-function concurrency ([#12850](#12850)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - [cli] add compile cache to improve startup performance ([#12783](vercel/vercel#12783)) ### Patch Changes - [cli] standardizes uses of confirm on confirm.ts ([#12834](vercel/vercel#12834)) - [cli] sort imports in build/index.ts ([#12833](vercel/vercel#12833)) - Updated dependencies \[[`ac7961adcbbcf65b9cc6231b581e1f04a78bba2a`](vercel/vercel@ac7961a)]: - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - Add support for in-function concurrency ([#12850](vercel/vercel#12850)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaks the imports in
build/index.tsinto three sorted groups: external dependencies, monorepo dependencies, and other modules inpackage/cli.I did this PR as a standalone on one module so that we can discuss whether we:
package/clior the whole repo?This particular sort was done using a manual invocation of the Zed 'organize imports' code action.