[cli] centralize printError import location#12823
Merged
erikareads merged 2 commits intomainfrom Jan 3, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: c660e00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
erikareads
requested review from
EndangeredMassa,
TooTallNate,
jeffsee55,
onsclom and
trek
as code owners
trek
approved these changes
Jan 3, 2025
TooTallNate
reviewed
Jan 3, 2025
Member
TooTallNate
left a comment
TooTallNate
left a comment
There was a problem hiding this comment.
I'm not seeing it in the diff, but does this also remove the double export?
Merged
Contributor
Author
No, I like doing one easy-to-review thing in each PR. I've created #12824 to remove the double export by moving |
Schniz
pushed a commit
that referenced
this pull request
Jan 7, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - [cli] centralize printError import location ([#12823](#12823)) - [cli] remove double export of printError by moving printError to error.ts ([#12824](#12824)) - [cli] consolidate error constructors ([#12825](#12825)) - [cli] rename handleError to printError and remove default ([#12821](#12821)) ## @vercel/[email protected] ### Patch Changes - fix missing reference to `@vercel/functions` by bundling ([#12831](#12831)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
…r.ts (#12824) In vercel/vercel#12823 I centralized all imports of `printError` to come from `error.ts`. This PR moves `printError` to `error.ts` so that there is only one export of `printError`.
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - [cli] centralize printError import location ([#12823](vercel/vercel#12823)) - [cli] remove double export of printError by moving printError to error.ts ([#12824](vercel/vercel#12824)) - [cli] consolidate error constructors ([#12825](vercel/vercel#12825)) - [cli] rename handleError to printError and remove default ([#12821](vercel/vercel#12821)) ## @vercel/[email protected] ### Patch Changes - fix missing reference to `@vercel/functions` by bundling ([#12831](vercel/vercel#12831)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #12821, I found that we had two import paths for
printError, bothprint-error.tsanderror.tswere exporting the function. This PR unifies all imports to come fromerror.ts.