[cli] Fix `vc certs issue` subdomain parsing by onsclom · Pull Request #12532 · vercel/vercel

onsclom · 2024-11-06T23:44:49Z

I added a regression in fd86f5d#diff-4463dfbbb283602d090922c89d530aa8efb60baa260ffddcc33b275da6a3b00f where domains without a subdomain would incorrectly throw an error.

This fixes that and adds a test that catches this case.

changeset-bot · 2024-11-06T23:44:53Z

🦋 Changeset detected

Latest commit: b340b8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

jeffsee55 · 2024-11-07T00:02:05Z

packages/cli/src/commands/certs/issue.ts

    pendingChallenges.map(challenge => {
      const subdomain = getSubdomain(challenge.domain);
-      if (!subdomain) {
+      if (subdomain === null) {


What is the value here that led to the regression? false or undefined?

Subdomain would be an empty string, and !"" is true

getSubdomain returns null for invalid domains and and empty string if the domain has no subdomain.

packages/cli/test/unit/commands/certs/issue.test.ts

…omain-error-in-vercel-cli-for

…te-invalid-domain-error-in-vercel-cli-for' into austinmerrick/dmns-475-investigate-invalid-domain-error-in-vercel-cli-for

packages/cli/test/unit/commands/certs/issue.test.ts

Co-authored-by: Nathan Rajlich <[email protected]>

…omain-error-in-vercel-cli-for

Co-authored-by: Nathan Rajlich <[email protected]>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Major Changes - Migrate `vercel certs` subcommands to their own command specifications ([#12463](#12463)) - Migrate `vercel dns` subcommands to their own command specifications ([#12464](#12464)) - Migrate `vercel alias` subcommands to their own command specifications ([#12458](#12458)) - Migrate `vercel projects` subcommands to their own command specifications ([#12518](#12518)) - Migrate `vercel env` subcommands to their own command specifications ([#12476](#12476)) - Migrate `vercel domains` subcommands to their own command specifications ([#12526](#12526)) - Migrate `vercel git` subcommands to their own command specifications ([#12524](#12524)) - Migrate `vercel teams` subcommands to their own command specifications ([#12496](#12496)) ### Minor Changes - Migrate `vercel promote` subcommands to their own command specifications ([#12480](#12480)) - [cli] add telemetry for `vercel teams switch` ([#12493](#12493)) - Support `multiple: true` for variadic arguments in Command spec ([#12515](#12515)) - Migrate `vercel rollback` subcommands to their own command specifications ([#12519](#12519)) - [cli] add telemetry for --help flag ([#12430](#12430)) - Adds "--target" as a new option for the "redeploy" command. ([#12523](#12523)) - Add strongly typed `subcommands` for Telemetry methods based on command specification ([#12446](#12446)) - Migrate `vercel telemetry` subcommands to their own command specifications ([#12460](#12460)) - Migrate `vercel target` subcommands to their own command specifications ([#12477](#12477)) - [cli] standardize `vercel teams` subcommand routing ([#12473](#12473)) ### Patch Changes - Don't print empty "Options" section in `--help` output (after filtering) ([#12479](#12479)) - [cli] integration resource was always redacted simplify method ([#12547](#12547)) - [cli] minor fixes in vercel target ([#12510](#12510)) - Show `vercel telemetry` subcommand help output ([#12487](#12487)) - [cli] tidy up command config structure `vercel alias` ([#12438](#12438)) - [cli] Use `getAliases` helper in `vercel certs` ([#12489](#12489)) - [cli] separately track integration-resource command ([#12543](#12543)) - [cli] use getAliases helper in vercel env ([#12491](#12491)) - Don't print empty "Examples" section in `--help` output ([#12475](#12475)) - [cli] create standard method for redacted targets ([#12544](#12544)) - [cli] redacting regions until we determine method to get list ([#12553](#12553)) - [cli] use getAliases helper in vercel integration-resource ([#12505](#12505)) - [cli] redact dns records outside allowed types ([#12548](#12548)) - [cli] remove trackCommandError method - unused ([#12546](#12546)) - [cli] derive `vercel alias` subcommand config from subcommand structs ([#12474](#12474)) - [cli] use getAliases in vercel telemetry ([#12509](#12509)) - [cli] use getAliases helper in vercel integration ([#12504](#12504)) - [cli] fix minor issues vercel pull ([#12512](#12512)) - [cli] use getAliases in vercel target ([#12508](#12508)) - Stabilize Chained Prerenders ([#12507](#12507)) - [cli] use subcommandOriginal in telemetry ([#12549](#12549)) - [cli] fix minor issues vercel project ([#12528](#12528)) - Add telemetry to teams list options ([#12440](#12440)) - Misc adjustments for `vercel bisect --help` ([#12478](#12478)) - [cli] redact Extensions ([#12542](#12542)) - fix small issues in telemetry and whoami ([#12468](#12468)) - Make `command` be an implied argument when `subcommands` array is defined ([#12456](#12456)) - [cli] derive Map of aliases from Command structs ([#12472](#12472)) - [cli] Add aliases field to Command ([#12462](#12462)) - Include "integration" command name in synopsis line in `vercel integration <subcommand> --help` output ([#12470](#12470)) - Consistent help output for `--next` option ([#12481](#12481)) - Fix `vercel integration-resource` subcommand help ([#12531](#12531)) - Consistent help output for `--limit` option ([#12482](#12482)) - [cli] rename getAliases helper to nonconflicting name ([#12516](#12516)) - [cli] redact unknown archive formats ([#12550](#12550)) - [cli] use getAliases helper in vercel dns ([#12490](#12490)) - [cli] move scope fetching closer to where its used in `vc bisect` ([#12439](#12439)) - [cli] redact output mode in telemetry method ([#12545](#12545)) - [cli] use subcommandOriginal for help telemetry ([#12552](#12552)) - [cli] fix minor issues vercel alias ([#12539](#12539)) - Fix certs issue to allow domain without subdomain ([#12532](#12532)) - Updated dependencies \[[`03f02e4ae9d3e9c198584acba4231e763d9eb353`](03f02e4), [`736f322093ebbb31d576609467d80d89ba9dc250`](736f322), [`80c8ec3634170c1566a5ce62acf560a9d1926d60`](80c8ec3)]: - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - Add support for HTTP streaming ([#12557](#12557)) ## @vercel/[email protected] ### Patch Changes - Fix basePath root matching for error pages ([#12559](#12559)) - Stabilize Chained Prerenders ([#12507](#12507)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Major Changes - Migrate `vercel certs` subcommands to their own command specifications ([#12463](vercel/vercel#12463)) - Migrate `vercel dns` subcommands to their own command specifications ([#12464](vercel/vercel#12464)) - Migrate `vercel alias` subcommands to their own command specifications ([#12458](vercel/vercel#12458)) - Migrate `vercel projects` subcommands to their own command specifications ([#12518](vercel/vercel#12518)) - Migrate `vercel env` subcommands to their own command specifications ([#12476](vercel/vercel#12476)) - Migrate `vercel domains` subcommands to their own command specifications ([#12526](vercel/vercel#12526)) - Migrate `vercel git` subcommands to their own command specifications ([#12524](vercel/vercel#12524)) - Migrate `vercel teams` subcommands to their own command specifications ([#12496](vercel/vercel#12496)) ### Minor Changes - Migrate `vercel promote` subcommands to their own command specifications ([#12480](vercel/vercel#12480)) - [cli] add telemetry for `vercel teams switch` ([#12493](vercel/vercel#12493)) - Support `multiple: true` for variadic arguments in Command spec ([#12515](vercel/vercel#12515)) - Migrate `vercel rollback` subcommands to their own command specifications ([#12519](vercel/vercel#12519)) - [cli] add telemetry for --help flag ([#12430](vercel/vercel#12430)) - Adds "--target" as a new option for the "redeploy" command. ([#12523](vercel/vercel#12523)) - Add strongly typed `subcommands` for Telemetry methods based on command specification ([#12446](vercel/vercel#12446)) - Migrate `vercel telemetry` subcommands to their own command specifications ([#12460](vercel/vercel#12460)) - Migrate `vercel target` subcommands to their own command specifications ([#12477](vercel/vercel#12477)) - [cli] standardize `vercel teams` subcommand routing ([#12473](vercel/vercel#12473)) ### Patch Changes - Don't print empty "Options" section in `--help` output (after filtering) ([#12479](vercel/vercel#12479)) - [cli] integration resource was always redacted simplify method ([#12547](vercel/vercel#12547)) - [cli] minor fixes in vercel target ([#12510](vercel/vercel#12510)) - Show `vercel telemetry` subcommand help output ([#12487](vercel/vercel#12487)) - [cli] tidy up command config structure `vercel alias` ([#12438](vercel/vercel#12438)) - [cli] Use `getAliases` helper in `vercel certs` ([#12489](vercel/vercel#12489)) - [cli] separately track integration-resource command ([#12543](vercel/vercel#12543)) - [cli] use getAliases helper in vercel env ([#12491](vercel/vercel#12491)) - Don't print empty "Examples" section in `--help` output ([#12475](vercel/vercel#12475)) - [cli] create standard method for redacted targets ([#12544](vercel/vercel#12544)) - [cli] redacting regions until we determine method to get list ([#12553](vercel/vercel#12553)) - [cli] use getAliases helper in vercel integration-resource ([#12505](vercel/vercel#12505)) - [cli] redact dns records outside allowed types ([#12548](vercel/vercel#12548)) - [cli] remove trackCommandError method - unused ([#12546](vercel/vercel#12546)) - [cli] derive `vercel alias` subcommand config from subcommand structs ([#12474](vercel/vercel#12474)) - [cli] use getAliases in vercel telemetry ([#12509](vercel/vercel#12509)) - [cli] use getAliases helper in vercel integration ([#12504](vercel/vercel#12504)) - [cli] fix minor issues vercel pull ([#12512](vercel/vercel#12512)) - [cli] use getAliases in vercel target ([#12508](vercel/vercel#12508)) - Stabilize Chained Prerenders ([#12507](vercel/vercel#12507)) - [cli] use subcommandOriginal in telemetry ([#12549](vercel/vercel#12549)) - [cli] fix minor issues vercel project ([#12528](vercel/vercel#12528)) - Add telemetry to teams list options ([#12440](vercel/vercel#12440)) - Misc adjustments for `vercel bisect --help` ([#12478](vercel/vercel#12478)) - [cli] redact Extensions ([#12542](vercel/vercel#12542)) - fix small issues in telemetry and whoami ([#12468](vercel/vercel#12468)) - Make `command` be an implied argument when `subcommands` array is defined ([#12456](vercel/vercel#12456)) - [cli] derive Map of aliases from Command structs ([#12472](vercel/vercel#12472)) - [cli] Add aliases field to Command ([#12462](vercel/vercel#12462)) - Include "integration" command name in synopsis line in `vercel integration <subcommand> --help` output ([#12470](vercel/vercel#12470)) - Consistent help output for `--next` option ([#12481](vercel/vercel#12481)) - Fix `vercel integration-resource` subcommand help ([#12531](vercel/vercel#12531)) - Consistent help output for `--limit` option ([#12482](vercel/vercel#12482)) - [cli] rename getAliases helper to nonconflicting name ([#12516](vercel/vercel#12516)) - [cli] redact unknown archive formats ([#12550](vercel/vercel#12550)) - [cli] use getAliases helper in vercel dns ([#12490](vercel/vercel#12490)) - [cli] move scope fetching closer to where its used in `vc bisect` ([#12439](vercel/vercel#12439)) - [cli] redact output mode in telemetry method ([#12545](vercel/vercel#12545)) - [cli] use subcommandOriginal for help telemetry ([#12552](vercel/vercel#12552)) - [cli] fix minor issues vercel alias ([#12539](vercel/vercel#12539)) - Fix certs issue to allow domain without subdomain ([#12532](vercel/vercel#12532)) - Updated dependencies \[[`f581d69becc9d431ba65b952fbaa888809f03e97`](vercel/vercel@f581d69), [`32b19e6b90cb14a9911557f075dddd27725291bf`](vercel/vercel@32b19e6), [`6b100c84cb8d02b31f9aee98e3ac689963c24ff6`](vercel/vercel@6b100c8)]: - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - Add support for HTTP streaming ([#12557](vercel/vercel#12557)) ## @vercel/[email protected] ### Patch Changes - Fix basePath root matching for error pages ([#12559](vercel/vercel#12559)) - Stabilize Chained Prerenders ([#12507](vercel/vercel#12507)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

onsclom added 3 commits November 6, 2024 14:57

Fix vc certs issue regression

e77d900

Add changeset

1db53f5

Add tests

cd5e335

Fix test name

dbe700b

vercel bot deployed to Preview November 6, 2024 23:46 View deployment

onsclom marked this pull request as ready for review November 6, 2024 23:59

onsclom requested review from EndangeredMassa, TooTallNate, erikareads, jeffsee55 and trek as code owners November 6, 2024 23:59

jeffsee55 reviewed Nov 7, 2024

View reviewed changes

jeffsee55 previously approved these changes Nov 7, 2024

View reviewed changes

onsclom added the pr: automerge label Nov 7, 2024

TooTallNate requested changes Nov 7, 2024

View reviewed changes

packages/cli/test/unit/commands/certs/issue.test.ts Outdated Show resolved Hide resolved

Remove "/now" from cert api urls

6fd62a3

onsclom dismissed jeffsee55’s stale review via 6fd62a3 November 7, 2024 17:40

Merge branch 'main' into austinmerrick/dmns-475-investigate-invalid-d…

1477504

…omain-error-in-vercel-cli-for

vercel bot deployed to Preview November 7, 2024 17:42 View deployment

onsclom requested a review from TooTallNate November 7, 2024 17:49

onsclom added 2 commits November 7, 2024 09:51

Remove /now in mocks

3318031

Merge remote-tracking branch 'origin/austinmerrick/dmns-475-investiga…

7e166b5

…te-invalid-domain-error-in-vercel-cli-for' into austinmerrick/dmns-475-investigate-invalid-domain-error-in-vercel-cli-for

vercel bot deployed to Preview November 7, 2024 17:52 View deployment

TooTallNate requested changes Nov 7, 2024

View reviewed changes

packages/cli/test/unit/commands/certs/issue.test.ts Outdated Show resolved Hide resolved

packages/cli/test/unit/commands/certs/issue.test.ts Outdated Show resolved Hide resolved

Update packages/cli/test/unit/commands/certs/issue.test.ts

8a23082

Co-authored-by: Nathan Rajlich <[email protected]>

vercel bot deployed to Preview November 7, 2024 18:46 View deployment

Merge branch 'main' into austinmerrick/dmns-475-investigate-invalid-d…

e583e74

…omain-error-in-vercel-cli-for

vercel bot deployed to Preview November 7, 2024 20:43 View deployment

Update packages/cli/test/unit/commands/certs/issue.test.ts

b340b8a

Co-authored-by: Nathan Rajlich <[email protected]>

vercel bot deployed to Preview November 7, 2024 21:20 View deployment

onsclom enabled auto-merge November 7, 2024 23:26

onsclom requested a review from TooTallNate November 7, 2024 23:27

TooTallNate approved these changes Nov 7, 2024

View reviewed changes

onsclom added this pull request to the merge queue Nov 7, 2024

Merged via the queue into main with commit 0a0587c Nov 8, 2024

onsclom deleted the austinmerrick/dmns-475-investigate-invalid-domain-error-in-vercel-cli-for branch November 8, 2024 01:19

vercel-release-bot mentioned this pull request Nov 8, 2024

Version Packages #12442

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cli] Fix `vc certs issue` subdomain parsing#12532

[cli] Fix `vc certs issue` subdomain parsing#12532
onsclom merged 11 commits intomainfrom
austinmerrick/dmns-475-investigate-invalid-domain-error-in-vercel-cli-for

onsclom commented Nov 6, 2024

Uh oh!

changeset-bot bot commented Nov 6, 2024 •

edited

Loading

Uh oh!

jeffsee55 Nov 7, 2024

Uh oh!

onsclom Nov 7, 2024

Uh oh!

onsclom Nov 7, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

onsclom commented Nov 6, 2024

Uh oh!

changeset-bot bot commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

jeffsee55 Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

onsclom Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

onsclom Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Nov 6, 2024 •

edited

Loading