[cli] Make all metrics tracking methods on the store require arguments by trek · Pull Request #12422 · vercel/vercel

trek · 2024-10-29T18:49:30Z

For a given telemetry method, like:

trackCliArgumentDomain(domain?: string) {
  if (domain) {
    this.trackCliArgument({
      arg: 'domain',
      value: this.redactedValue,
    });
  }
}

The argument type domain?: string means that it can be invoked without an argument at all:

eventStore.trackCliArgumentDomain();

We never want this to happen, though. The value should always be passed to determine if we're tracking that argument/flag/option.

changeset-bot · 2024-10-29T18:49:34Z

🦋 Changeset detected

Latest commit: 88936fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…-store-require' of github.com:vercel/vercel into trek/zero-2810-make-all-metrics-tracking-methods-on-the-store-require

…hods-on-the-store-require

trek · 2024-10-29T19:43:34Z

packages/cli/src/util/telemetry/commands/dev/index.ts

+  trackCliFlagHelp(help: boolean | undefined) {
    if (help) {
-      this.trackCliFlagHelp();
+      this.trackCliFlag('help');


This audit did actually catch one bug!

question (non-blocking): ‏Can we have a test that asserts this? Or is it too hard to do with vc dev for now?

I think this was actually me overachieving sine we planned to do --help as its own work. But, yeah, this is annoying to test. I could just remove it?

EndangeredMassa · 2024-10-29T19:55:56Z

packages/cli/src/util/telemetry/commands/dev/index.ts

+  trackCliFlagHelp(help: boolean | undefined) {
    if (help) {
-      this.trackCliFlagHelp();
+      this.trackCliFlag('help');


question (non-blocking): ‏Can we have a test that asserts this? Or is it too hard to do with vc dev for now?

…hods-on-the-store-require

kodiakhq · 2024-10-29T21:53:13Z

This PR currently has a merge conflict. Please resolve this and then re-add the ['pr: automerge'] label.

…hods-on-the-store-require

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - Strongly type `TelemetryClient` subclasses against command specification ([#12426](#12426)) - Adds `vercel integration remove` to uninstall Marketplace integrations from the current team ([#12291](#12291)) Adds `vercel integration-resource disconnect` to disconnect Marketplace integration resources from projects Adds `vercel integration-resource remove` to delete Marketplace integration resources ### Patch Changes - [cli] Make all metrics tracking methods on the store require arguments ([#12422](#12422)) - Support allowHeader from Next.js for filtering request headers during revalidation ([#12420](#12420)) - [cli] don't track unreachable condition ([#12419](#12419)) - Updated dependencies \[[`5a6605bbd99c3b4c3f06fc315dd3978fe7801d00`](5a6605b)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/functions@1.5.0 ### Minor Changes - ipAddress: accept headers as input ([#12429](#12429)) ## @vercel/[email protected] ### Patch Changes - Support allowHeader from Next.js for filtering request headers during revalidation ([#12420](#12420)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`5a6605bbd99c3b4c3f06fc315dd3978fe7801d00`](5a6605b)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`5a6605bbd99c3b4c3f06fc315dd3978fe7801d00`](5a6605b)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Support allowHeader from Next.js for filtering request headers during revalidation ([#12420](#12420)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`5a6605bbd99c3b4c3f06fc315dd3978fe7801d00`](5a6605b)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`5a6605bbd99c3b4c3f06fc315dd3978fe7801d00`](5a6605b)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - Strongly type `TelemetryClient` subclasses against command specification ([#12426](vercel/vercel#12426)) - Adds `vercel integration remove` to uninstall Marketplace integrations from the current team ([#12291](vercel/vercel#12291)) Adds `vercel integration-resource disconnect` to disconnect Marketplace integration resources from projects Adds `vercel integration-resource remove` to delete Marketplace integration resources ### Patch Changes - [cli] Make all metrics tracking methods on the store require arguments ([#12422](vercel/vercel#12422)) - Support allowHeader from Next.js for filtering request headers during revalidation ([#12420](vercel/vercel#12420)) - [cli] don't track unreachable condition ([#12419](vercel/vercel#12419)) - Updated dependencies \[[`ea72a9f85d9fba806e382ef1a7e52b73f78132d9`](vercel/vercel@ea72a9f)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - ipAddress: accept headers as input ([#12429](vercel/vercel#12429)) ## @vercel/[email protected] ### Patch Changes - Support allowHeader from Next.js for filtering request headers during revalidation ([#12420](vercel/vercel#12420)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`ea72a9f85d9fba806e382ef1a7e52b73f78132d9`](vercel/vercel@ea72a9f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`ea72a9f85d9fba806e382ef1a7e52b73f78132d9`](vercel/vercel@ea72a9f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Support allowHeader from Next.js for filtering request headers during revalidation ([#12420](vercel/vercel#12420)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`ea72a9f85d9fba806e382ef1a7e52b73f78132d9`](vercel/vercel@ea72a9f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`ea72a9f85d9fba806e382ef1a7e52b73f78132d9`](vercel/vercel@ea72a9f)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

[cli] Make all metrics tracking methods on the store require arguments

efad1f7

vercel bot deployed to Preview October 29, 2024 18:50 View deployment

Create fair-ravens-burn.md

9b007ff

vercel bot deployed to Preview October 29, 2024 18:51 View deployment

trek added 2 commits October 29, 2024 13:58

fix flag call

123209e

Merge branch 'trek/zero-2810-make-all-metrics-tracking-methods-on-the…

6e60472

…-store-require' of github.com:vercel/vercel into trek/zero-2810-make-all-metrics-tracking-methods-on-the-store-require

vercel bot deployed to Preview October 29, 2024 18:59 View deployment

Merge branch 'main' into trek/zero-2810-make-all-metrics-tracking-met…

f363e60

…hods-on-the-store-require

vercel bot deployed to Preview October 29, 2024 19:20 View deployment

Merge branch 'main' into trek/zero-2810-make-all-metrics-tracking-met…

59687c8

…hods-on-the-store-require

vercel bot deployed to Preview October 29, 2024 19:39 View deployment

trek marked this pull request as ready for review October 29, 2024 19:41

trek requested review from EndangeredMassa, TooTallNate, erikareads, jeffsee55 and onsclom as code owners October 29, 2024 19:41

TooTallNate previously approved these changes Oct 29, 2024

View reviewed changes

trek commented Oct 29, 2024

View reviewed changes

erikareads previously approved these changes Oct 29, 2024

View reviewed changes

EndangeredMassa previously approved these changes Oct 29, 2024

View reviewed changes

TooTallNate added the pr: automerge label Oct 29, 2024

Merge branch 'main' into trek/zero-2810-make-all-metrics-tracking-met…

58ddc19

…hods-on-the-store-require

vercel bot deployed to Preview October 29, 2024 21:47 View deployment

kodiakhq bot removed the pr: automerge label Oct 29, 2024

Merge branch 'main' into trek/zero-2810-make-all-metrics-tracking-met…

88936fc

…hods-on-the-store-require

TooTallNate dismissed stale reviews from erikareads and themself via 88936fc October 29, 2024 22:02

TooTallNate dismissed EndangeredMassa’s stale review via 88936fc October 29, 2024 22:02

TooTallNate added the pr: automerge label Oct 29, 2024

vercel bot deployed to Preview October 29, 2024 22:03 View deployment

TooTallNate approved these changes Oct 29, 2024

View reviewed changes

erikareads approved these changes Oct 29, 2024

View reviewed changes

kodiakhq bot merged commit 54efb38 into main Oct 29, 2024

kodiakhq bot deleted the trek/zero-2810-make-all-metrics-tracking-methods-on-the-store-require branch October 29, 2024 22:14

vercel-release-bot mentioned this pull request Oct 29, 2024

Version Packages #12424

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cli] Make all metrics tracking methods on the store require arguments#12422

[cli] Make all metrics tracking methods on the store require arguments#12422
kodiakhq[bot] merged 8 commits intomainfrom
trek/zero-2810-make-all-metrics-tracking-methods-on-the-store-require

trek commented Oct 29, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 29, 2024 •

edited

Loading

Uh oh!

trek Oct 29, 2024

Uh oh!

EndangeredMassa Oct 29, 2024

Uh oh!

trek Oct 29, 2024

Uh oh!

EndangeredMassa Oct 29, 2024

Uh oh!

kodiakhq bot commented Oct 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

trek commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

trek Oct 29, 2024

Choose a reason for hiding this comment

Uh oh!

EndangeredMassa Oct 29, 2024

Choose a reason for hiding this comment

Uh oh!

trek Oct 29, 2024

Choose a reason for hiding this comment

Uh oh!

EndangeredMassa Oct 29, 2024

Choose a reason for hiding this comment

Uh oh!

kodiakhq bot commented Oct 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

trek commented Oct 29, 2024 •

edited

Loading

changeset-bot bot commented Oct 29, 2024 •

edited

Loading