[cli] Track `git --confirm` earlier by trek · Pull Request #12419 · vercel/vercel

trek · 2024-10-29T17:37:15Z

Because both --yes and --confirm are technically allowed we want to track both. To handle the fact that --confirm is deprecated is managed with the following pattern:

    output.warn('`--confirm` is deprecated, please use `--yes` instead');
    parsedArgs.flags['--yes'] = parsedArgs.flags['--confirm'];

so we need to ensure we've tracked uses of --confirm before we smoosh them together. @EndangeredMassa and I audited for this pattern and we've done this in all places except vercel git.

vercel git needs access to the value in the outer command before the subcommand is called:

vercel/packages/cli/src/commands/git/index.ts

Lines 52 to 55 in 4db2c19

    
           const autoConfirm = Boolean(parsedArgs.flags['--yes']); 
        
           const { cwd } = client; 
        
           const linkedProject = await ensureLink('git', client, cwd, { autoConfirm });

So the tracking needs to move.

changeset-bot · 2024-10-29T17:37:20Z

🦋 Changeset detected

Latest commit: 8903e67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/cli/test/unit/commands/git/connect.test.ts

…f-confirm-and-yes

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - Strongly type `TelemetryClient` subclasses against command specification ([#12426](#12426)) - Adds `vercel integration remove` to uninstall Marketplace integrations from the current team ([#12291](#12291)) Adds `vercel integration-resource disconnect` to disconnect Marketplace integration resources from projects Adds `vercel integration-resource remove` to delete Marketplace integration resources ### Patch Changes - [cli] Make all metrics tracking methods on the store require arguments ([#12422](#12422)) - Support allowHeader from Next.js for filtering request headers during revalidation ([#12420](#12420)) - [cli] don't track unreachable condition ([#12419](#12419)) - Updated dependencies \[[`5a6605bbd99c3b4c3f06fc315dd3978fe7801d00`](5a6605b)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/functions@1.5.0 ### Minor Changes - ipAddress: accept headers as input ([#12429](#12429)) ## @vercel/[email protected] ### Patch Changes - Support allowHeader from Next.js for filtering request headers during revalidation ([#12420](#12420)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`5a6605bbd99c3b4c3f06fc315dd3978fe7801d00`](5a6605b)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`5a6605bbd99c3b4c3f06fc315dd3978fe7801d00`](5a6605b)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Support allowHeader from Next.js for filtering request headers during revalidation ([#12420](#12420)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`5a6605bbd99c3b4c3f06fc315dd3978fe7801d00`](5a6605b)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`5a6605bbd99c3b4c3f06fc315dd3978fe7801d00`](5a6605b)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - Strongly type `TelemetryClient` subclasses against command specification ([#12426](vercel/vercel#12426)) - Adds `vercel integration remove` to uninstall Marketplace integrations from the current team ([#12291](vercel/vercel#12291)) Adds `vercel integration-resource disconnect` to disconnect Marketplace integration resources from projects Adds `vercel integration-resource remove` to delete Marketplace integration resources ### Patch Changes - [cli] Make all metrics tracking methods on the store require arguments ([#12422](vercel/vercel#12422)) - Support allowHeader from Next.js for filtering request headers during revalidation ([#12420](vercel/vercel#12420)) - [cli] don't track unreachable condition ([#12419](vercel/vercel#12419)) - Updated dependencies \[[`ea72a9f85d9fba806e382ef1a7e52b73f78132d9`](vercel/vercel@ea72a9f)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - ipAddress: accept headers as input ([#12429](vercel/vercel#12429)) ## @vercel/[email protected] ### Patch Changes - Support allowHeader from Next.js for filtering request headers during revalidation ([#12420](vercel/vercel#12420)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`ea72a9f85d9fba806e382ef1a7e52b73f78132d9`](vercel/vercel@ea72a9f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`ea72a9f85d9fba806e382ef1a7e52b73f78132d9`](vercel/vercel@ea72a9f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Support allowHeader from Next.js for filtering request headers during revalidation ([#12420](vercel/vercel#12420)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`ea72a9f85d9fba806e382ef1a7e52b73f78132d9`](vercel/vercel@ea72a9f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`ea72a9f85d9fba806e382ef1a7e52b73f78132d9`](vercel/vercel@ea72a9f)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

trek added 2 commits October 29, 2024 12:06

[cli] don't track unreachable condition

d1d57a3

[cli] Correctly track --confirm on git connect

5fb1270

Create yellow-rats-shop.md

578604c

trek changed the title ~~[cli] don't track unreachable condition~~ [cli] Track git --confirm earlier Oct 29, 2024

vercel bot deployed to Preview October 29, 2024 17:38 View deployment

TooTallNate reviewed Oct 29, 2024

View reviewed changes

packages/cli/test/unit/commands/git/connect.test.ts Outdated Show resolved Hide resolved

trek marked this pull request as ready for review October 29, 2024 17:52

trek requested review from EndangeredMassa, erikareads, jeffsee55 and onsclom as code owners October 29, 2024 17:52

[cli] Only track yes or confirm, but not both on vercel git

3a4552f

trek requested a review from TooTallNate October 29, 2024 18:02

vercel bot deployed to Preview October 29, 2024 18:02 View deployment

TooTallNate approved these changes Oct 29, 2024

View reviewed changes

trek added the pr: automerge label Oct 29, 2024

Merge branch 'main' into trek/zero-2801-verify-and-correct-tracking-o…

302ceb6

…f-confirm-and-yes

vercel bot deployed to Preview October 29, 2024 18:36 View deployment

erikareads approved these changes Oct 29, 2024

View reviewed changes

onsclom approved these changes Oct 29, 2024

View reviewed changes

Merge branch 'main' into trek/zero-2801-verify-and-correct-tracking-o…

8903e67

…f-confirm-and-yes

vercel bot deployed to Preview October 29, 2024 19:08 View deployment

kodiakhq bot merged commit b7191a7 into main Oct 29, 2024

kodiakhq bot deleted the trek/zero-2801-verify-and-correct-tracking-of-confirm-and-yes branch October 29, 2024 19:28

vercel-release-bot mentioned this pull request Oct 29, 2024

Version Packages #12424

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cli] Track `git --confirm` earlier#12419

[cli] Track `git --confirm` earlier#12419
kodiakhq[bot] merged 6 commits intomainfrom
trek/zero-2801-verify-and-correct-tracking-of-confirm-and-yes

trek commented Oct 29, 2024

Uh oh!

changeset-bot bot commented Oct 29, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	const autoConfirm = Boolean(parsedArgs.flags['--yes']);
	const { cwd } = client;

	const linkedProject = await ensureLink('git', client, cwd, { autoConfirm });

Conversation

trek commented Oct 29, 2024

Uh oh!

changeset-bot bot commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot bot commented Oct 29, 2024 •

edited

Loading