[node] unskip test for mac/linux#12267
Merged
kodiakhq[bot] merged 4 commits intomainfrom Oct 10, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 23b7cc1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trek
requested review from
EndangeredMassa,
Kikobeats,
TooTallNate,
erikareads,
jeffsee55 and
onsclom
as code owners
erikareads
approved these changes
Oct 10, 2024
kodiakhq
bot
deleted the
trek/zero-2616-check-into-skipped-test-in-packagenode
branch
EndangeredMassa
added a commit
that referenced
this pull request
Oct 22, 2024
This reverts commit 311ed1d.
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
Reverts #12267 This test was skipped in Windows because it was flakey. This PR unskips it and resolves the flakiness by adjusting some timeout values. --- This turned out to be a specific issue with [Node 22 and Windows](nodejs/node#51766) and timers. The way our use of `waitUntil` works with the `devServer`'s simulations of serverless functions creates an environment where we can kill the dev server at the same time that the `waitUntil` promise expires. I didn't nail down the exact flow that happens here, but this causes the Node 22 + Windows `EPREM` error to bubble up to the test failure. Ultimately, the specific flow isn't critical to figure out here. This is a test setup issue, not a production issue. --- In an attempt to prove this is no longer flakey, here are several consecutive successful runs: - https://github.com/vercel/vercel/actions/runs/11469305192/job/31916358922?pr=12333 - https://github.com/vercel/vercel/actions/runs/11469447637/job/31916775908?pr=12333 - https://github.com/vercel/vercel/actions/runs/11469447637/job/31917078929?pr=12333 - https://github.com/vercel/vercel/actions/runs/11469447637/job/31917252353?pr=12333
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
Reverts vercel/vercel#12267 This test was skipped in Windows because it was flakey. This PR unskips it and resolves the flakiness by adjusting some timeout values. --- This turned out to be a specific issue with [Node 22 and Windows](nodejs/node#51766) and timers. The way our use of `waitUntil` works with the `devServer`'s simulations of serverless functions creates an environment where we can kill the dev server at the same time that the `waitUntil` promise expires. I didn't nail down the exact flow that happens here, but this causes the Node 22 + Windows `EPREM` error to bubble up to the test failure. Ultimately, the specific flow isn't critical to figure out here. This is a test setup issue, not a production issue. --- In an attempt to prove this is no longer flakey, here are several consecutive successful runs: - https://github.com/vercel/vercel/actions/runs/11469305192/job/31916358922?pr=12333 - https://github.com/vercel/vercel/actions/runs/11469447637/job/31916775908?pr=12333 - https://github.com/vercel/vercel/actions/runs/11469447637/job/31917078929?pr=12333 - https://github.com/vercel/vercel/actions/runs/11469447637/job/31917252353?pr=12333
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test started failing on Windows in #12212. Still tracking down why, but I think we can enable for other platforms at least.