Skip to content

[build-utils] Fix corepack packageManager detection on monorepos#12219

Merged
onsclom merged 8 commits intomainfrom
austinmerrick/fix-corepack-detection-on-monorepos
Oct 4, 2024
Merged

[build-utils] Fix corepack packageManager detection on monorepos#12219
onsclom merged 8 commits intomainfrom
austinmerrick/fix-corepack-detection-on-monorepos

Conversation

@onsclom
Copy link
Copy Markdown
Contributor

@onsclom onsclom commented Oct 3, 2024 •
edited
Loading

Reverting #12099

This change was originally reverted because Turborepo did not handle corepack correctly. Now #12211 mitigates this problem.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: cf1d93c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@vercel/static-build Patch
@vercel/build-utils Patch
@vercel/hydrogen Patch
@vercel/redwood Patch
@vercel/remix-builder Patch
@vercel/next Patch
vercel Patch
@vercel/client Patch
@vercel/gatsby-plugin-vercel-builder Patch
@vercel/node Patch
@vercel-internals/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@onsclom onsclom force-pushed the austinmerrick/fix-corepack-detection-on-monorepos branch from 57239d3 to 19c940c Compare October 3, 2024 19:25
onsclom added 4 commits October 3, 2024 14:53
@onsclom
Fix corepack packageManager detection on monorepos (#11811)
2575ec1 
Corepack was failing to be enabled when the `packageManager` field is set at the root of a monorepo (which is likely a common case). The fix is to crawl up directories and read the `package.json` at each step to try and find the `packageManager` value.
@onsclom
Fix build-vite
fe16317
@onsclom
Remove console.logs
8caf577
@onsclom
Fix cliType logic
329a652
@onsclom onsclom force-pushed the austinmerrick/fix-corepack-detection-on-monorepos branch from f724c0e to 329a652 Compare October 3, 2024 21:53
@onsclom onsclom marked this pull request as ready for review October 3, 2024 22:23
@onsclom onsclom requested review from huozhi and ztanner as code owners October 3, 2024 22:23
@onsclom onsclom merged commit e312d61 into main Oct 4, 2024
@onsclom onsclom deleted the austinmerrick/fix-corepack-detection-on-monorepos branch October 4, 2024 19:31
@vercel-release-bot vercel-release-bot mentioned this pull request Oct 4, 2024
Merged
onsclom pushed a commit that referenced this pull request Oct 7, 2024
@vercel-release-bot @github-actions
Version Packages (#12222)
fd9a850 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vercel/[email protected]

### Patch Changes

- Disable corepack when Turborepo does not support `COREPACK_HOME`
([#12211](#12211))

- Fix corepack `packageManager` detection on monorepos
([#12219](#12219))

## [email protected]

### Patch Changes

- [cli] Remove documented `--next` option from `target ls`
([#12221](#12221))

- [cli] Add tracking event for Vercel CLI version
([#12212](#12212))

- [cli] Don't send telemetry if debugging
([#12228](#12228))

- [cli] set telemetry enabled to false with VERCEL_TELEMETRY_DISABLED
([#12229](#12229))

- [cli] use `ms` for timeout values
([#12220](#12220))

- Add tracking events for platform, arch, and cpu_count.
([#12190](#12190))

- Add support for telemetry debugging via VERCEL_TELEMETRY_DEBUG.
Telemetry collection is not currently enabled and when it is, will be a
major version bump for the CLI.
([#12209](#12209))

- [cli] Remove incorrect --output docs for `vercel certs`
([#12230](#12230))

- Updated dependencies
\[[`a6227a56d7feec77b5355d2cd5fc07f151021d73`](a6227a5),
[`e312d610177b28cf1592b18ca85b8d4e088ffc05`](e312d61)]:
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- Updated dependencies
\[[`a6227a56d7feec77b5355d2cd5fc07f151021d73`](a6227a5),
[`e312d610177b28cf1592b18ca85b8d4e088ffc05`](e312d61)]:
    -   @vercel/[email protected]

## @vercel/functions@1.4.2

### Patch Changes

- [functions] decode city name
([#12234](#12234))

## @vercel/[email protected]

### Patch Changes

- Updated dependencies
\[[`a6227a56d7feec77b5355d2cd5fc07f151021d73`](a6227a5),
[`e312d610177b28cf1592b18ca85b8d4e088ffc05`](e312d61)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- Disable corepack when Turborepo does not support `COREPACK_HOME`
([#12211](#12211))

- Fix corepack `packageManager` detection on monorepos
([#12219](#12219))

## @vercel/[email protected]

### Patch Changes

- Disable corepack when Turborepo does not support `COREPACK_HOME`
([#12211](#12211))

- Fix corepack `packageManager` detection on monorepos
([#12219](#12219))

## @vercel/[email protected]

### Patch Changes

- Updated dependencies
\[[`a6227a56d7feec77b5355d2cd5fc07f151021d73`](a6227a5),
[`e312d610177b28cf1592b18ca85b8d4e088ffc05`](e312d61)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- Disable corepack when Turborepo does not support `COREPACK_HOME`
([#12211](#12211))

- Fix corepack `packageManager` detection on monorepos
([#12219](#12219))

## @vercel/[email protected]

### Patch Changes

- Disable corepack when Turborepo does not support `COREPACK_HOME`
([#12211](#12211))

- Fix corepack `packageManager` detection on monorepos
([#12219](#12219))

## @vercel/[email protected]

### Patch Changes

- Disable corepack when Turborepo does not support `COREPACK_HOME`
([#12211](#12211))

- Fix corepack `packageManager` detection on monorepos
([#12219](#12219))

-   Updated dependencies \[]:
    -   @vercel/[email protected]

## @vercel-internals/[email protected]

### Patch Changes

- Updated dependencies
\[[`a6227a56d7feec77b5355d2cd5fc07f151021d73`](a6227a5),
[`e312d610177b28cf1592b18ca85b8d4e088ffc05`](e312d61)]:
    -   @vercel/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@EndangeredMassa EndangeredMassa mentioned this pull request Oct 8, 2024
Merged
EndangeredMassa added a commit that referenced this pull request Oct 8, 2024
@EndangeredMassa
Revert "[build-utils] Fix corepack packageManager detection on mono…
226028a 
…repos" (#12242)

Reverts #12219 because it caused an issue with corepack
versions being set to `latest`.

https://vercel.slack.com/archives/C07R9QVM5L1
QuietCraftsmanship pushed a commit to QuietCraftsmanship/Vercel that referenced this pull request Jul 6, 2025
@github-actions
Version Packages (#12222)
a661eda 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vercel/[email protected]

### Patch Changes

- Disable corepack when Turborepo does not support `COREPACK_HOME`
([#12211](vercel/vercel#12211))

- Fix corepack `packageManager` detection on monorepos
([#12219](vercel/vercel#12219))

## [email protected]

### Patch Changes

- [cli] Remove documented `--next` option from `target ls`
([#12221](vercel/vercel#12221))

- [cli] Add tracking event for Vercel CLI version
([#12212](vercel/vercel#12212))

- [cli] Don't send telemetry if debugging
([#12228](vercel/vercel#12228))

- [cli] set telemetry enabled to false with VERCEL_TELEMETRY_DISABLED
([#12229](vercel/vercel#12229))

- [cli] use `ms` for timeout values
([#12220](vercel/vercel#12220))

- Add tracking events for platform, arch, and cpu_count.
([#12190](vercel/vercel#12190))

- Add support for telemetry debugging via VERCEL_TELEMETRY_DEBUG.
Telemetry collection is not currently enabled and when it is, will be a
major version bump for the CLI.
([#12209](vercel/vercel#12209))

- [cli] Remove incorrect --output docs for `vercel certs`
([#12230](vercel/vercel#12230))

- Updated dependencies
\[[`10f939c5c9637f7fdc12b417fcd1dbed7ae336f4`](vercel/vercel@10f939c),
[`1aa81addc6336dbdf3daf5aa3aa86b8dc46b67d2`](vercel/vercel@1aa81ad)]:
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- Updated dependencies
\[[`10f939c5c9637f7fdc12b417fcd1dbed7ae336f4`](vercel/vercel@10f939c),
[`1aa81addc6336dbdf3daf5aa3aa86b8dc46b67d2`](vercel/vercel@1aa81ad)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- [functions] decode city name
([#12234](vercel/vercel#12234))

## @vercel/[email protected]

### Patch Changes

- Updated dependencies
\[[`10f939c5c9637f7fdc12b417fcd1dbed7ae336f4`](vercel/vercel@10f939c),
[`1aa81addc6336dbdf3daf5aa3aa86b8dc46b67d2`](vercel/vercel@1aa81ad)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- Disable corepack when Turborepo does not support `COREPACK_HOME`
([#12211](vercel/vercel#12211))

- Fix corepack `packageManager` detection on monorepos
([#12219](vercel/vercel#12219))

## @vercel/[email protected]

### Patch Changes

- Disable corepack when Turborepo does not support `COREPACK_HOME`
([#12211](vercel/vercel#12211))

- Fix corepack `packageManager` detection on monorepos
([#12219](vercel/vercel#12219))

## @vercel/[email protected]

### Patch Changes

- Updated dependencies
\[[`10f939c5c9637f7fdc12b417fcd1dbed7ae336f4`](vercel/vercel@10f939c),
[`1aa81addc6336dbdf3daf5aa3aa86b8dc46b67d2`](vercel/vercel@1aa81ad)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- Disable corepack when Turborepo does not support `COREPACK_HOME`
([#12211](vercel/vercel#12211))

- Fix corepack `packageManager` detection on monorepos
([#12219](vercel/vercel#12219))

## @vercel/[email protected]

### Patch Changes

- Disable corepack when Turborepo does not support `COREPACK_HOME`
([#12211](vercel/vercel#12211))

- Fix corepack `packageManager` detection on monorepos
([#12219](vercel/vercel#12219))

## @vercel/[email protected]

### Patch Changes

- Disable corepack when Turborepo does not support `COREPACK_HOME`
([#12211](vercel/vercel#12211))

- Fix corepack `packageManager` detection on monorepos
([#12219](vercel/vercel#12219))

-   Updated dependencies \[]:
    -   @vercel/[email protected]

## @vercel-internals/[email protected]

### Patch Changes

- Updated dependencies
\[[`10f939c5c9637f7fdc12b417fcd1dbed7ae336f4`](vercel/vercel@10f939c),
[`1aa81addc6336dbdf3daf5aa3aa86b8dc46b67d2`](vercel/vercel@1aa81ad)]:
    -   @vercel/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
QuietCraftsmanship pushed a commit to QuietCraftsmanship/Vercel that referenced this pull request Jul 6, 2025
@EndangeredMassa
Revert "[build-utils] Fix corepack packageManager detection on mono…
8058185 
…repos" (#12242)

Reverts vercel/vercel#12219 because it caused an issue with corepack
versions being set to `latest`.

https://vercel.slack.com/archives/C07R9QVM5L1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TooTallNate TooTallNate Awaiting requested review from TooTallNate

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa

@jeffsee55 jeffsee55 Awaiting requested review from jeffsee55

@erikareads erikareads Awaiting requested review from erikareads

@trek trek Awaiting requested review from trek

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@onsclom @trek