Add support for telemetry debugging via VERCEL_TELEMETRY_DEBUG by jeffsee55 · Pull Request #12209 · vercel/vercel

jeffsee55 · 2024-10-02T20:08:08Z

Specify VERCEL_TELEMETRY_DEBUG =1 vc alias list to view a printout of the telemetry events, rather than sending them off for collection.

This no longer writes to output.debug as this behavior is separate from the --debug global flag.

changeset-bot · 2024-10-02T20:08:14Z

🦋 Changeset detected

Latest commit: 462b8fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/cli/src/util/telemetry/index.ts

Co-authored-by: Austin Merrick <[email protected]>

…zero-2466-support-vercel_telemetry_debug1

erikareads

Why does this say files changed 2? I don't see the change that adds support for the environment variable?

This reverts commit 64acfdd.

jeffsee55 · 2024-10-03T21:50:05Z

Why does this say files changed 2? I don't see the change that adds support for the environment variable?

Not sure what happened there, bad merge from main I guess, fixed!

erikareads · 2024-10-03T21:56:45Z

packages/cli/src/util/telemetry/index.ts

+      // not write to stderr unless it is run with `--debug`
+      this.output.log(`${LogLabel} Flushing Events`);
      this.events.forEach(event => {
        this.output.debug(JSON.stringify(event));


Shouldn't this be this.output.log as well?

Yes! It was 64acfdd, I really don't know what happened there 🤔

We probably also want to make the follow-up conditional an else if to keep in line with our plan to have debugging disable sending to server discussion

…ebug1

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/[email protected] ### Patch Changes - Disable corepack when Turborepo does not support `COREPACK_HOME` ([#12211](#12211)) - Fix corepack `packageManager` detection on monorepos ([#12219](#12219)) ## [email protected] ### Patch Changes - [cli] Remove documented `--next` option from `target ls` ([#12221](#12221)) - [cli] Add tracking event for Vercel CLI version ([#12212](#12212)) - [cli] Don't send telemetry if debugging ([#12228](#12228)) - [cli] set telemetry enabled to false with VERCEL_TELEMETRY_DISABLED ([#12229](#12229)) - [cli] use `ms` for timeout values ([#12220](#12220)) - Add tracking events for platform, arch, and cpu_count. ([#12190](#12190)) - Add support for telemetry debugging via VERCEL_TELEMETRY_DEBUG. Telemetry collection is not currently enabled and when it is, will be a major version bump for the CLI. ([#12209](#12209)) - [cli] Remove incorrect --output docs for `vercel certs` ([#12230](#12230)) - Updated dependencies \[[`a6227a56d7feec77b5355d2cd5fc07f151021d73`](a6227a5), [`e312d610177b28cf1592b18ca85b8d4e088ffc05`](e312d61)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`a6227a56d7feec77b5355d2cd5fc07f151021d73`](a6227a5), [`e312d610177b28cf1592b18ca85b8d4e088ffc05`](e312d61)]: - @vercel/[email protected] ## @vercel/functions@1.4.2 ### Patch Changes - [functions] decode city name ([#12234](#12234)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`a6227a56d7feec77b5355d2cd5fc07f151021d73`](a6227a5), [`e312d610177b28cf1592b18ca85b8d4e088ffc05`](e312d61)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Disable corepack when Turborepo does not support `COREPACK_HOME` ([#12211](#12211)) - Fix corepack `packageManager` detection on monorepos ([#12219](#12219)) ## @vercel/[email protected] ### Patch Changes - Disable corepack when Turborepo does not support `COREPACK_HOME` ([#12211](#12211)) - Fix corepack `packageManager` detection on monorepos ([#12219](#12219)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`a6227a56d7feec77b5355d2cd5fc07f151021d73`](a6227a5), [`e312d610177b28cf1592b18ca85b8d4e088ffc05`](e312d61)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Disable corepack when Turborepo does not support `COREPACK_HOME` ([#12211](#12211)) - Fix corepack `packageManager` detection on monorepos ([#12219](#12219)) ## @vercel/[email protected] ### Patch Changes - Disable corepack when Turborepo does not support `COREPACK_HOME` ([#12211](#12211)) - Fix corepack `packageManager` detection on monorepos ([#12219](#12219)) ## @vercel/[email protected] ### Patch Changes - Disable corepack when Turborepo does not support `COREPACK_HOME` ([#12211](#12211)) - Fix corepack `packageManager` detection on monorepos ([#12219](#12219)) - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`a6227a56d7feec77b5355d2cd5fc07f151021d73`](a6227a5), [`e312d610177b28cf1592b18ca85b8d4e088ffc05`](e312d61)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/[email protected] ### Patch Changes - Disable corepack when Turborepo does not support `COREPACK_HOME` ([#12211](vercel/vercel#12211)) - Fix corepack `packageManager` detection on monorepos ([#12219](vercel/vercel#12219)) ## [email protected] ### Patch Changes - [cli] Remove documented `--next` option from `target ls` ([#12221](vercel/vercel#12221)) - [cli] Add tracking event for Vercel CLI version ([#12212](vercel/vercel#12212)) - [cli] Don't send telemetry if debugging ([#12228](vercel/vercel#12228)) - [cli] set telemetry enabled to false with VERCEL_TELEMETRY_DISABLED ([#12229](vercel/vercel#12229)) - [cli] use `ms` for timeout values ([#12220](vercel/vercel#12220)) - Add tracking events for platform, arch, and cpu_count. ([#12190](vercel/vercel#12190)) - Add support for telemetry debugging via VERCEL_TELEMETRY_DEBUG. Telemetry collection is not currently enabled and when it is, will be a major version bump for the CLI. ([#12209](vercel/vercel#12209)) - [cli] Remove incorrect --output docs for `vercel certs` ([#12230](vercel/vercel#12230)) - Updated dependencies \[[`10f939c5c9637f7fdc12b417fcd1dbed7ae336f4`](vercel/vercel@10f939c), [`1aa81addc6336dbdf3daf5aa3aa86b8dc46b67d2`](vercel/vercel@1aa81ad)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`10f939c5c9637f7fdc12b417fcd1dbed7ae336f4`](vercel/vercel@10f939c), [`1aa81addc6336dbdf3daf5aa3aa86b8dc46b67d2`](vercel/vercel@1aa81ad)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - [functions] decode city name ([#12234](vercel/vercel#12234)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`10f939c5c9637f7fdc12b417fcd1dbed7ae336f4`](vercel/vercel@10f939c), [`1aa81addc6336dbdf3daf5aa3aa86b8dc46b67d2`](vercel/vercel@1aa81ad)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Disable corepack when Turborepo does not support `COREPACK_HOME` ([#12211](vercel/vercel#12211)) - Fix corepack `packageManager` detection on monorepos ([#12219](vercel/vercel#12219)) ## @vercel/[email protected] ### Patch Changes - Disable corepack when Turborepo does not support `COREPACK_HOME` ([#12211](vercel/vercel#12211)) - Fix corepack `packageManager` detection on monorepos ([#12219](vercel/vercel#12219)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`10f939c5c9637f7fdc12b417fcd1dbed7ae336f4`](vercel/vercel@10f939c), [`1aa81addc6336dbdf3daf5aa3aa86b8dc46b67d2`](vercel/vercel@1aa81ad)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Disable corepack when Turborepo does not support `COREPACK_HOME` ([#12211](vercel/vercel#12211)) - Fix corepack `packageManager` detection on monorepos ([#12219](vercel/vercel#12219)) ## @vercel/[email protected] ### Patch Changes - Disable corepack when Turborepo does not support `COREPACK_HOME` ([#12211](vercel/vercel#12211)) - Fix corepack `packageManager` detection on monorepos ([#12219](vercel/vercel#12219)) ## @vercel/[email protected] ### Patch Changes - Disable corepack when Turborepo does not support `COREPACK_HOME` ([#12211](vercel/vercel#12211)) - Fix corepack `packageManager` detection on monorepos ([#12219](vercel/vercel#12219)) - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`10f939c5c9637f7fdc12b417fcd1dbed7ae336f4`](vercel/vercel@10f939c), [`1aa81addc6336dbdf3daf5aa3aa86b8dc46b67d2`](vercel/vercel@1aa81ad)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Add support for telemetry debugging via VERCEL_TELEMETRY_DEBUG

64acfdd

jeffsee55 requested review from EndangeredMassa, TooTallNate, erikareads, onsclom and trek as code owners October 2, 2024 20:08

trek previously approved these changes Oct 2, 2024

View reviewed changes

onsclom previously approved these changes Oct 3, 2024

View reviewed changes

packages/cli/src/util/telemetry/index.ts Outdated Show resolved Hide resolved

Update packages/cli/src/util/telemetry/index.ts

4724edb

Co-authored-by: Austin Merrick <[email protected]>

jeffsee55 dismissed stale reviews from onsclom and trek via 4724edb October 3, 2024 20:49

vercel bot deployed to Preview October 3, 2024 20:50 View deployment

Merge branch 'main' of https://github.com/vercel/vercel into jeffsee/…

5b6d446

…zero-2466-support-vercel_telemetry_debug1

jeffsee55 added the pr: automerge label Oct 3, 2024

vercel bot deployed to Preview October 3, 2024 20:53 View deployment

erikareads reviewed Oct 3, 2024

View reviewed changes

vercel bot deployed to Preview October 3, 2024 21:07 View deployment

jeffsee55 added 2 commits October 3, 2024 14:45

Revert "Add support for telemetry debugging via VERCEL_TELEMETRY_DEBUG"

4e75aee

This reverts commit 64acfdd.

Add changeset

a1f45a5

jeffsee55 force-pushed the jeffsee/zero-2466-support-vercel_telemetry_debug1 branch from 99caccb to a1f45a5 Compare October 3, 2024 21:47

vercel bot deployed to Preview October 3, 2024 21:48 View deployment

Dont share debugging logic with CLI's --debug flag

c71aa92

vercel bot deployed to Preview October 3, 2024 21:50 View deployment

erikareads reviewed Oct 3, 2024

View reviewed changes

Use output.log instead of output.debug

afca7f4

vercel bot deployed to Preview October 3, 2024 22:03 View deployment

erikareads approved these changes Oct 3, 2024

View reviewed changes

Merge branch 'main' into jeffsee/zero-2466-support-vercel_telemetry_d…

462b8fa

…ebug1

vercel bot deployed to Preview October 3, 2024 22:19 View deployment

kodiakhq bot merged commit 51aa365 into main Oct 3, 2024

kodiakhq bot deleted the jeffsee/zero-2466-support-vercel_telemetry_debug1 branch October 3, 2024 22:22

vercel-release-bot mentioned this pull request Oct 3, 2024

Version Packages #12222

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for telemetry debugging via VERCEL_TELEMETRY_DEBUG#12209

Add support for telemetry debugging via VERCEL_TELEMETRY_DEBUG#12209
kodiakhq[bot] merged 8 commits intomainfrom
jeffsee/zero-2466-support-vercel_telemetry_debug1

jeffsee55 commented Oct 2, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 2, 2024 •

edited

Loading

Uh oh!

Uh oh!

erikareads left a comment

Uh oh!

jeffsee55 commented Oct 3, 2024

Uh oh!

erikareads Oct 3, 2024

Uh oh!

jeffsee55 Oct 3, 2024

Uh oh!

erikareads Oct 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jeffsee55 commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

erikareads left a comment

Choose a reason for hiding this comment

Uh oh!

jeffsee55 commented Oct 3, 2024

Uh oh!

erikareads Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

jeffsee55 Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

erikareads Oct 3, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jeffsee55 commented Oct 2, 2024 •

edited

Loading

changeset-bot bot commented Oct 2, 2024 •

edited

Loading