Skip to content

[client] Remove @zeit/fetch and always use node-fetch instead#12171

Merged
kodiakhq[bot] merged 8 commits intomainfrom
austinmerrick/remove-zeit-fetch-dep
Sep 27, 2024
Merged

[client] Remove @zeit/fetch and always use node-fetch instead#12171
kodiakhq[bot] merged 8 commits intomainfrom
austinmerrick/remove-zeit-fetch-dep

Conversation

@onsclom
Copy link
Copy Markdown
Contributor

@onsclom onsclom commented Sep 24, 2024

@zeit/fetch is archived and it causes deprecation warnings for util._extend usage.

@onsclom
[client] Remove @zeit/fetch and always use node-fetch instead
db6fab9 
`@zeit/fetch` is an archived repo and it causes deprecation warnings for `util._extend` usage.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 24, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d3850ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vercel/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@socket-security
Copy link
Copy Markdown

socket-security bot commented Sep 24, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@zeit/[email protected]

View full report↗︎

@onsclom
Copy link
Copy Markdown
Contributor Author

onsclom commented Sep 25, 2024

@TooTallNate, curious what you think of this to solve the util._extend usage deprecation warning. vercel/fetch is archived and the latest version causes this deprecation warning.

  • this solves the deprecation warnings and tests are successful
  • we lose things @zeit/fetch does like retrying and DNS caching (how important are these?)

Other possibilities:

  • vendor in @zeit/fetch and it's deps to try and solve util._extend usage
  • find another library that provides these things?

@TooTallNate
Copy link
Copy Markdown
Member

TooTallNate commented Sep 25, 2024 •
edited
Loading

I'm good with this approach. DNS caching shouldn't be an application-level concern, and was from a time when Node.js was a lot less mature.

TooTallNate
TooTallNate reviewed Sep 25, 2024
View reviewed changes
TooTallNate
TooTallNate previously approved these changes Sep 25, 2024
View reviewed changes
@onsclom onsclom marked this pull request as ready for review September 25, 2024 19:45
trek
trek previously approved these changes Sep 25, 2024
View reviewed changes
@onsclom onsclom dismissed stale reviews from trek and TooTallNate via 8d2ace4 September 25, 2024 19:55
@onsclom onsclom requested review from TooTallNate and trek September 26, 2024 16:08
@kodiakhq kodiakhq bot merged commit f8c114a into main Sep 27, 2024
@kodiakhq kodiakhq bot deleted the austinmerrick/remove-zeit-fetch-dep branch September 27, 2024 19:01
@vercel-release-bot vercel-release-bot mentioned this pull request Sep 27, 2024
Merged
jeffsee55 pushed a commit that referenced this pull request Oct 3, 2024
@vercel-release-bot @github-actions
Version Packages (#12188)
9394a07 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vercel/[email protected]

### Patch Changes

- add support for `images.localPatterns`
([#12195](#12195))

## [email protected]

### Patch Changes

- Add a command for enabling and disabling telemetry. Telemetry
collection is not currently enabled and when it is, will be a major
version bump for the CLI.
([#12207](#12207))

- [cli] Remove incorrect `--json` flag on `vercel alias`
([#12198](#12198))

- Standardize most error output through `output.error`
([#12012](#12012))

- Replace `psl` with `tldts` for domain parsing
([#12174](#12174))

- add support for `images.localPatterns`
([#12195](#12195))

- [cli] add telemetry tracking to `alias ls`
([#12194](#12194))

- Add support for tracking Continuous Integration vendors with telemetry
([#12180](#12180))

- Add session id to events
([#12179](#12179))

- Updated dependencies
\[[`5431ffd5de6a572f247e63f737576b4a04884f7b`](5431ffd)]:
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- Replace `@zeit/fetch` usage with `node-fetch`
([#12171](#12171))

- Updated dependencies
\[[`5431ffd5de6a572f247e63f737576b4a04884f7b`](5431ffd)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

-   Link to docs ([#12216](#12216))

## @vercel/[email protected]

### Patch Changes

- Updated dependencies
\[[`5431ffd5de6a572f247e63f737576b4a04884f7b`](5431ffd)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- add support for `images.localPatterns`
([#12195](#12195))

## @vercel/[email protected]

### Patch Changes

- Updated dependencies
\[[`5431ffd5de6a572f247e63f737576b4a04884f7b`](5431ffd)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @vercel/[email protected]

## @vercel-internals/[email protected]

### Patch Changes

- Add a command for enabling and disabling telemetry. Telemetry
collection is not currently enabled and when it is, will be a major
version bump for the CLI.
([#12207](#12207))

- Updated dependencies
\[[`5431ffd5de6a572f247e63f737576b4a04884f7b`](5431ffd)]:
    -   @vercel/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
QuietCraftsmanship pushed a commit to QuietCraftsmanship/Vercel that referenced this pull request Jul 6, 2025
@github-actions
Version Packages (#12188)
a24ca27 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vercel/[email protected]

### Patch Changes

- add support for `images.localPatterns`
([#12195](vercel/vercel#12195))

## [email protected]

### Patch Changes

- Add a command for enabling and disabling telemetry. Telemetry
collection is not currently enabled and when it is, will be a major
version bump for the CLI.
([#12207](vercel/vercel#12207))

- [cli] Remove incorrect `--json` flag on `vercel alias`
([#12198](vercel/vercel#12198))

- Standardize most error output through `output.error`
([#12012](vercel/vercel#12012))

- Replace `psl` with `tldts` for domain parsing
([#12174](vercel/vercel#12174))

- add support for `images.localPatterns`
([#12195](vercel/vercel#12195))

- [cli] add telemetry tracking to `alias ls`
([#12194](vercel/vercel#12194))

- Add support for tracking Continuous Integration vendors with telemetry
([#12180](vercel/vercel#12180))

- Add session id to events
([#12179](vercel/vercel#12179))

- Updated dependencies
\[[`9b30d9dd12996b17c743906ba8b59d7dae45930e`](vercel/vercel@9b30d9d)]:
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- Replace `@zeit/fetch` usage with `node-fetch`
([#12171](vercel/vercel#12171))

- Updated dependencies
\[[`9b30d9dd12996b17c743906ba8b59d7dae45930e`](vercel/vercel@9b30d9d)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

-   Link to docs ([#12216](vercel/vercel#12216))

## @vercel/[email protected]

### Patch Changes

- Updated dependencies
\[[`9b30d9dd12996b17c743906ba8b59d7dae45930e`](vercel/vercel@9b30d9d)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

- add support for `images.localPatterns`
([#12195](vercel/vercel#12195))

## @vercel/[email protected]

### Patch Changes

- Updated dependencies
\[[`9b30d9dd12996b17c743906ba8b59d7dae45930e`](vercel/vercel@9b30d9d)]:
    -   @vercel/[email protected]

## @vercel/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @vercel/[email protected]

## @vercel-internals/[email protected]

### Patch Changes

- Add a command for enabling and disabling telemetry. Telemetry
collection is not currently enabled and when it is, will be a major
version bump for the CLI.
([#12207](vercel/vercel#12207))

- Updated dependencies
\[[`9b30d9dd12996b17c743906ba8b59d7dae45930e`](vercel/vercel@9b30d9d)]:
    -   @vercel/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa

@jeffsee55 jeffsee55 Awaiting requested review from jeffsee55

@erikareads erikareads Awaiting requested review from erikareads

+1 more reviewer

@trek trek trek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onsclom @TooTallNate @trek