Closed
Conversation
🦋 Changeset detectedLatest commit: 611555b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trek
force-pushed
the
trerika/distribute-flags
branch
from
75ac09c to
adaab76
Compare
trek
force-pushed
the
trerika/distribute-flags
branch
from
adaab76 to
4c19587
Compare
TooTallNate
approved these changes
Sep 16, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
…ification (#12426) Do some TypeScript magic to construct an interface with the expected method names and function signatures, and make `TelemetryClient` subclasses implement those interfaces. This will ensure that we are not missing any arguments / options. TypeScript will show errors if there is any missing or incompatible methods:  This PR already uncovered a few arguments that were missed being traced: * Added missing argument tracing for `vercel promote` * Added missing argument tracing for `vercel pull` * Added missing argument tracing for `vercel remove` * More consistent argument naming - for example an argument that can take a deployment ID or URL is now defined as `url|deploymentId`, which makes both the telemetry and the `--help` output more consistent **NOTE:** This PR is only addressing the commands which do not themselves have subcommands. We can follow up and finish the swing on implementing these interfaces for such commands after the command specifications have all been individualized (#12103).
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
… command specification (#12446) * Adds the `subcommads` Telemetry methods (i.e. `trackCliSubcommandOpen()`) to the strong typing generic type. * Applies the interface to the `vercel integration` family of (sub)commands, since their commands specification data is already in the correct format. For the rest of the (sub)commands, we still need to wait for #12103, but at least the generic type is now prepared for `subcommands` to be properly defined in the commands' spec.
Member
Contributor
Author
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
…ification (#12426) Do some TypeScript magic to construct an interface with the expected method names and function signatures, and make `TelemetryClient` subclasses implement those interfaces. This will ensure that we are not missing any arguments / options. TypeScript will show errors if there is any missing or incompatible methods:  This PR already uncovered a few arguments that were missed being traced: * Added missing argument tracing for `vercel promote` * Added missing argument tracing for `vercel pull` * Added missing argument tracing for `vercel remove` * More consistent argument naming - for example an argument that can take a deployment ID or URL is now defined as `url|deploymentId`, which makes both the telemetry and the `--help` output more consistent **NOTE:** This PR is only addressing the commands which do not themselves have subcommands. We can follow up and finish the swing on implementing these interfaces for such commands after the command specifications have all been individualized (vercel/vercel#12103).
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
… command specification (#12446) * Adds the `subcommads` Telemetry methods (i.e. `trackCliSubcommandOpen()`) to the strong typing generic type. * Applies the interface to the `vercel integration` family of (sub)commands, since their commands specification data is already in the correct format. For the rest of the (sub)commands, we still need to wait for vercel/vercel#12103, but at least the generic type is now prepared for `subcommands` to be properly defined in the commands' spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We initially thought these were only used for generating help docs, but discovered they are in fact used in parsing arg/options since #11929. Instead of one large PR, we'll be pulling these changes in incrementally as we add telemetry to each command.