Closed
Conversation
🦋 Changeset detectedLatest commit: 43163ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@vercel/[email protected], npm/[email protected], npm/[email protected] |
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
### Before <img width="668" alt="Screenshot 2024-08-12 at 16 44 39" src="https://github.com/user-attachments/assets/2176e191-a786-4737-875a-89b9ed79f3da"> ### After <img width="412" alt="Screenshot 2024-08-12 at 16 45 32" src="https://github.com/user-attachments/assets/c46f8268-3715-492a-ad36-10e9edd7c817"> > **NOTE:** It would have been nice to use `satisfies Command` in the command.ts files for this case, but that keyword does not exist with TypeScript 4 which is what we are currently using. I tried [updating to TS 5](#11930), but was running into issues. So for now the `satisfies` is omitted.
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
### Before <img width="668" alt="Screenshot 2024-08-12 at 16 44 39" src="https://github.com/user-attachments/assets/2176e191-a786-4737-875a-89b9ed79f3da"> ### After <img width="412" alt="Screenshot 2024-08-12 at 16 45 32" src="https://github.com/user-attachments/assets/c46f8268-3715-492a-ad36-10e9edd7c817"> > **NOTE:** It would have been nice to use `satisfies Command` in the command.ts files for this case, but that keyword does not exist with TypeScript 4 which is what we are currently using. I tried [updating to TS 5](vercel/vercel#11930), but was running into issues. So for now the `satisfies` is omitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mainly for the
pnpm run type-checkCI check, since your local editor is likely configured to "Use VSCode's Version" which is the default setting. I was getting some conflicting behavior in CI which I was not seeing reported locally.Note: this is also a semver major for
@vercel/node, since it will use this version of TypeScript when the user's project does not havetypescriptlisted as a dep.