Revert "Revert "warn on mismatched corepack and detected package managers""#11887
Merged
kodiakhq[bot] merged 14 commits intomainfrom Aug 23, 2024
Merged
Conversation
…gers" (#…" This reverts commit 9d9b2fe.
🦋 Changeset detectedLatest commit: 47c7624 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ject-mismatch-corepack
…ject-mismatch-corepack
onsclom
previously approved these changes
Aug 9, 2024
…ject-mismatch-corepack
EndangeredMassa
requested review from
TooTallNate,
erikareads,
jeffsee55 and
trek
as code owners
…ject-mismatch-corepack
…ject-mismatch-corepack
…ject-mismatch-corepack
onsclom
force-pushed
the
revert-11879-revert-11603-endangeredmassa/reject-mismatch-corepack
branch
from
1dd7d90 to
de0cb17
Compare
Contributor
|
The problem was in this branch of logic. If corepack is not enabled, we should prefer detecting the package manager from the lockfile, but This commit shows and fixes the problematic test case. Fixed the behavior, tested with |
EndangeredMassa
commented
Aug 20, 2024
Contributor
Author
EndangeredMassa
left a comment
EndangeredMassa
left a comment
There was a problem hiding this comment.
👍
(I can't approve this because I opened the PR.)
EndangeredMassa
commented
Aug 21, 2024
…ject-mismatch-corepack
onsclom
approved these changes
Aug 23, 2024
kodiakhq
bot
deleted the
revert-11879-revert-11603-endangeredmassa/reject-mismatch-corepack
branch
Merged
onsclom
pushed a commit
that referenced
this pull request
Aug 23, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/[email protected] ### Patch Changes - Revert "Revert "warn on mismatched corepack and detected package managers"" ([#11887](#11887)) ## [email protected] ### Patch Changes - Updated dependencies \[[`c6d469595`](c6d4695), [`49aaea41f`](49aaea4)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`c6d469595`](c6d4695)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`c6d469595`](c6d4695)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - remove experimental .action output handling ([#11998](#11998)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`c6d469595`](c6d4695)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`c6d469595`](c6d4695)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Thompson1985
approved these changes
Dec 18, 2024
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/[email protected] ### Patch Changes - Revert "Revert "warn on mismatched corepack and detected package managers"" ([#11887](vercel/vercel#11887)) ## [email protected] ### Patch Changes - Updated dependencies \[[`cfcab3e95`](vercel/vercel@cfcab3e), [`85db9e036`](vercel/vercel@85db9e0)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`cfcab3e95`](vercel/vercel@cfcab3e)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`cfcab3e95`](vercel/vercel@cfcab3e)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - remove experimental .action output handling ([#11998](vercel/vercel#11998)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`cfcab3e95`](vercel/vercel@cfcab3e)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`cfcab3e95`](vercel/vercel@cfcab3e)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #11879