Revert "Revert "Fix corepack packageManager detection on monorepos""#11871
Merged
EndangeredMassa merged 9 commits intomainfrom Sep 10, 2024
Merged
Revert "Revert "Fix corepack packageManager detection on monorepos""#11871EndangeredMassa merged 9 commits intomainfrom
packageManager detection on monorepos""#11871EndangeredMassa merged 9 commits intomainfrom
Conversation
EndangeredMassa
requested review from
TooTallNate,
erikareads,
huozhi,
ijjk,
jeffsee55,
onsclom,
timneutkens,
trek and
ztanner
as code owners
🦋 Changeset detectedLatest commit: 85cae95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
These got lost when merging
Contributor
|
Confirmed this is ready to merge! We were worried that this caused |
EndangeredMassa
commented
Sep 6, 2024
Comment on lines
+462
to
+464
| const packageJson: PackageJson | null = await fs | ||
| .readJSON(packageJsonPath) | ||
| .catch(() => null); |
Contributor
Author
There was a problem hiding this comment.
suggestion (non-blocking): debug log the error
We should wrap calls like this in a function that can debug log the error and still return null if it fails.
| ); | ||
| const fixture = path.join(base, 'c'); | ||
| const result = await scanParentDirs(fixture, false, base); | ||
| console.log(result); |
Contributor
Author
There was a problem hiding this comment.
suggestion (non-blocking):
Suggested change
| console.log(result); |
| const base = path.join(__dirname, 'fixtures', '41-npm-workspaces-corepack'); | ||
| const fixture = path.join(base, 'a'); | ||
| const result = await scanParentDirs(fixture, false, base); | ||
| console.log(result); |
Contributor
Author
There was a problem hiding this comment.
suggestion (non-blocking):
Suggested change
| console.log(result); |
onsclom
approved these changes
Sep 10, 2024
trek
approved these changes
Sep 10, 2024
EndangeredMassa
deleted the
revert-11865-revert-11811-corepath-debug
branch
onsclom
pushed a commit
that referenced
this pull request
Sep 10, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/[email protected] ### Patch Changes - Revert "Revert "Fix corepack `packageManager` detection on monorepos"" ([#11871](#11871)) ## [email protected] ### Patch Changes - Fix gitBranch parameter for `vc env add` command ([#12085](#12085)) - Updated dependencies \[[`04e15410f`](04e1541)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`04e15410f`](04e1541)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`04e15410f`](04e1541)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Revert "Revert "Fix corepack `packageManager` detection on monorepos"" ([#11871](#11871)) ## @vercel/[email protected] ### Patch Changes - Revert "Revert "Fix corepack `packageManager` detection on monorepos"" ([#11871](#11871)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`04e15410f`](04e1541)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Revert "Revert "Fix corepack `packageManager` detection on monorepos"" ([#11871](#11871)) ## @vercel/[email protected] ### Patch Changes - Revert "Revert "Fix corepack `packageManager` detection on monorepos"" ([#11871](#11871)) ## @vercel/[email protected] ### Patch Changes - Revert "Revert "Fix corepack `packageManager` detection on monorepos"" ([#11871](#11871)) - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`04e15410f`](04e1541)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
EndangeredMassa
added a commit
that referenced
this pull request
Sep 11, 2024
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/[email protected] ### Patch Changes - Revert "Revert "Fix corepack `packageManager` detection on monorepos"" ([#11871](vercel/vercel#11871)) ## [email protected] ### Patch Changes - Fix gitBranch parameter for `vc env add` command ([#12085](vercel/vercel#12085)) - Updated dependencies \[[`d8836a0ed`](vercel/vercel@d8836a0)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`d8836a0ed`](vercel/vercel@d8836a0)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`d8836a0ed`](vercel/vercel@d8836a0)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Revert "Revert "Fix corepack `packageManager` detection on monorepos"" ([#11871](vercel/vercel#11871)) ## @vercel/[email protected] ### Patch Changes - Revert "Revert "Fix corepack `packageManager` detection on monorepos"" ([#11871](vercel/vercel#11871)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`d8836a0ed`](vercel/vercel@d8836a0)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Revert "Revert "Fix corepack `packageManager` detection on monorepos"" ([#11871](vercel/vercel#11871)) ## @vercel/[email protected] ### Patch Changes - Revert "Revert "Fix corepack `packageManager` detection on monorepos"" ([#11871](vercel/vercel#11871)) ## @vercel/[email protected] ### Patch Changes - Revert "Revert "Fix corepack `packageManager` detection on monorepos"" ([#11871](vercel/vercel#11871)) - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`d8836a0ed`](vercel/vercel@d8836a0)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #11865