[cli] Add target flag to vc build#11858
Merged
kodiakhq[bot] merged 4 commits intomainfrom Jul 17, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 93efd8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
onsclom
requested review from
EndangeredMassa,
TooTallNate,
erikareads,
jeffsee55 and
trek
as code owners
jeffsee55
approved these changes
Jul 16, 2024
Contributor
jeffsee55
left a comment
jeffsee55
left a comment
There was a problem hiding this comment.
No blockers from me, just a couple of questions. Looks good!
| } | ||
| }); | ||
|
|
||
| it('should pull "production" env vars with `--target production`', async () => { |
Contributor
There was a problem hiding this comment.
Nice test 👍
non-blocking: Do we have anything in place to test this with a custom environment target? Would be nice to get those in place but seems like we may not have all the pieces for that yet
|
|
||
| // Build `target` influences which environment variables will be used | ||
| const target = parsedArgs.flags['--prod'] ? 'production' : 'preview'; | ||
| const target = parsedArgs.flags['--prod'] |
Contributor
There was a problem hiding this comment.
non-blocking: do we want to throw if both --prod and --target are provided?
TooTallNate
approved these changes
Jul 17, 2024
kodiakhq
bot
deleted the
austinmerrick/zero-2185-add-target-option-to-vc-build
branch
Merged
trek
pushed a commit
that referenced
this pull request
Jul 18, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - Add target flag to vc build ([#11858](#11858)) ### Patch Changes - Better error message when calling logs command without a deployment url ([#11877](#11877)) - Updated dependencies \[[`9d9b2fee6`](9d9b2fe)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Revert "warn on mismatched corepack and detected package managers" ([#11879](#11879)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`9d9b2fee6`](9d9b2fe)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - [edge] deprecate `ipAddress` & `geolocation`. ([#11869](#11869)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`9d9b2fee6`](9d9b2fe)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`9d9b2fee6`](9d9b2fe)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`9d9b2fee6`](9d9b2fe)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - Add target flag to vc build ([#11858](vercel/vercel#11858)) ### Patch Changes - Better error message when calling logs command without a deployment url ([#11877](vercel/vercel#11877)) - Updated dependencies \[[`6232a55eb`](vercel/vercel@6232a55)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Revert "warn on mismatched corepack and detected package managers" ([#11879](vercel/vercel#11879)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`6232a55eb`](vercel/vercel@6232a55)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - [edge] deprecate `ipAddress` & `geolocation`. ([#11869](vercel/vercel#11869)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`6232a55eb`](vercel/vercel@6232a55)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`6232a55eb`](vercel/vercel@6232a55)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`6232a55eb`](vercel/vercel@6232a55)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
vc build --targetwhich can beproductionorpreviewin preparation of custom environments.