[next] Ensure we do not include ending slash in matched path#11830
Merged
kodiakhq[bot] merged 15 commits intomainfrom Jul 12, 2024
Merged
[next] Ensure we do not include ending slash in matched path#11830kodiakhq[bot] merged 15 commits intomainfrom
kodiakhq[bot] merged 15 commits intomainfrom
Conversation
ijjk
requested review from
EndangeredMassa,
TooTallNate,
erikareads,
huozhi,
jeffsee55,
onsclom,
timneutkens,
trek and
ztanner
as code owners
🦋 Changeset detectedLatest commit: 2a81962 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ijjk
force-pushed
the
ijjk/match-path-slash
branch
from
fffd0bc to
257597c
Compare
ztanner
previously approved these changes
Jul 10, 2024
packages/next/test/fixtures/00-trailing-slash-middleware-add/middleware.js
Outdated
Show resolved
Hide resolved
ztanner
approved these changes
Jul 10, 2024
trek
approved these changes
Jul 11, 2024
Contributor
|
@ijjk are these tests legit to the code change? |
Member
Author
|
@EndangeredMassa no none of them appear Next.js related or related to this change at all. They were passing before we merged main. |
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
Jul 15, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - Add target output to `vc inspect` ([#11821](#11821)) - Send `customEnvironmentSlugOrId` to the create deployment endpoint ([#11789](#11789)) - Add `vc target ls` command ([#11790](#11790)) ### Patch Changes - Various improvements to vc target ls ([#11840](#11840)) - Updated dependencies \[[`3eb40c8c2`](3eb40c8), [`d0fe663af`](d0fe663), [`b1e4a4011`](b1e4a40), [`55ab52512`](55ab525)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - Send `customEnvironmentSlugOrId` to the create deployment endpoint ([#11789](#11789)) ### Patch Changes - Updated dependencies \[[`3eb40c8c2`](3eb40c8)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - reject mismatched corepack and detected package managers ([#11603](#11603)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`3eb40c8c2`](3eb40c8)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Ensure we do not include ending slash in matched path ([#11830](#11830)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`3eb40c8c2`](3eb40c8)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Update `@remix-run/dev` fork to v2.10.2 ([#11837](#11837)) ## @vercel/[email protected] ### Patch Changes - [framework-fixtures]: Bump the core group across 1 directory with 3 updates ([#11773](#11773)) - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`3eb40c8c2`](3eb40c8)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't expect a trailing slash to be included in this header so don't include it when matching.
x-ref: slack thread