warn on mismatched corepack and detected package managers#11603
Merged
kodiakhq[bot] merged 41 commits intomainfrom Jul 9, 2024
Merged
warn on mismatched corepack and detected package managers#11603kodiakhq[bot] merged 41 commits intomainfrom
kodiakhq[bot] merged 41 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: f469113 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
EndangeredMassa
commented
May 15, 2024
EndangeredMassa
requested review from
TooTallNate,
erikareads,
jeffsee55,
onsclom and
trek
as code owners
erikareads
reviewed
May 15, 2024
trek
previously approved these changes
May 15, 2024
…thub.com/vercel/vercel into endangeredmassa/reject-mismatch-corepack
trek
previously approved these changes
May 29, 2024
EndangeredMassa
commented
May 29, 2024
EndangeredMassa
commented
May 29, 2024
onsclom
force-pushed
the
endangeredmassa/reject-mismatch-corepack
branch
from
5a1aa63 to
ed31303
Compare
Contributor
|
@EndangeredMassa and I reviewed this. Approving |
onsclom
approved these changes
Jul 5, 2024
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
Jul 15, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - Add target output to `vc inspect` ([#11821](#11821)) - Send `customEnvironmentSlugOrId` to the create deployment endpoint ([#11789](#11789)) - Add `vc target ls` command ([#11790](#11790)) ### Patch Changes - Various improvements to vc target ls ([#11840](#11840)) - Updated dependencies \[[`3eb40c8c2`](3eb40c8), [`d0fe663af`](d0fe663), [`b1e4a4011`](b1e4a40), [`55ab52512`](55ab525)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - Send `customEnvironmentSlugOrId` to the create deployment endpoint ([#11789](#11789)) ### Patch Changes - Updated dependencies \[[`3eb40c8c2`](3eb40c8)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - reject mismatched corepack and detected package managers ([#11603](#11603)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`3eb40c8c2`](3eb40c8)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Ensure we do not include ending slash in matched path ([#11830](#11830)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`3eb40c8c2`](3eb40c8)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Update `@remix-run/dev` fork to v2.10.2 ([#11837](#11837)) ## @vercel/[email protected] ### Patch Changes - [framework-fixtures]: Bump the core group across 1 directory with 3 updates ([#11773](#11773)) - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`3eb40c8c2`](3eb40c8)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
EndangeredMassa
changed the title
EndangeredMassa
added a commit
that referenced
this pull request
Jul 18, 2024
)" This reverts commit 3eb40c8.
trek
pushed a commit
that referenced
this pull request
Jul 18, 2024
QuietCraftsmanship
pushed a commit
to QuietCraftsmanship/Vercel
that referenced
this pull request
Jul 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When corepack is used and the package manager or version does not match the inferred package manager or version from the lockfile, we should throw an error. Right now, this can happen with
pnpm(for example) wherepnpmonly logs a warning, causing indeterministic builds.This PR mostly updates
getPathOverrideForPackageManagerto not care about corepack, allowing the calling code to compare the detected values to the corepack values.