[node][dev] Remove `Transfer-Encoding` header in edge function handler by srikrsna-buf · Pull Request #10701 · vercel/vercel

srikrsna-buf · 2023-10-13T04:09:20Z

Remove Transfer-Encoding header in edge function handler.

Transfer-Encoding is a hop-to-hop header and should not be proxied, it is also not valid when Content-Length is set. undici throws if we set this header.

changeset-bot · 2023-10-13T04:09:25Z

🦋 Changeset detected

Latest commit: 0f86a53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@vercel/node	Patch
vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Ethan-Arrowood

Can you add a test?

packages/node/src/edge-functions/edge-handler.mts

Co-authored-by: Sean Massa <[email protected]>

packages/node/test/unit/dev.test.ts

Co-authored-by: Sean Massa <[email protected]>

cb1kenobi

I have run the tests in a separate PR (#10721) and they all pass. This PR looks good to go!

Thank you @srikrsna-buf!

srikrsna-buf · 2023-10-24T07:55:03Z

Hey! @cb1kenobi Thank you for the quick review, can we merge this or does it need anything else?

cb1kenobi · 2023-10-24T13:12:59Z

@srikrsna-buf thank you for your patience. This PR is queued until a few other things land. Hang in there, thanks!

srikrsna-buf · 2024-01-23T10:57:13Z

@cb1kenobi any update? Should I look into the conflicts now or does it need some more time?

EndangeredMassa · 2024-01-24T16:08:54Z

@srikrsna-buf if you resolve the conflicts, we'll merge this. Thanks!

srikrsna-buf · 2024-02-28T22:00:56Z

@EndangeredMassa

Assertions expection was added

TooTallNate · 2025-01-27T19:38:35Z

Merged. Thank you @srikrsna-buf!

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/[email protected] ### Major Changes - Initial release ([#12903](#12903)) ## @vercel/[email protected] ### Minor Changes - Add `useWebApi` property to `NodejsLambda` class ([#12873](#12873)) - [build-utils] convert NodeVersion to class and add state getter ([#12883](#12883)) [ruby] convert RubyVersion to class and add state getter ## [email protected] ### Minor Changes - [cli] add Node Version to project list output table ([#12895](#12895)) ### Patch Changes - Enable executable bit for `src/vc.js` script ([#12863](#12863)) - Add video integration category to the integration install CLI ([#12870](#12870)) - [cli] update warning in ls --update-required for clarity ([#12864](#12864)) - Added headers for user-supplied rewrites ([#12847](#12847)) - [cli] refactor confirm component to use `client.input.confirm` interface ([#12846](#12846)) - [build-utils] convert NodeVersion to class and add state getter ([#12883](#12883)) [ruby] convert RubyVersion to class and add state getter - Updated dependencies \[[`56f72ffefb828c3001f7c82259ed0f71db4f629e`](56f72ff), [`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`b6bb709370d2565121808340d43d0a9d90b53de1`](b6bb709), [`85a64db8d9b6a6e9f7c6a019d51777930a806584`](85a64db), [`ac6a62eff7db3b3e2713adc1f5bd6a1331d838ce`](ac6a62e), [`f65ea2245382dd2449c96f695ed692d419a83868`](f65ea22), [`7af40c1e9d9916cbe8287359662fc940f1d24fce`](7af40c1), [`06307180c20ca07b65f7cb5e93b65c977b9ccd70`](0630718), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f), [`cefda60a603d60cc35e4697c36e751cca411e6bb`](cefda60), [`003866c4c93e893edb7a5e89b519fc8879b370c0`](003866c)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - Make vite detection supersede ionic-react ([#12880](#12880)) ## @vercel/functions@1.6.0 ### Minor Changes - Add middleware-related helper functions ([#12938](#12938)) ## @vercel/[email protected] ### Minor Changes - Add support for React Router v7 ([#12904](#12904)) - Enable `nativeFetch` when `v3_singleFetch` future flag is enabled ([#12918](#12918)) ### Patch Changes - [remix] Create an interface for differences remix vs react-router ([#12925](#12925)) ## @vercel/[email protected] ### Minor Changes - [build-utils] convert NodeVersion to class and add state getter ([#12883](#12883)) [ruby] convert RubyVersion to class and add state getter ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Bump next from 14.2.10 to 14.2.21 ([#12842](#12842)) ## @vercel/[email protected] ### Patch Changes - Fix local file system readdir to not throw on special file system stat types ([#12915](#12915)) - Updated dependencies \[[`d645bdd4312730b10bef89ad9e18e111500849fc`](d645bdd)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - ensure defaultLocale rewrite doesn't conflict with user-defined redirects ([#12916](#12916)) - Added headers for user-supplied rewrites ([#12847](#12847)) ## @vercel/[email protected] ### Patch Changes - Fix requests failing due to the presence of `Transfer-Encoding` header in edge-function dev server. ([#10701](#10701)) - Split `build()`, `prepareCache()` and `startDevServer()` into separate files ([#12872](#12872)) - Updated dependencies \[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Remove support for VERCEL_IPC_FD ([#12908](#12908)) - Add `supportsResponseStreaming` to build output ([#12884](#12884)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`745404610a836fa6c2068c5c192d2f3e8b86918f`](7454046), [`3a5507fd1459c77b4491f1c9c3a64ad42e4ff009`](3a5507f)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/[email protected] ### Major Changes - Initial release ([#12903](vercel/vercel#12903)) ## @vercel/[email protected] ### Minor Changes - Add `useWebApi` property to `NodejsLambda` class ([#12873](vercel/vercel#12873)) - [build-utils] convert NodeVersion to class and add state getter ([#12883](vercel/vercel#12883)) [ruby] convert RubyVersion to class and add state getter ## [email protected] ### Minor Changes - [cli] add Node Version to project list output table ([#12895](vercel/vercel#12895)) ### Patch Changes - Enable executable bit for `src/vc.js` script ([#12863](vercel/vercel#12863)) - Add video integration category to the integration install CLI ([#12870](vercel/vercel#12870)) - [cli] update warning in ls --update-required for clarity ([#12864](vercel/vercel#12864)) - Added headers for user-supplied rewrites ([#12847](vercel/vercel#12847)) - [cli] refactor confirm component to use `client.input.confirm` interface ([#12846](vercel/vercel#12846)) - [build-utils] convert NodeVersion to class and add state getter ([#12883](vercel/vercel#12883)) [ruby] convert RubyVersion to class and add state getter - Updated dependencies \[[`97e4eb3c468b4c35c4b930137215ecd018707121`](vercel/vercel@97e4eb3), [`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`c8b8fdca6333c3d4503be696d046f57b2f221431`](vercel/vercel@c8b8fdc), [`e7536c62bebab05ea989cf10de28c9dc311be2e8`](vercel/vercel@e7536c6), [`33c6e67f14854ef680db612944063fc405843827`](vercel/vercel@33c6e67), [`0ded32e2d5ae1d9812d70eb281b226e057b016a9`](vercel/vercel@0ded32e), [`e1e6b58819ad8606ed4e963af5e1e58984cf02d7`](vercel/vercel@e1e6b58), [`44dd8ccf5235c7019c14d2a8e34c4c0733ce110d`](vercel/vercel@44dd8cc), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052), [`ff43e4bf3f15a8875afe6f3cc9e22a37110f3751`](vercel/vercel@ff43e4b), [`a376e638ffe384b962b14685293bccfb4507ab90`](vercel/vercel@a376e63)]: - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] - @vercel/[email protected] ## @vercel/[email protected] ### Minor Changes - Make vite detection supersede ionic-react ([#12880](vercel/vercel#12880)) ## @vercel/[email protected] ### Minor Changes - Add middleware-related helper functions ([#12938](vercel/vercel#12938)) ## @vercel/[email protected] ### Minor Changes - Add support for React Router v7 ([#12904](vercel/vercel#12904)) - Enable `nativeFetch` when `v3_singleFetch` future flag is enabled ([#12918](vercel/vercel#12918)) ### Patch Changes - [remix] Create an interface for differences remix vs react-router ([#12925](vercel/vercel#12925)) ## @vercel/[email protected] ### Minor Changes - [build-utils] convert NodeVersion to class and add state getter ([#12883](vercel/vercel#12883)) [ruby] convert RubyVersion to class and add state getter ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Bump next from 14.2.10 to 14.2.21 ([#12842](vercel/vercel#12842)) ## @vercel/[email protected] ### Patch Changes - Fix local file system readdir to not throw on special file system stat types ([#12915](vercel/vercel#12915)) - Updated dependencies \[[`ac4318615e248752ad20ca031f7c903e76e52899`](vercel/vercel@ac43186)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[[`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - ensure defaultLocale rewrite doesn't conflict with user-defined redirects ([#12916](vercel/vercel#12916)) - Added headers for user-supplied rewrites ([#12847](vercel/vercel#12847)) ## @vercel/[email protected] ### Patch Changes - Fix requests failing due to the presence of `Transfer-Encoding` header in edge-function dev server. ([#10701](vercel/vercel#10701)) - Split `build()`, `prepareCache()` and `startDevServer()` into separate files ([#12872](vercel/vercel#12872)) - Updated dependencies \[[`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052)]: - @vercel/[email protected] ## @vercel/[email protected] ### Patch Changes - Remove support for VERCEL_IPC_FD ([#12908](vercel/vercel#12908)) - Add `supportsResponseStreaming` to build output ([#12884](vercel/vercel#12884)) ## @vercel/[email protected] ### Patch Changes - Updated dependencies \[]: - @vercel/[email protected] ## @vercel-internals/[email protected] ### Patch Changes - Updated dependencies \[[`0aea17613bd7c4b0cbf174f654efa0cf3abee363`](vercel/vercel@0aea176), [`1a4f0521f984ce891a3e9847d31e569f407c4319`](vercel/vercel@1a4f052)]: - @vercel/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Dev server: Remove Transfer-Encoding header

5ebbb4f

srikrsna-buf requested review from EndangeredMassa, Ethan-Arrowood, Kikobeats, TooTallNate, cb1kenobi, styfle and trek as code owners October 13, 2023 04:09

Changeset

0c8a1eb

srikrsna-buf mentioned this pull request Oct 13, 2023

Add vercel edge function example connectrpc/examples-es#1075

Closed

Ethan-Arrowood approved these changes Oct 13, 2023

View reviewed changes

Ethan-Arrowood suggested changes Oct 13, 2023

View reviewed changes

EndangeredMassa reviewed Oct 13, 2023

View reviewed changes

packages/node/src/edge-functions/edge-handler.mts Outdated Show resolved Hide resolved

srikrsna-buf and others added 2 commits October 14, 2023 00:33

Update packages/node/src/edge-functions/edge-handler.mts

cacf2ca

Co-authored-by: Sean Massa <[email protected]>

Add test

d41c67e

srikrsna-buf requested a review from Ethan-Arrowood October 14, 2023 04:05

smaeda-ks changed the title ~~Remove Transfer-Encoding header in edge function handler~~ [node][dev] Remove Transfer-Encoding header in edge function handler Oct 16, 2023

EndangeredMassa previously requested changes Oct 16, 2023

View reviewed changes

packages/node/test/unit/dev.test.ts Show resolved Hide resolved

Update packages/node/test/unit/dev.test.ts

96382b7

Co-authored-by: Sean Massa <[email protected]>

srikrsna-buf requested a review from EndangeredMassa October 16, 2023 14:52

Ethan-Arrowood previously approved these changes Oct 16, 2023

View reviewed changes

Chris Barber added 2 commits October 16, 2023 12:00

Merge branch 'main' into main

f8d2ee9

Merge branch 'main' into main

02c2f1e

cb1kenobi mentioned this pull request Oct 16, 2023

[testing] Dev server: Remove Transfer-Encoding header #10721

Closed

vercel bot deployed to Preview October 16, 2023 18:29 View deployment

Merge branch 'main' into main

e2e5375

cb1kenobi approved these changes Oct 17, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/main'

7358f67

srikrsna-buf dismissed Ethan-Arrowood’s stale review via 7358f67 January 24, 2024 16:28

EndangeredMassa added the pending-merge ready to merge, but waiting for some reason label Jan 24, 2024

Merge remote-tracking branch 'upstream/main'

561e3b6

Merge branch 'main' into main

3cc6828

TooTallNate requested review from erikareads, jeffsee55 and onsclom as code owners January 27, 2025 17:53

TooTallNate previously approved these changes Jan 27, 2025

View reviewed changes

vercel bot deployed to Preview January 27, 2025 17:56 View deployment

Fix lint

0f86a53

TooTallNate dismissed their stale review via 0f86a53 January 27, 2025 18:06

vercel bot deployed to Preview January 27, 2025 18:06 View deployment

TooTallNate enabled auto-merge January 27, 2025 18:10

TooTallNate approved these changes Jan 27, 2025

View reviewed changes

TooTallNate added this pull request to the merge queue Jan 27, 2025

Merged via the queue into vercel:main with commit b6bb709 Jan 27, 2025

vercel-release-bot mentioned this pull request Jan 27, 2025

Version Packages #12851

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[node][dev] Remove `Transfer-Encoding` header in edge function handler#10701

[node][dev] Remove `Transfer-Encoding` header in edge function handler#10701
TooTallNate merged 12 commits intovercel:mainfrom
srikrsna-buf:main

srikrsna-buf commented Oct 13, 2023

Uh oh!

changeset-bot bot commented Oct 13, 2023 •

edited

Loading

Uh oh!

Ethan-Arrowood left a comment

Uh oh!

Uh oh!

Uh oh!

cb1kenobi left a comment

Uh oh!

srikrsna-buf commented Oct 24, 2023

Uh oh!

cb1kenobi commented Oct 24, 2023

Uh oh!

srikrsna-buf commented Jan 23, 2024

Uh oh!

EndangeredMassa commented Jan 24, 2024

Uh oh!

srikrsna-buf commented Feb 28, 2024

Uh oh!

TooTallNate commented Jan 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

srikrsna-buf commented Oct 13, 2023

Uh oh!

changeset-bot bot commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Ethan-Arrowood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cb1kenobi left a comment

Choose a reason for hiding this comment

Uh oh!

srikrsna-buf commented Oct 24, 2023

Uh oh!

cb1kenobi commented Oct 24, 2023

Uh oh!

srikrsna-buf commented Jan 23, 2024

Uh oh!

EndangeredMassa commented Jan 24, 2024

Uh oh!

srikrsna-buf commented Feb 28, 2024

Uh oh!

TooTallNate commented Jan 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

changeset-bot bot commented Oct 13, 2023 •

edited

Loading