Skip to content

Use pnpm publish -r to publish packages - #10022

Merged
kodiakhq[bot] merged 2 commits into
mainfrom
update/changeset-pnpm-publish
May 24, 2023
Merged

kodiakhq[bot] merged 2 commits into
mainfrom
update/changeset-pnpm-publish

Conversation

@TooTallNate

Copy link
Copy Markdown
Member

Following the instructions here: https://pnpm.io/using-changesets

This should ensure that packages are published in the correct order (see related issue: changesets/changesets#238).

Following the instructions here: https://pnpm.io/using-changesets

This should ensure that packages are published in the correct order (see
related issue: changesets/changesets#238).
@changeset-bot

changeset-bot Bot commented May 24, 2023 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 22f8eab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kodiakhq
kodiakhq Bot merged commit 1e47bbf into main May 24, 2023
@kodiakhq
kodiakhq Bot deleted the update/changeset-pnpm-publish branch May 24, 2023 21:56
TooTallNate added a commit that referenced this pull request May 26, 2023
This reverts commit 1e47bbf.

`changeset publish` also creates git tags, whereas `pnpm publish -r`
does not. This causes the GitHub Releases to not be created.
kodiakhq Bot pushed a commit that referenced this pull request May 26, 2023
This reverts commit 1e47bbf.

`changeset publish` also creates git tags, whereas `pnpm publish -r` does not. This causes the GitHub Releases to not be created.
TooTallNate added a commit that referenced this pull request May 30, 2023
This is a re-application of #10022 (which was reverted in #10032), but
with the addition of `changeset tag` after the `pnpm publish -r` command.
This ensures the proper git tags are also created, allowing for the
GitHub releases to be published.
kodiakhq Bot pushed a commit that referenced this pull request May 30, 2023
This is a re-application of #10022 (which was reverted in #10032), but with the addition of `changeset tag` after the `pnpm publish -r` command. This ensures the proper git tags are also created, allowing for the GitHub releases to be published.

This branch was successfully deployed

1 active deployment
Preview — 22f8eabf Deployed May 24, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants