Merge branch 'main' into austinmerrick/remove-zeit-fetch-dep

onsclom · web-flow · commit d3850ed15f9b · 2024-09-27T11:06:57.000-07:00
diff --git a/.changeset/polite-snakes-exist.md b/.changeset/polite-snakes-exist.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/packages/node/src/dev-server.mts b/packages/node/src/dev-server.mts
@@ -168,6 +168,7 @@ process.on('message', async m => {
         await onExit();
       }
       process.exit(0);
+      break;
     default:
       console.error(`unknown IPC message from parent:`, m);
       break;
diff --git a/packages/node/test/unit/dev.test.ts b/packages/node/test/unit/dev.test.ts
@@ -63,7 +63,19 @@ async function withDevServer(
   } finally {
     const elapsed = Date.now() - start;
     if (runningTimeout) await setTimeout(runningTimeout - elapsed);
-    child.send('shutdown', error => error && child.kill(9));
+    child.send('shutdown', error => {
+      if (error) {
+        console.log('Shutdown error:', error);
+        try {
+          child.kill(9);
+        } catch (error) {
+          // In Node 22, there's a bug where attempting to kill a child process
+          // results in an EPERM error. Ignore the error in that case.
+          // See: https://github.com/nodejs/node/issues/51766
+          console.log('Ignoring kill error:', error);
+        }
+      }
+    });
     if (child.exitCode === null) await once(child, 'exit');
   }
 }
diff --git a/utils/chunk-tests.js b/utils/chunk-tests.js
@@ -10,7 +10,7 @@ const runnersMap = new Map([
       max: 1,
       testScript: 'vitest-run',
       runners: ['ubuntu-latest', 'macos-14', 'windows-latest'],
-      nodeVersions: ['16', '18', '20'],
+      nodeVersions: ['16', '18', '20', '22'],
     },
   ],
   [

Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,7 @@ process.on('message', async m => {`
`168`	`168`	`await onExit();`
`169`	`169`	`}`
`170`	`170`	`process.exit(0);`
	`171`	`+ break;`
`171`	`172`	`default:`
`172`	`173`	console.error(`unknown IPC message from parent:`, m);
`173`	`174`	`break;`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ const runnersMap = new Map([`
`10`	`10`	`max: 1,`
`11`	`11`	`testScript: 'vitest-run',`
`12`	`12`	`runners: ['ubuntu-latest', 'macos-14', 'windows-latest'],`
`13`		`- nodeVersions: ['16', '18', '20'],`
	`13`	`+ nodeVersions: ['16', '18', '20', '22'],`
`14`	`14`	`},`
`15`	`15`	`],`
`16`	`16`	`[`