Skip to content

Commit c7dd17b

Browse files
authored
Merge branch 'main' into erikarowland/add-framework-slug-to-framework-settings
2 parents 706394c + 94545f4 commit c7dd17b

File tree

5 files changed

+38
-33
lines changed

5 files changed

+38
-33
lines changed

.changeset/itchy-pumpkins-leave.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

packages/cli/test/unit/commands/build/index.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@ vi.setConfig({ testTimeout: 6 * 60 * 1000 });
1616
const fixture = (name: string) =>
1717
join(__dirname, '../../../fixtures/unit/commands/build', name);
1818

19-
describe('build', () => {
19+
const flakey =
20+
process.platform === 'win32' && process.version.startsWith('v22');
21+
22+
describe.skipIf(flakey)('build', () => {
2023
beforeEach(() => {
2124
delete process.env.__VERCEL_BUILD_RUNNING;
2225
});

packages/remix/test/integration-legacy.test.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,16 @@ vi.setConfig({ testTimeout: 12 * 60 * 1000 });
1010

1111
const fixturesPath = join(__dirname, 'fixtures-legacy');
1212

13+
const skipped: string[] = [
14+
// PLACE TEST FIXTURE NAMES HERE TO SKIP THEM
15+
'04-with-npm9-linked',
16+
];
17+
1318
// eslint-disable-next-line no-restricted-syntax
1419
for (const fixture of fs.readdirSync(fixturesPath)) {
20+
if (skipped.includes(fixture)) {
21+
continue;
22+
}
1523
// eslint-disable-next-line no-loop-func
1624
it(`should build ${fixture}`, async () => {
1725
await expect(

utils/chunk-tests.js

Lines changed: 22 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -160,39 +160,29 @@ async function getChunkedTests() {
160160
} = runnerOptions;
161161

162162
const sortedTestPaths = testPaths.sort((a, b) => a.localeCompare(b));
163-
return (
164-
intoChunks(min, max, sortedTestPaths)
165-
.flatMap((chunk, chunkNumber, allChunks) => {
166-
return nodeVersions.flatMap(nodeVersion => {
167-
return runners.map(runner => {
168-
return {
169-
runner,
170-
packagePath,
171-
packageName,
172-
scriptName,
173-
testScript,
174-
nodeVersion,
175-
testPaths: chunk.map(testFile =>
176-
path.relative(
177-
path.join(__dirname, '../', packagePath),
178-
testFile
179-
)
180-
),
181-
chunkNumber: chunkNumber + 1,
182-
allChunksLength: allChunks.length,
183-
};
184-
});
163+
return intoChunks(min, max, sortedTestPaths).flatMap(
164+
(chunk, chunkNumber, allChunks) => {
165+
return nodeVersions.flatMap(nodeVersion => {
166+
return runners.map(runner => {
167+
return {
168+
runner,
169+
packagePath,
170+
packageName,
171+
scriptName,
172+
testScript,
173+
nodeVersion,
174+
testPaths: chunk.map(testFile =>
175+
path.relative(
176+
path.join(__dirname, '../', packagePath),
177+
testFile
178+
)
179+
),
180+
chunkNumber: chunkNumber + 1,
181+
allChunksLength: allChunks.length,
182+
};
185183
});
186-
})
187-
// Skipping vitest-unit on windows with Node 22
188-
.filter(chunk => {
189-
const flakeyTest =
190-
chunk.nodeVersion === '22' &&
191-
chunk.runner === 'windows-latest' &&
192-
chunk.scriptName === 'vitest-unit' &&
193-
chunk.packagePath === 'packages/cli';
194-
return !flakeyTest;
195-
})
184+
});
185+
}
196186
);
197187
});
198188
}

0 commit comments

Comments
 (0)